Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1737908 > unrolled thread
| Started by | Haiyang Zhang <haiyangz@exchange.microsoft.com> |
|---|---|
| First post | 2017-09-23 00:40 +0200 |
| Last post | 2017-09-26 05:30 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH net-next] hv_netvsc: Fix the real number of queues of non-vRSS cases Haiyang Zhang <haiyangz@exchange.microsoft.com> - 2017-09-23 00:40 +0200
Re: [PATCH net-next] hv_netvsc: Fix the real number of queues of non-vRSS cases Stephen Hemminger <stephen@networkplumber.org> - 2017-09-25 12:40 +0200
Re: [PATCH net-next] hv_netvsc: Fix the real number of queues of non-vRSS cases David Miller <davem@davemloft.net> - 2017-09-26 05:30 +0200
| From | Haiyang Zhang <haiyangz@exchange.microsoft.com> |
|---|---|
| Date | 2017-09-23 00:40 +0200 |
| Subject | [PATCH net-next] hv_netvsc: Fix the real number of queues of non-vRSS cases |
| Message-ID | <usEM1-3mF-1@gated-at.bofh.it> |
From: Haiyang Zhang <haiyangz@microsoft.com>
For older hosts without multi-channel (vRSS) support, and some error
cases, we still need to set the real number of queues to one.
This patch adds this missing setting.
Fixes: 8195b1396ec8 ("hv_netvsc: fix deadlock on hotplug")
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
---
drivers/net/hyperv/netvsc_drv.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c
index d4902ee5f260..68eac12fbf75 100644
--- a/drivers/net/hyperv/netvsc_drv.c
+++ b/drivers/net/hyperv/netvsc_drv.c
@@ -1929,6 +1929,12 @@ static int netvsc_probe(struct hv_device *dev,
/* We always need headroom for rndis header */
net->needed_headroom = RNDIS_AND_PPI_SIZE;
+ /* Initialize the number of queues to be 1, we may change it if more
+ * channels are offered later.
+ */
+ netif_set_real_num_tx_queues(net, 1);
+ netif_set_real_num_rx_queues(net, 1);
+
/* Notify the netvsc driver of the new device */
memset(&device_info, 0, sizeof(device_info));
device_info.ring_size = ring_size;
--
2.14.1
[toc] | [next] | [standalone]
| From | Stephen Hemminger <stephen@networkplumber.org> |
|---|---|
| Date | 2017-09-25 12:40 +0200 |
| Subject | Re: [PATCH net-next] hv_netvsc: Fix the real number of queues of non-vRSS cases |
| Message-ID | <utyXV-55N-23@gated-at.bofh.it> |
| In reply to | #1737908 |
On Fri, 22 Sep 2017 15:31:38 -0700
Haiyang Zhang <haiyangz@exchange.microsoft.com> wrote:
> From: Haiyang Zhang <haiyangz@microsoft.com>
>
> For older hosts without multi-channel (vRSS) support, and some error
> cases, we still need to set the real number of queues to one.
> This patch adds this missing setting.
>
> Fixes: 8195b1396ec8 ("hv_netvsc: fix deadlock on hotplug")
> Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Yes, this should fix issues with WS2012.
Reviewed-by: Stephen Hemminger <sthemmin@microsoft.com>
[toc] | [prev] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2017-09-26 05:30 +0200 |
| Subject | Re: [PATCH net-next] hv_netvsc: Fix the real number of queues of non-vRSS cases |
| Message-ID | <utOJk-7rZ-13@gated-at.bofh.it> |
| In reply to | #1737908 |
From: Haiyang Zhang <haiyangz@exchange.microsoft.com>
Date: Fri, 22 Sep 2017 15:31:38 -0700
> From: Haiyang Zhang <haiyangz@microsoft.com>
>
> For older hosts without multi-channel (vRSS) support, and some error
> cases, we still need to set the real number of queues to one.
> This patch adds this missing setting.
>
> Fixes: 8195b1396ec8 ("hv_netvsc: fix deadlock on hotplug")
> Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Applied.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web