Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1735785 > unrolled thread

[PATCH] pinctrl: meson: fix incorrect usage of ENOSYS

Back to article view | Back to linux.kernel

Contents

  [PATCH] pinctrl: meson: fix incorrect usage of ENOSYS Jerome Brunet <jbrunet@baylibre.com> - 2017-09-20 16:10 +0200
    Re: [PATCH] pinctrl: meson: fix incorrect usage of ENOSYS Linus Walleij <linus.walleij@linaro.org> - 2017-09-21 14:20 +0200

#1735785 — [PATCH] pinctrl: meson: fix incorrect usage of ENOSYS

ENOSYS is special and should only be used for incorrect syscall number.
It is not the case here. let's use ENOTSUPP instead.

Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
 drivers/pinctrl/meson/pinctrl-meson.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/meson/pinctrl-meson.c b/drivers/pinctrl/meson/pinctrl-meson.c
index c9cd54de0449..71bccb7acbf8 100644
--- a/drivers/pinctrl/meson/pinctrl-meson.c
+++ b/drivers/pinctrl/meson/pinctrl-meson.c
@@ -399,7 +399,7 @@ static int meson_pinconf_group_set(struct pinctrl_dev *pcdev,
 static int meson_pinconf_group_get(struct pinctrl_dev *pcdev,
 				   unsigned int group, unsigned long *config)
 {
-	return -ENOSYS;
+	return -ENOTSUPP;
 }
 
 static const struct pinconf_ops meson_pinconf_ops = {
-- 
2.13.5

[toc] | [next] | [standalone]

#1736610

On Wed, Sep 20, 2017 at 4:08 PM, Jerome Brunet <jbrunet@baylibre.com> wrote:

> ENOSYS is special and should only be used for incorrect syscall number.
> It is not the case here. let's use ENOTSUPP instead.
>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>

Patch applied.

Yours,
Linus Walleij

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web