Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1736571 > unrolled thread

[PATCH 6/6] lightnvm: include NVM Express driver if OCSSD is selected for build

Started byRakesh Pandit <rakesh@tuxera.com>
First post2017-09-21 13:30 +0200
Last post2017-09-21 15:50 +0200
Articles 3 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH 6/6] lightnvm: include NVM Express driver if OCSSD is  selected for build Rakesh Pandit <rakesh@tuxera.com> - 2017-09-21 13:30 +0200
    Re: [PATCH 6/6] lightnvm: include NVM Express driver if OCSSD is  selected for build Matias Bjørling <mb@lightnvm.io> - 2017-09-21 13:40 +0200
      Re: [PATCH 6/6] lightnvm: include NVM Express driver if OCSSD is  selected for build Rakesh Pandit <rakesh@tuxera.com> - 2017-09-21 15:50 +0200

#1736571 — [PATCH 6/6] lightnvm: include NVM Express driver if OCSSD is selected for build

FromRakesh Pandit <rakesh@tuxera.com>
Date2017-09-21 13:30 +0200
Subject[PATCH 6/6] lightnvm: include NVM Express driver if OCSSD is selected for build
Message-ID<us7Q8-kv-61@gated-at.bofh.it>
Because NVM needs BLK_DEV_NVME, select it automatically if we mark NVM
in config file before building kernel.

Signed-off-by: Rakesh Pandit <rakesh@tuxera.com>
---
 drivers/lightnvm/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/lightnvm/Kconfig b/drivers/lightnvm/Kconfig
index ead61a9..b3c00cb 100644
--- a/drivers/lightnvm/Kconfig
+++ b/drivers/lightnvm/Kconfig
@@ -5,6 +5,7 @@
 menuconfig NVM
 	bool "Open-Channel SSD target support"
 	depends on BLOCK && HAS_DMA
+	select BLK_DEV_NVME
 	help
 	  Say Y here to get to enable Open-channel SSDs.
 
-- 
2.5.0

[toc] | [next] | [standalone]


#1736586

FromMatias Bjørling <mb@lightnvm.io>
Date2017-09-21 13:40 +0200
Message-ID<us7ZN-o2-25@gated-at.bofh.it>
In reply to#1736571
On 09/21/2017 01:28 PM, Rakesh Pandit wrote:
> Because NVM needs BLK_DEV_NVME, select it automatically if we mark NVM
> in config file before building kernel.
> 
> Signed-off-by: Rakesh Pandit <rakesh@tuxera.com>
> ---
>   drivers/lightnvm/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/lightnvm/Kconfig b/drivers/lightnvm/Kconfig
> index ead61a9..b3c00cb 100644
> --- a/drivers/lightnvm/Kconfig
> +++ b/drivers/lightnvm/Kconfig
> @@ -5,6 +5,7 @@
>   menuconfig NVM
>   	bool "Open-Channel SSD target support"
>   	depends on BLOCK && HAS_DMA
> +	select BLK_DEV_NVME
>   	help
>   	  Say Y here to get to enable Open-channel SSDs.
>   
> 

Thanks Rakesh. I've picked it up for 4.15.

[toc] | [prev] | [next] | [standalone]


#1736663

FromRakesh Pandit <rakesh@tuxera.com>
Date2017-09-21 15:50 +0200
Message-ID<usa1A-1Eh-11@gated-at.bofh.it>
In reply to#1736586
On Thu, Sep 21, 2017 at 01:32:40PM +0200, Matias Bjørling wrote:
> On 09/21/2017 01:28 PM, Rakesh Pandit wrote:
> > Because NVM needs BLK_DEV_NVME, select it automatically if we mark NVM
> > in config file before building kernel.
> > 
> > Signed-off-by: Rakesh Pandit <rakesh@tuxera.com>
> > ---
> >   drivers/lightnvm/Kconfig | 1 +
> >   1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/lightnvm/Kconfig b/drivers/lightnvm/Kconfig
> > index ead61a9..b3c00cb 100644
> > --- a/drivers/lightnvm/Kconfig
> > +++ b/drivers/lightnvm/Kconfig
> > @@ -5,6 +5,7 @@
> >   menuconfig NVM
> >   	bool "Open-Channel SSD target support"
> >   	depends on BLOCK && HAS_DMA
> > +	select BLK_DEV_NVME
> >   	help
> >   	  Say Y here to get to enable Open-channel SSDs.
> > 
> 
> Thanks Rakesh. I've picked it up for 4.15.

As discussed (IRC) I wasn't very careful first time and missed
appending PCI to depends as select doesn't visit dependencies
automatically.  Will post a version 2 soon.

Will only post version 2 of this very patch.

Doesn't make sense to push anything else from set.  Thank you in
advance,

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web