Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1735688 > unrolled thread
| Started by | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| First post | 2017-09-20 12:10 +0200 |
| Last post | 2017-09-21 18:00 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 1/3] ASoC: davinci-mcasp: Handle return value of devm_kasprintf Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-09-20 12:10 +0200
Re: [PATCH 1/3] ASoC: davinci-mcasp: Handle return value of devm_kasprintf Peter Ujfalusi <peter.ujfalusi@ti.com> - 2017-09-21 13:20 +0200
Applied "ASoC: davinci-mcasp: Handle return value of devm_kasprintf" to the asoc tree Mark Brown <broonie@kernel.org> - 2017-09-21 18:00 +0200
| From | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| Date | 2017-09-20 12:10 +0200 |
| Subject | [PATCH 1/3] ASoC: davinci-mcasp: Handle return value of devm_kasprintf |
| Message-ID | <urK78-1zN-15@gated-at.bofh.it> |
devm_kasprintf() can fail here and we must check its return value.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
sound/soc/davinci/davinci-mcasp.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/sound/soc/davinci/davinci-mcasp.c b/sound/soc/davinci/davinci-mcasp.c
index f395bbc..d1a4aa2 100644
--- a/sound/soc/davinci/davinci-mcasp.c
+++ b/sound/soc/davinci/davinci-mcasp.c
@@ -1867,6 +1867,10 @@ static int davinci_mcasp_probe(struct platform_device *pdev)
if (irq >= 0) {
irq_name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "%s_common",
dev_name(&pdev->dev));
+ if (!irq_name) {
+ ret = -ENOMEM;
+ goto err;
+ }
ret = devm_request_threaded_irq(&pdev->dev, irq, NULL,
davinci_mcasp_common_irq_handler,
IRQF_ONESHOT | IRQF_SHARED,
@@ -1884,6 +1888,10 @@ static int davinci_mcasp_probe(struct platform_device *pdev)
if (irq >= 0) {
irq_name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "%s_rx",
dev_name(&pdev->dev));
+ if (!irq_name) {
+ ret = -ENOMEM;
+ goto err;
+ }
ret = devm_request_threaded_irq(&pdev->dev, irq, NULL,
davinci_mcasp_rx_irq_handler,
IRQF_ONESHOT, irq_name, mcasp);
@@ -1899,6 +1907,10 @@ static int davinci_mcasp_probe(struct platform_device *pdev)
if (irq >= 0) {
irq_name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "%s_tx",
dev_name(&pdev->dev));
+ if (!irq_name) {
+ ret = -ENOMEM;
+ goto err;
+ }
ret = devm_request_threaded_irq(&pdev->dev, irq, NULL,
davinci_mcasp_tx_irq_handler,
IRQF_ONESHOT, irq_name, mcasp);
--
1.9.1
[toc] | [next] | [standalone]
| From | Peter Ujfalusi <peter.ujfalusi@ti.com> |
|---|---|
| Date | 2017-09-21 13:20 +0200 |
| Subject | Re: [PATCH 1/3] ASoC: davinci-mcasp: Handle return value of devm_kasprintf |
| Message-ID | <us7Gq-gp-9@gated-at.bofh.it> |
| In reply to | #1735688 |
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
On 2017-09-20 13:06, Arvind Yadav wrote:
> devm_kasprintf() can fail here and we must check its return value.
Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> sound/soc/davinci/davinci-mcasp.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/sound/soc/davinci/davinci-mcasp.c b/sound/soc/davinci/davinci-mcasp.c
> index f395bbc..d1a4aa2 100644
> --- a/sound/soc/davinci/davinci-mcasp.c
> +++ b/sound/soc/davinci/davinci-mcasp.c
> @@ -1867,6 +1867,10 @@ static int davinci_mcasp_probe(struct platform_device *pdev)
> if (irq >= 0) {
> irq_name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "%s_common",
> dev_name(&pdev->dev));
> + if (!irq_name) {
> + ret = -ENOMEM;
> + goto err;
> + }
> ret = devm_request_threaded_irq(&pdev->dev, irq, NULL,
> davinci_mcasp_common_irq_handler,
> IRQF_ONESHOT | IRQF_SHARED,
> @@ -1884,6 +1888,10 @@ static int davinci_mcasp_probe(struct platform_device *pdev)
> if (irq >= 0) {
> irq_name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "%s_rx",
> dev_name(&pdev->dev));
> + if (!irq_name) {
> + ret = -ENOMEM;
> + goto err;
> + }
> ret = devm_request_threaded_irq(&pdev->dev, irq, NULL,
> davinci_mcasp_rx_irq_handler,
> IRQF_ONESHOT, irq_name, mcasp);
> @@ -1899,6 +1907,10 @@ static int davinci_mcasp_probe(struct platform_device *pdev)
> if (irq >= 0) {
> irq_name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "%s_tx",
> dev_name(&pdev->dev));
> + if (!irq_name) {
> + ret = -ENOMEM;
> + goto err;
> + }
> ret = devm_request_threaded_irq(&pdev->dev, irq, NULL,
> davinci_mcasp_tx_irq_handler,
> IRQF_ONESHOT, irq_name, mcasp);
>
- Péter
[toc] | [prev] | [next] | [standalone]
| From | Mark Brown <broonie@kernel.org> |
|---|---|
| Date | 2017-09-21 18:00 +0200 |
| Subject | Applied "ASoC: davinci-mcasp: Handle return value of devm_kasprintf" to the asoc tree |
| Message-ID | <usc3n-2WW-1@gated-at.bofh.it> |
| In reply to | #1735688 |
The patch
ASoC: davinci-mcasp: Handle return value of devm_kasprintf
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
From 0c8b794c4a10aaf7ac0d4a49be2b2638e2038adb Mon Sep 17 00:00:00 2001
From: Arvind Yadav <arvind.yadav.cs@gmail.com>
Date: Wed, 20 Sep 2017 15:36:09 +0530
Subject: [PATCH] ASoC: davinci-mcasp: Handle return value of devm_kasprintf
devm_kasprintf() can fail here and we must check its return value.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
sound/soc/davinci/davinci-mcasp.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/sound/soc/davinci/davinci-mcasp.c b/sound/soc/davinci/davinci-mcasp.c
index 40be08cecea4..804c6f2bcf21 100644
--- a/sound/soc/davinci/davinci-mcasp.c
+++ b/sound/soc/davinci/davinci-mcasp.c
@@ -1868,6 +1868,10 @@ static int davinci_mcasp_probe(struct platform_device *pdev)
if (irq >= 0) {
irq_name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "%s_common",
dev_name(&pdev->dev));
+ if (!irq_name) {
+ ret = -ENOMEM;
+ goto err;
+ }
ret = devm_request_threaded_irq(&pdev->dev, irq, NULL,
davinci_mcasp_common_irq_handler,
IRQF_ONESHOT | IRQF_SHARED,
@@ -1885,6 +1889,10 @@ static int davinci_mcasp_probe(struct platform_device *pdev)
if (irq >= 0) {
irq_name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "%s_rx",
dev_name(&pdev->dev));
+ if (!irq_name) {
+ ret = -ENOMEM;
+ goto err;
+ }
ret = devm_request_threaded_irq(&pdev->dev, irq, NULL,
davinci_mcasp_rx_irq_handler,
IRQF_ONESHOT, irq_name, mcasp);
@@ -1900,6 +1908,10 @@ static int davinci_mcasp_probe(struct platform_device *pdev)
if (irq >= 0) {
irq_name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "%s_tx",
dev_name(&pdev->dev));
+ if (!irq_name) {
+ ret = -ENOMEM;
+ goto err;
+ }
ret = devm_request_threaded_irq(&pdev->dev, irq, NULL,
davinci_mcasp_tx_irq_handler,
IRQF_ONESHOT, irq_name, mcasp);
--
2.14.1
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web