Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1736369 > unrolled thread

[PATCH] staging:rtl8188eu:hal Fix wrong comparison to False

Back to article view | Back to linux.kernel

Contents

  [PATCH] staging:rtl8188eu:hal Fix wrong comparison to False Janani Sankara Babu <jananis37@gmail.com> - 2017-09-21 07:50 +0200
    Re: [PATCH] staging:rtl8188eu:hal Fix wrong comparison to False Dan Carpenter <dan.carpenter@oracle.com> - 2017-09-21 09:20 +0200

#1736369 — [PATCH] staging:rtl8188eu:hal Fix wrong comparison to False

This patch solves the warning "Using comparison to false is error prone"

Signed-off-by: Janani Sankara Babu <jananis37@gmail.com>
---
 drivers/staging/rtl8188eu/hal/odm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8188eu/hal/odm.c b/drivers/staging/rtl8188eu/hal/odm.c
index ec8aae7..001d626 100644
--- a/drivers/staging/rtl8188eu/hal/odm.c
+++ b/drivers/staging/rtl8188eu/hal/odm.c
@@ -382,7 +382,7 @@ void odm_DIG(struct odm_dm_struct *pDM_Odm)
 	}
 
 	/* add by Neil Chen to avoid PSD is processing */
-	if (pDM_Odm->bDMInitialGainEnable == false) {
+	if (!pDM_Odm->bDMInitialGainEnable) {
 		ODM_RT_TRACE(pDM_Odm, ODM_COMP_DIG, ODM_DBG_LOUD, ("odm_DIG() Return: PSD is Processing\n"));
 		return;
 	}
-- 
1.9.1

[toc] | [next] | [standalone]

#1736418

On Thu, Sep 21, 2017 at 11:09:55AM +0530, Janani Sankara Babu wrote:
> This patch solves the warning "Using comparison to false is error prone"

Out of curiosity, which tool complains about that?

regards,
dan carpenter

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web