Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1735320 > unrolled thread
| Started by | Vito Caputo <vcaputo@pengaru.com> |
|---|---|
| First post | 2017-09-20 00:40 +0200 |
| Last post | 2017-09-20 12:30 +0200 |
| Articles | 5 — 4 participants |
Back to article view | Back to linux.kernel
[PATCH] net: ethernet: aquantia: default to no in config Vito Caputo <vcaputo@pengaru.com> - 2017-09-20 00:40 +0200
Re: [PATCH] net: ethernet: aquantia: default to no in config David Miller <davem@davemloft.net> - 2017-09-20 01:00 +0200
Re: [PATCH] net: ethernet: aquantia: default to no in config David Miller <davem@davemloft.net> - 2017-09-20 01:00 +0200
Re: [PATCH] net: ethernet: aquantia: default to no in config vcaputo@pengaru.com - 2017-09-20 01:00 +0200
Re: [PATCH] net: ethernet: aquantia: default to no in config Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2017-09-20 12:30 +0200
| From | Vito Caputo <vcaputo@pengaru.com> |
|---|---|
| Date | 2017-09-20 00:40 +0200 |
| Subject | [PATCH] net: ethernet: aquantia: default to no in config |
| Message-ID | <urzlo-2Sr-29@gated-at.bofh.it> |
NET_VENDOR_AQUANTIA was "default y" for some reason, which seems obviously inappropriate. --- drivers/net/ethernet/aquantia/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/aquantia/Kconfig b/drivers/net/ethernet/aquantia/Kconfig index cdf78e069a39..6167b13cf349 100644 --- a/drivers/net/ethernet/aquantia/Kconfig +++ b/drivers/net/ethernet/aquantia/Kconfig @@ -4,7 +4,7 @@ config NET_VENDOR_AQUANTIA bool "aQuantia devices" - default y + default n ---help--- Set this to y if you have an Ethernet network cards that uses the aQuantia AQC107/AQC108 chipset. -- 2.11.0
[toc] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2017-09-20 01:00 +0200 |
| Message-ID | <urzEJ-2YQ-7@gated-at.bofh.it> |
| In reply to | #1735320 |
From: vcaputo@pengaru.com Date: Tue, 19 Sep 2017 16:02:49 -0700 > Out of curiosity, what's the rationale for that decision? So that you don't need to know what special vendor knob needs to be switched in order to even be offered the config knob for the driver you are interested in.
[toc] | [prev] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2017-09-20 01:00 +0200 |
| Message-ID | <urzEJ-2YQ-9@gated-at.bofh.it> |
| In reply to | #1735320 |
From: Vito Caputo <vcaputo@pengaru.com> Date: Tue, 19 Sep 2017 15:43:15 -0700 > NET_VENDOR_AQUANTIA was "default y" for some reason, which seems > obviously inappropriate. It is appropriate. We make all vendor guards default to yes.
[toc] | [prev] | [next] | [standalone]
| From | vcaputo@pengaru.com |
|---|---|
| Date | 2017-09-20 01:00 +0200 |
| Message-ID | <urzEJ-2YQ-11@gated-at.bofh.it> |
| In reply to | #1735334 |
On Tue, Sep 19, 2017 at 03:52:31PM -0700, David Miller wrote: > From: Vito Caputo <vcaputo@pengaru.com> > Date: Tue, 19 Sep 2017 15:43:15 -0700 > > > NET_VENDOR_AQUANTIA was "default y" for some reason, which seems > > obviously inappropriate. > > It is appropriate. > > We make all vendor guards default to yes. Thanks for the quick response. Out of curiosity, what's the rationale for that decision?
[toc] | [prev] | [next] | [standalone]
| From | Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> |
|---|---|
| Date | 2017-09-20 12:30 +0200 |
| Message-ID | <urKqt-1H9-1@gated-at.bofh.it> |
| In reply to | #1735320 |
Hello!
On 9/20/2017 1:43 AM, Vito Caputo wrote:
> NET_VENDOR_AQUANTIA was "default y" for some reason, which seems
> obviously inappropriate.
> ---
> drivers/net/ethernet/aquantia/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/aquantia/Kconfig b/drivers/net/ethernet/aquantia/Kconfig
> index cdf78e069a39..6167b13cf349 100644
> --- a/drivers/net/ethernet/aquantia/Kconfig
> +++ b/drivers/net/ethernet/aquantia/Kconfig
> @@ -4,7 +4,7 @@
>
> config NET_VENDOR_AQUANTIA
> bool "aQuantia devices"
> - default y
> + default n
Just remove it -- 'n' is the default default. :-)
[...]
MBR, Sergei
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web