Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1735264 > unrolled thread
| Started by | Colin King <colin.king@canonical.com> |
|---|---|
| First post | 2017-09-19 23:10 +0200 |
| Last post | 2017-09-25 10:30 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] mwifiex: make const array tos_to_ac static, reduces object code size Colin King <colin.king@canonical.com> - 2017-09-19 23:10 +0200
Re: mwifiex: make const array tos_to_ac static, reduces object code size Kalle Valo <kvalo@codeaurora.org> - 2017-09-25 10:30 +0200
| From | Colin King <colin.king@canonical.com> |
|---|---|
| Date | 2017-09-19 23:10 +0200 |
| Subject | [PATCH] mwifiex: make const array tos_to_ac static, reduces object code size |
| Message-ID | <urxWh-251-9@gated-at.bofh.it> |
From: Colin Ian King <colin.king@canonical.com>
Don't populate the read-only const array tos_to_ac on the stack,
instead make it static. Makes the object code smaller by 250 bytes:
Before:
text data bss dec hex filename
26104 2720 128 28952 7118 wmm.o
After:
text data bss dec hex filename
25758 2816 128 28702 701e wmm.o
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/wireless/marvell/mwifiex/wmm.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/marvell/mwifiex/wmm.c b/drivers/net/wireless/marvell/mwifiex/wmm.c
index 0edd26881321..936a0a841af8 100644
--- a/drivers/net/wireless/marvell/mwifiex/wmm.c
+++ b/drivers/net/wireless/marvell/mwifiex/wmm.c
@@ -359,7 +359,8 @@ static enum mwifiex_wmm_ac_e
mwifiex_wmm_convert_tos_to_ac(struct mwifiex_adapter *adapter, u32 tos)
{
/* Map of TOS UP values to WMM AC */
- const enum mwifiex_wmm_ac_e tos_to_ac[] = { WMM_AC_BE,
+ static const enum mwifiex_wmm_ac_e tos_to_ac[] = {
+ WMM_AC_BE,
WMM_AC_BK,
WMM_AC_BK,
WMM_AC_BE,
--
2.14.1
[toc] | [next] | [standalone]
| From | Kalle Valo <kvalo@codeaurora.org> |
|---|---|
| Date | 2017-09-25 10:30 +0200 |
| Subject | Re: mwifiex: make const array tos_to_ac static, reduces object code size |
| Message-ID | <utwW5-3OI-11@gated-at.bofh.it> |
| In reply to | #1735264 |
Colin Ian King <colin.king@canonical.com> wrote: > From: Colin Ian King <colin.king@canonical.com> > > Don't populate the read-only const array tos_to_ac on the stack, > instead make it static. Makes the object code smaller by 250 bytes: > > Before: > text data bss dec hex filename > 26104 2720 128 28952 7118 wmm.o > > After: > text data bss dec hex filename > 25758 2816 128 28702 701e wmm.o > > Signed-off-by: Colin Ian King <colin.king@canonical.com> Patch applied to wireless-drivers-next.git, thanks. 7dfb0ebd022b mwifiex: make const array tos_to_ac static, reduces object code size -- https://patchwork.kernel.org/patch/9960331/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web