Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1734120 > unrolled thread

[PATCH net-next] net: mvpp2: remove useless goto

Started byAntoine Tenart <antoine.tenart@free-electrons.com>
First post2017-09-18 15:40 +0200
Last post2017-09-19 22:50 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH net-next] net: mvpp2: remove useless goto Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-09-18 15:40 +0200
    Re: [PATCH net-next] net: mvpp2: remove useless goto David Miller <davem@davemloft.net> - 2017-09-19 22:50 +0200

#1734120 — [PATCH net-next] net: mvpp2: remove useless goto

FromAntoine Tenart <antoine.tenart@free-electrons.com>
Date2017-09-18 15:40 +0200
Subject[PATCH net-next] net: mvpp2: remove useless goto
Message-ID<ur4ri-6TZ-37@gated-at.bofh.it>
Remove a goto in the PPv2 tx function which jumps to the next line
anyway. This is a cosmetic commit.

Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>
---
 drivers/net/ethernet/marvell/mvpp2.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/marvell/mvpp2.c b/drivers/net/ethernet/marvell/mvpp2.c
index dd0ee2691c86..8041d692db3c 100644
--- a/drivers/net/ethernet/marvell/mvpp2.c
+++ b/drivers/net/ethernet/marvell/mvpp2.c
@@ -6452,7 +6452,6 @@ static int mvpp2_tx(struct sk_buff *skb, struct net_device *dev)
 		if (mvpp2_tx_frag_process(port, skb, aggr_txq, txq)) {
 			tx_desc_unmap_put(port, txq, tx_desc);
 			frags = 0;
-			goto out;
 		}
 	}
 
-- 
2.13.5

[toc] | [next] | [standalone]


#1735248

FromDavid Miller <davem@davemloft.net>
Date2017-09-19 22:50 +0200
Message-ID<urxCW-1Jf-5@gated-at.bofh.it>
In reply to#1734120
From: Antoine Tenart <antoine.tenart@free-electrons.com>
Date: Mon, 18 Sep 2017 15:36:51 +0200

> Remove a goto in the PPv2 tx function which jumps to the next line
> anyway. This is a cosmetic commit.
> 
> Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>

Applied, thanks.

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web