Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1733068 > unrolled thread

[PATCH] clk: pxa: fix building on older compilers

Back to article view | Back to linux.kernel

Contents

  [PATCH] clk: pxa: fix building on older compilers Arnd Bergmann <arnd@arndb.de> - 2017-09-15 22:00 +0200
    Re: [PATCH] clk: pxa: fix building on older compilers Robert Jarzmik <robert.jarzmik@free.fr> - 2017-09-19 20:50 +0200

#1733068 — [PATCH] clk: pxa: fix building on older compilers

gcc-4.4 got confused by the inline assembler statement:

drivers/clk/pxa/clk-pxa.c: In function 'pxa2xx_core_turbo_switch':
drivers/clk/pxa/clk-pxa.c:152: error: expected string literal before ')' token

This removes the extraneous ':' to let all compilers parse the
driver correctly.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/clk/pxa/clk-pxa.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/clk/pxa/clk-pxa.c b/drivers/clk/pxa/clk-pxa.c
index 74f64c3c4290..b80dc9d5855c 100644
--- a/drivers/clk/pxa/clk-pxa.c
+++ b/drivers/clk/pxa/clk-pxa.c
@@ -147,9 +147,7 @@ void pxa2xx_core_turbo_switch(bool on)
 	"	b	3f\n"
 	"2:	b	1b\n"
 	"3:	nop\n"
-		: "=&r" (unused)
-		: "r" (clkcfg)
-		: );
+		: "=&r" (unused) : "r" (clkcfg));
 
 	local_irq_restore(flags);
 }
-- 
2.9.0

[toc] | [next] | [standalone]

#1735171

Arnd Bergmann <arnd@arndb.de> writes:

> gcc-4.4 got confused by the inline assembler statement:
>
> drivers/clk/pxa/clk-pxa.c: In function 'pxa2xx_core_turbo_switch':
> drivers/clk/pxa/clk-pxa.c:152: error: expected string literal before ')' token
>
> This removes the extraneous ':' to let all compilers parse the
> driver correctly.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>

Cheers.

--
Robert

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web