Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1735152 > unrolled thread
| Started by | Hans de Goede <hdegoede@redhat.com> |
|---|---|
| First post | 2017-09-19 20:40 +0200 |
| Last post | 2017-09-20 18:20 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH 1/2] mux: add mux_control_get_optional() API Hans de Goede <hdegoede@redhat.com> - 2017-09-19 20:40 +0200
Re: [PATCH 1/2] mux: add mux_control_get_optional() API Stephen Boyd <stephen.boyd@linaro.org> - 2017-09-20 18:20 +0200
| From | Hans de Goede <hdegoede@redhat.com> |
|---|---|
| Date | 2017-09-19 20:40 +0200 |
| Subject | Re: [PATCH 1/2] mux: add mux_control_get_optional() API |
| Message-ID | <urvB8-tP-7@gated-at.bofh.it> |
Hi, On 09/08/2017 05:54 PM, Peter Rosin wrote: > On 2017-09-08 17:45, Peter Rosin wrote: >> From: Stephen Boyd <stephen.boyd@linaro.org> >> >> Sometimes drivers only use muxes under certain scenarios. For >> example, the chipidea usb controller may be connected to a usb >> switch on some platforms, and connected directly to a usb port on >> others. The driver won't know one way or the other though, so add >> a mux_control_get_optional() API that allows the driver to >> differentiate errors getting the mux from there not being a mux >> for the driver to use at all. >> --- >> Documentation/driver-model/devres.txt | 1 + >> drivers/mux/core.c | 104 +++++++++++++++++++++++++++------- >> include/linux/mux/consumer.h | 4 ++ >> 3 files changed, 89 insertions(+), 20 deletions(-) >> >> I haven't tested this patch, and hence I have not signed it and I also >> removed the sign-off from Stephen... > > Huh, I definitely intended to mention that this patch is based on [1] > from Stephen, but that I've made changes according to the comments in > that thread (and more). And those changes are what made me remove the > sign-off from Stephen... AFAIK normally a Signed-off-by is kept if some (small-ish) changes are made. The S-o-b is mostly an indication that the author is ok with adding the code to the kernel under the GPL. Anyways, Stephen are you ok with re-adding your S-o-b to the version modified by Peter? Regards, Hans
[toc] | [next] | [standalone]
| From | Stephen Boyd <stephen.boyd@linaro.org> |
|---|---|
| Date | 2017-09-20 18:20 +0200 |
| Message-ID | <urPTb-5ov-7@gated-at.bofh.it> |
| In reply to | #1735152 |
Quoting Hans de Goede (2017-09-19 11:35:50) > Hi, > > On 09/08/2017 05:54 PM, Peter Rosin wrote: > > On 2017-09-08 17:45, Peter Rosin wrote: > >> From: Stephen Boyd <stephen.boyd@linaro.org> > >> > >> Sometimes drivers only use muxes under certain scenarios. For > >> example, the chipidea usb controller may be connected to a usb > >> switch on some platforms, and connected directly to a usb port on > >> others. The driver won't know one way or the other though, so add > >> a mux_control_get_optional() API that allows the driver to > >> differentiate errors getting the mux from there not being a mux > >> for the driver to use at all. > >> --- > >> Documentation/driver-model/devres.txt | 1 + > >> drivers/mux/core.c | 104 +++++++++++++++++++++++++++------- > >> include/linux/mux/consumer.h | 4 ++ > >> 3 files changed, 89 insertions(+), 20 deletions(-) > >> > >> I haven't tested this patch, and hence I have not signed it and I also > >> removed the sign-off from Stephen... > > > > Huh, I definitely intended to mention that this patch is based on [1] > > from Stephen, but that I've made changes according to the comments in > > that thread (and more). And those changes are what made me remove the > > sign-off from Stephen... > > AFAIK normally a Signed-off-by is kept if some (small-ish) changes > are made. The S-o-b is mostly an indication that the author is > ok with adding the code to the kernel under the GPL. > > Anyways, Stephen are you ok with re-adding your S-o-b to > the version modified by Peter? > Please add my sign off Signed-off-by: Stephen Boyd <stephen.boyd@linaro.org> and I would expect Peter to have one as well with a maintainer tag indicating what changed from my patch.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web