Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1734068 > unrolled thread

Re: [PATCH] arm: omap: dra7xx: Set OPT_CLKS_IN_RESET flag for gpio1

Started byKeerthy <j-keerthy@ti.com>
First post2017-09-18 13:50 +0200
Last post2017-09-19 19:50 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH] arm: omap: dra7xx: Set OPT_CLKS_IN_RESET flag for gpio1 Keerthy <j-keerthy@ti.com> - 2017-09-18 13:50 +0200
    Re: [PATCH] arm: omap: dra7xx: Set OPT_CLKS_IN_RESET flag for gpio1 Tony Lindgren <tony@atomide.com> - 2017-09-19 19:50 +0200

#1734068 — Re: [PATCH] arm: omap: dra7xx: Set OPT_CLKS_IN_RESET flag for gpio1

FromKeerthy <j-keerthy@ti.com>
Date2017-09-18 13:50 +0200
SubjectRe: [PATCH] arm: omap: dra7xx: Set OPT_CLKS_IN_RESET flag for gpio1
Message-ID<ur2IO-5LK-5@gated-at.bofh.it>

On Wednesday 06 September 2017 04:03 PM, Keerthy wrote:
> gpio1 soft reset fails in the kexec path as the optional clock
> is not enabled hence enable the HWMOD_CONTROL_OPT_CLKS_IN_RESET
> flag for gpio1 hwmod.

A gentle ping on this as well.

> 
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
>  arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> index 7cc3247..6ae729a 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> @@ -1037,6 +1037,7 @@ struct omap_hwmod dra7xx_sha0_hwmod = {
>  	.name		= "gpio1",
>  	.class		= &dra7xx_gpio_hwmod_class,
>  	.clkdm_name	= "wkupaon_clkdm",
> +	.flags		= HWMOD_CONTROL_OPT_CLKS_IN_RESET,
>  	.main_clk	= "wkupaon_iclk_mux",
>  	.prcm = {
>  		.omap4 = {
> 

[toc] | [next] | [standalone]


#1735125

FromTony Lindgren <tony@atomide.com>
Date2017-09-19 19:50 +0200
Message-ID<uruOK-8qP-13@gated-at.bofh.it>
In reply to#1734068
* Keerthy <j-keerthy@ti.com> [170918 04:40]:
> 
> 
> On Wednesday 06 September 2017 04:03 PM, Keerthy wrote:
> > gpio1 soft reset fails in the kexec path as the optional clock
> > is not enabled hence enable the HWMOD_CONTROL_OPT_CLKS_IN_RESET
> > flag for gpio1 hwmod.
> 
> A gentle ping on this as well.

With v4.14-rc1 now out, applying into omap-for-v4.14/fixes.
I usually don't start applying fixes during the merge window
unless really needed.

Regards,

Tony


> > Signed-off-by: Keerthy <j-keerthy@ti.com>
> > ---
> >  arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> > index 7cc3247..6ae729a 100644
> > --- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> > +++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> > @@ -1037,6 +1037,7 @@ struct omap_hwmod dra7xx_sha0_hwmod = {
> >  	.name		= "gpio1",
> >  	.class		= &dra7xx_gpio_hwmod_class,
> >  	.clkdm_name	= "wkupaon_clkdm",
> > +	.flags		= HWMOD_CONTROL_OPT_CLKS_IN_RESET,
> >  	.main_clk	= "wkupaon_iclk_mux",
> >  	.prcm = {
> >  		.omap4 = {
> > 

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web