Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1734503 > unrolled thread
| Started by | Stephen Rothwell <sfr@canb.auug.org.au> |
|---|---|
| First post | 2017-09-19 00:00 +0200 |
| Last post | 2017-09-19 18:00 +0200 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
linux-next: Signed-off-by missing for commits in the staging tree Stephen Rothwell <sfr@canb.auug.org.au> - 2017-09-19 00:00 +0200
Re: linux-next: Signed-off-by missing for commits in the staging tree Greg KH <greg@kroah.com> - 2017-09-19 08:10 +0200
Re: linux-next: Signed-off-by missing for commits in the staging tree Tobin Harding <me@tobin.cc> - 2017-09-19 17:40 +0200
Re: linux-next: Signed-off-by missing for commits in the staging tree Tobin Harding <me@tobin.cc> - 2017-09-19 18:00 +0200
| From | Stephen Rothwell <sfr@canb.auug.org.au> |
|---|---|
| Date | 2017-09-19 00:00 +0200 |
| Subject | linux-next: Signed-off-by missing for commits in the staging tree |
| Message-ID | <urcf8-3Gm-21@gated-at.bofh.it> |
Hi Greg,
Commits
688a0206cfb8 ("staging: rtlwifi: fix parenthesis alignment")
85d309d53f7a ("staging: rtlwifi: use kcalloc instead of multiply")
f216f6cdeb1d ("staging: rtlwifi: remove unused functions")
are missing a Signed-off-by from their author.
--
Cheers,
Stephen Rothwell
[toc] | [next] | [standalone]
| From | Greg KH <greg@kroah.com> |
|---|---|
| Date | 2017-09-19 08:10 +0200 |
| Message-ID | <urjTj-oG-1@gated-at.bofh.it> |
| In reply to | #1734503 |
On Tue, Sep 19, 2017 at 07:54:55AM +1000, Stephen Rothwell wrote:
> Hi Greg,
>
> Commits
>
> 688a0206cfb8 ("staging: rtlwifi: fix parenthesis alignment")
> 85d309d53f7a ("staging: rtlwifi: use kcalloc instead of multiply")
> f216f6cdeb1d ("staging: rtlwifi: remove unused functions")
>
> are missing a Signed-off-by from their author.
Ugh, I totally missed that, Tobin, what went wrong here?
I can't go rewrite my tree, so I'll just accept this as an implicit "ok"
for these patches, any objection?
thanks,
greg k-h
[toc] | [prev] | [next] | [standalone]
| From | Tobin Harding <me@tobin.cc> |
|---|---|
| Date | 2017-09-19 17:40 +0200 |
| Message-ID | <ursMX-7dF-35@gated-at.bofh.it> |
| In reply to | #1734667 |
On Tue, Sep 19, 2017, at 16:09, Greg KH wrote:
> On Tue, Sep 19, 2017 at 07:54:55AM +1000, Stephen Rothwell wrote:
> > Hi Greg,
> >
> > Commits
> >
> > 688a0206cfb8 ("staging: rtlwifi: fix parenthesis alignment")
> > 85d309d53f7a ("staging: rtlwifi: use kcalloc instead of multiply")
> > f216f6cdeb1d ("staging: rtlwifi: remove unused functions")
> >
> > are missing a Signed-off-by from their author.
>
> Ugh, I totally missed that, Tobin, what went wrong here?
Apologies, I bet I didn't set up my environment on the laptop fully.
Usual dev machine is a desktop, I did these patches as prep for OSS.
> I can't go rewrite my tree, so I'll just accept this as an implicit "ok"
> for these patches, any objection?
Ok by me.
Thanks,
Tobin.
[toc] | [prev] | [next] | [standalone]
| From | Tobin Harding <me@tobin.cc> |
|---|---|
| Date | 2017-09-19 18:00 +0200 |
| Message-ID | <urt6j-7kk-35@gated-at.bofh.it> |
| In reply to | #1735020 |
On Wed, Sep 20, 2017, at 01:34, Tobin Harding wrote:
>
> On Tue, Sep 19, 2017, at 16:09, Greg KH wrote:
> > On Tue, Sep 19, 2017 at 07:54:55AM +1000, Stephen Rothwell wrote:
> > > Hi Greg,
> > >
> > > Commits
> > >
> > > 688a0206cfb8 ("staging: rtlwifi: fix parenthesis alignment")
> > > 85d309d53f7a ("staging: rtlwifi: use kcalloc instead of multiply")
> > > f216f6cdeb1d ("staging: rtlwifi: remove unused functions")
> > >
> > > are missing a Signed-off-by from their author.
> >
> > Ugh, I totally missed that, Tobin, what went wrong here?
>
> Apologies, I bet I didn't set up my environment on the laptop fully.
> Usual dev machine is a desktop, I did these patches as prep for OSS.
I've got a strong feeling I didn't enable the driver before I 'built'
this patch series also. Bad Tobin.
Luckily the kbot didn't punish me.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web