Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1734887 > unrolled thread

Re: [PATCH 2/3] kcov: remove pointless current != NULL check

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 2/3] kcov: remove pointless current != NULL check Dmitry Vyukov <dvyukov@google.com> - 2017-09-19 15:00 +0200

#1734887 — Re: [PATCH 2/3] kcov: remove pointless current != NULL check

On Tue, Sep 19, 2017 at 2:46 PM, Andrey Ryabinin
<aryabinin@virtuozzo.com> wrote:
> __sanitizer_cov_trace_pc() is a hot code, so it's worth
> to remove pointless '!current' check. Current is never NULL.
>
> Signed-off-by: Andrey Ryabinin <aryabinin@virtuozzo.com>

Acked-by: Dmitry Vyukov <dvyukov@google.com>

> ---
>  kernel/kcov.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/kcov.c b/kernel/kcov.c
> index 2f0e7a7c7afc..14cc8c1a7cad 100644
> --- a/kernel/kcov.c
> +++ b/kernel/kcov.c
> @@ -61,7 +61,7 @@ void notrace __sanitizer_cov_trace_pc(void)
>          * We are interested in code coverage as a function of a syscall inputs,
>          * so we ignore code executed in interrupts.
>          */
> -       if (!t || !in_task())
> +       if (!in_task())
>                 return;
>         mode = READ_ONCE(t->kcov_mode);
>         if (mode == KCOV_MODE_TRACE) {
> --
> 2.13.5
>

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web