Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1732589 > unrolled thread
| Started by | Jiri Kosina <jikos@kernel.org> |
|---|---|
| First post | 2017-09-14 23:20 +0200 |
| Last post | 2017-09-19 13:50 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] livepatch: __klp_shadow_get_or_alloc() is local to shadow.c Jiri Kosina <jikos@kernel.org> - 2017-09-14 23:20 +0200
Re: [PATCH] livepatch: __klp_shadow_get_or_alloc() is local to shadow.c Joe Lawrence <joe.lawrence@redhat.com> - 2017-09-15 16:30 +0200
Re: [PATCH] livepatch: __klp_shadow_get_or_alloc() is local to shadow.c Miroslav Benes <mbenes@suse.cz> - 2017-09-19 13:50 +0200
| From | Jiri Kosina <jikos@kernel.org> |
|---|---|
| Date | 2017-09-14 23:20 +0200 |
| Subject | [PATCH] livepatch: __klp_shadow_get_or_alloc() is local to shadow.c |
| Message-ID | <upJIe-1Oa-17@gated-at.bofh.it> |
From: Jiri Kosina <jkosina@suse.cz>
... therefore make it static.
Fixes: 439e7271dc2 ("livepatch: introduce shadow variable API")
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
---
Sorry for not having spotted this before pushing out.
kernel/livepatch/shadow.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/livepatch/shadow.c b/kernel/livepatch/shadow.c
index 67e4360..fdac275 100644
--- a/kernel/livepatch/shadow.c
+++ b/kernel/livepatch/shadow.c
@@ -113,7 +113,7 @@ void *klp_shadow_get(void *obj, unsigned long id)
}
EXPORT_SYMBOL_GPL(klp_shadow_get);
-void *__klp_shadow_get_or_alloc(void *obj, unsigned long id, void *data,
+static void *__klp_shadow_get_or_alloc(void *obj, unsigned long id, void *data,
size_t size, gfp_t gfp_flags, bool warn_on_exist)
{
struct klp_shadow *new_shadow;
--
1.8.5.6
[toc] | [next] | [standalone]
| From | Joe Lawrence <joe.lawrence@redhat.com> |
|---|---|
| Date | 2017-09-15 16:30 +0200 |
| Message-ID | <upZN0-48G-23@gated-at.bofh.it> |
| In reply to | #1732589 |
On Thu, Sep 14, 2017 at 02:15:36PM -0700, Jiri Kosina wrote:
> From: Jiri Kosina <jkosina@suse.cz>
>
> ... therefore make it static.
>
> Fixes: 439e7271dc2 ("livepatch: introduce shadow variable API")
> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
> ---
>
> Sorry for not having spotted this before pushing out.
>
> kernel/livepatch/shadow.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/livepatch/shadow.c b/kernel/livepatch/shadow.c
> index 67e4360..fdac275 100644
> --- a/kernel/livepatch/shadow.c
> +++ b/kernel/livepatch/shadow.c
> @@ -113,7 +113,7 @@ void *klp_shadow_get(void *obj, unsigned long id)
> }
> EXPORT_SYMBOL_GPL(klp_shadow_get);
>
> -void *__klp_shadow_get_or_alloc(void *obj, unsigned long id, void *data,
> +static void *__klp_shadow_get_or_alloc(void *obj, unsigned long id, void *data,
> size_t size, gfp_t gfp_flags, bool warn_on_exist)
> {
> struct klp_shadow *new_shadow;
> --
> 1.8.5.6
Acked-by: Joe Lawrence <joe.lawrence@redhat.com>
Thanks for cleaning this up, Jiri.
Also thanks to Miroslav, Petr, Nicolai and Josh for the patchset
reviews!
-- Joe
[toc] | [prev] | [next] | [standalone]
| From | Miroslav Benes <mbenes@suse.cz> |
|---|---|
| Date | 2017-09-19 13:50 +0200 |
| Message-ID | <urpcl-4Vk-9@gated-at.bofh.it> |
| In reply to | #1732589 |
On Thu, 14 Sep 2017, Jiri Kosina wrote:
> From: Jiri Kosina <jkosina@suse.cz>
>
> ... therefore make it static.
>
> Fixes: 439e7271dc2 ("livepatch: introduce shadow variable API")
> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
> ---
FWIW (but I noticed you've already applied it)
Acked-by: Miroslav Benes <mbenes@suse.cz>
Miroslav
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web