Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1734866 > unrolled thread

[PATCH] params: Align add_sysfs_param documentation with code

Started byJean Delvare <jdelvare@suse.de>
First post2017-09-19 14:30 +0200
Last post2017-09-23 06:40 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] params: Align add_sysfs_param documentation with code Jean Delvare <jdelvare@suse.de> - 2017-09-19 14:30 +0200
    Re: [PATCH] params: Align add_sysfs_param documentation with code Rusty Russell <rusty@rustcorp.com.au> - 2017-09-23 06:40 +0200

#1734866 — [PATCH] params: Align add_sysfs_param documentation with code

FromJean Delvare <jdelvare@suse.de>
Date2017-09-19 14:30 +0200
Subject[PATCH] params: Align add_sysfs_param documentation with code
Message-ID<urpP6-5pF-25@gated-at.bofh.it>
This parameter is named kp, so the documentation should use that.

Signed-off-by: Jean Delvare <jdelvare@suse.de>
Fixes: 9b473de87209 ("param: Fix duplicate module prefixes")
Cc: Rusty Russell <rusty@rustcorp.com.au>
---
 kernel/params.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-4.14-rc1.orig/kernel/params.c	2017-09-17 00:47:51.000000000 +0200
+++ linux-4.14-rc1/kernel/params.c	2017-09-19 14:19:51.399247222 +0200
@@ -600,7 +600,7 @@ EXPORT_SYMBOL(kernel_param_unlock);
 /*
  * add_sysfs_param - add a parameter to sysfs
  * @mk: struct module_kobject
- * @kparam: the actual parameter definition to add to sysfs
+ * @kp: the actual parameter definition to add to sysfs
  * @name: name of parameter
  *
  * Create a kobject if for a (per-module) parameter if mp NULL, and

-- 
Jean Delvare
SUSE L3 Support

[toc] | [next] | [standalone]


#1737960

FromRusty Russell <rusty@rustcorp.com.au>
Date2017-09-23 06:40 +0200
Message-ID<usKop-6Um-3@gated-at.bofh.it>
In reply to#1734866
Jean Delvare <jdelvare@suse.de> writes:

> This parameter is named kp, so the documentation should use that.
>
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Fixes: 9b473de87209 ("param: Fix duplicate module prefixes")
> Cc: Rusty Russell <rusty@rustcorp.com.au>

Acked-by: Rusty Russell <rusty@rustcorp.com.au>

Thanks,
Rusty.

> ---
>  kernel/params.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-4.14-rc1.orig/kernel/params.c	2017-09-17 00:47:51.000000000 +0200
> +++ linux-4.14-rc1/kernel/params.c	2017-09-19 14:19:51.399247222 +0200
> @@ -600,7 +600,7 @@ EXPORT_SYMBOL(kernel_param_unlock);
>  /*
>   * add_sysfs_param - add a parameter to sysfs
>   * @mk: struct module_kobject
> - * @kparam: the actual parameter definition to add to sysfs
> + * @kp: the actual parameter definition to add to sysfs
>   * @name: name of parameter
>   *
>   * Create a kobject if for a (per-module) parameter if mp NULL, and
>
> -- 
> Jean Delvare
> SUSE L3 Support

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web