Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1732068 > unrolled thread
| Started by | Adrian Hunter <adrian.hunter@intel.com> |
|---|---|
| First post | 2017-09-14 08:50 +0200 |
| Last post | 2017-09-19 08:00 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v1 5/5] mmc: Kconfig: Enable CONFIG_MMC_SDHCI_IO_ACCESSORS Adrian Hunter <adrian.hunter@intel.com> - 2017-09-14 08:50 +0200
Re: [PATCH v1 5/5] mmc: Kconfig: Enable CONFIG_MMC_SDHCI_IO_ACCESSORS Vijay Viswanath <vviswana@codeaurora.org> - 2017-09-19 06:10 +0200
Re: [PATCH v1 5/5] mmc: Kconfig: Enable CONFIG_MMC_SDHCI_IO_ACCESSORS Adrian Hunter <adrian.hunter@intel.com> - 2017-09-19 08:00 +0200
| From | Adrian Hunter <adrian.hunter@intel.com> |
|---|---|
| Date | 2017-09-14 08:50 +0200 |
| Subject | Re: [PATCH v1 5/5] mmc: Kconfig: Enable CONFIG_MMC_SDHCI_IO_ACCESSORS |
| Message-ID | <upw8h-1A4-11@gated-at.bofh.it> |
On 30/08/17 15:51, Vijay Viswanath wrote: > Enable CONFIG_MMC_SDHCI_IO_ACCESSORS so that SDHC controller specific > register read and write APIs, if registered, can be used. Missing signed-off Why don't you put this patch earlier in the patch set and then you don't need all the ifdef CONFIG_MMC_SDHCI_IO_ACCESSORS ? > --- > drivers/mmc/host/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig > index 2db84dd..64a9298 100644 > --- a/drivers/mmc/host/Kconfig > +++ b/drivers/mmc/host/Kconfig > @@ -420,6 +420,7 @@ config MMC_SDHCI_MSM > tristate "Qualcomm SDHCI Controller Support" > depends on ARCH_QCOM || (ARM && COMPILE_TEST) > depends on MMC_SDHCI_PLTFM > + select CONFIG_MMC_SDHCI_IO_ACCESSORS CONFIG_MMC_SDHCI_IO_ACCESSORS -> MMC_SDHCI_IO_ACCESSORS > help > This selects the Secure Digital Host Controller Interface (SDHCI) > support present in Qualcomm SOCs. The controller supports >
[toc] | [next] | [standalone]
| From | Vijay Viswanath <vviswana@codeaurora.org> |
|---|---|
| Date | 2017-09-19 06:10 +0200 |
| Message-ID | <uri1c-7Do-17@gated-at.bofh.it> |
| In reply to | #1732068 |
On 9/14/2017 12:04 PM, Adrian Hunter wrote: > On 30/08/17 15:51, Vijay Viswanath wrote: >> Enable CONFIG_MMC_SDHCI_IO_ACCESSORS so that SDHC controller specific >> register read and write APIs, if registered, can be used. > > Missing signed-off > > Why don't you put this patch earlier in the patch set and then you don't > need all the ifdef CONFIG_MMC_SDHCI_IO_ACCESSORS ? > This will involve merging the current patches 3 & 4 into one (Some functions defined under ifdef in patch 3 are used only in patch 4). Will that be fine ? >> --- >> drivers/mmc/host/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig >> index 2db84dd..64a9298 100644 >> --- a/drivers/mmc/host/Kconfig >> +++ b/drivers/mmc/host/Kconfig >> @@ -420,6 +420,7 @@ config MMC_SDHCI_MSM >> tristate "Qualcomm SDHCI Controller Support" >> depends on ARCH_QCOM || (ARM && COMPILE_TEST) >> depends on MMC_SDHCI_PLTFM >> + select CONFIG_MMC_SDHCI_IO_ACCESSORS > > CONFIG_MMC_SDHCI_IO_ACCESSORS -> MMC_SDHCI_IO_ACCESSORS > >> help >> This selects the Secure Digital Host Controller Interface (SDHCI) >> support present in Qualcomm SOCs. The controller supports >> >
[toc] | [prev] | [next] | [standalone]
| From | Adrian Hunter <adrian.hunter@intel.com> |
|---|---|
| Date | 2017-09-19 08:00 +0200 |
| Message-ID | <urjJE-6l-5@gated-at.bofh.it> |
| In reply to | #1734642 |
On 19/09/17 07:03, Vijay Viswanath wrote: > > > On 9/14/2017 12:04 PM, Adrian Hunter wrote: >> On 30/08/17 15:51, Vijay Viswanath wrote: >>> Enable CONFIG_MMC_SDHCI_IO_ACCESSORS so that SDHC controller specific >>> register read and write APIs, if registered, can be used. >> >> Missing signed-off >> >> Why don't you put this patch earlier in the patch set and then you don't >> need all the ifdef CONFIG_MMC_SDHCI_IO_ACCESSORS ? >> > > This will involve merging the current patches 3 & 4 into one (Some functions > defined under ifdef in patch 3 are used only in patch 4). Will that be fine ? Sure > >>> --- >>> drivers/mmc/host/Kconfig | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig >>> index 2db84dd..64a9298 100644 >>> --- a/drivers/mmc/host/Kconfig >>> +++ b/drivers/mmc/host/Kconfig >>> @@ -420,6 +420,7 @@ config MMC_SDHCI_MSM >>> tristate "Qualcomm SDHCI Controller Support" >>> depends on ARCH_QCOM || (ARM && COMPILE_TEST) >>> depends on MMC_SDHCI_PLTFM >>> + select CONFIG_MMC_SDHCI_IO_ACCESSORS >> >> CONFIG_MMC_SDHCI_IO_ACCESSORS -> MMC_SDHCI_IO_ACCESSORS >> >>> help >>> This selects the Secure Digital Host Controller Interface (SDHCI) >>> support present in Qualcomm SOCs. The controller supports >>> >> >
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web