Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1734608 > unrolled thread

[PATCH v2 1/8] objtool: Don't report end of section error after an empty unwind hint

Started byJosh Poimboeuf <jpoimboe@redhat.com>
First post2017-09-19 04:50 +0200
Last post2017-09-19 04:50 +0200
Articles 1 — 1 participant

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [PATCH v2 1/8] objtool: Don't report end of section error after an empty unwind hint Josh Poimboeuf <jpoimboe@redhat.com> - 2017-09-19 04:50 +0200

#1734608 — [PATCH v2 1/8] objtool: Don't report end of section error after an empty unwind hint

FromJosh Poimboeuf <jpoimboe@redhat.com>
Date2017-09-19 04:50 +0200
Subject[PATCH v2 1/8] objtool: Don't report end of section error after an empty unwind hint
Message-ID<urgLL-6I2-1@gated-at.bofh.it>
If asm code specifies an UNWIND_HINT_EMPTY hint, don't warn if the
section ends unexpectedly.  This can happen with the xen-head.S code
because the hypercall_page is "text" but it's all zeros.

Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
---
 tools/objtool/check.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/tools/objtool/check.c b/tools/objtool/check.c
index f744617c9946..d8683f0fe04d 100644
--- a/tools/objtool/check.c
+++ b/tools/objtool/check.c
@@ -1737,11 +1737,14 @@ static int validate_branch(struct objtool_file *file, struct instruction *first,
 		if (insn->dead_end)
 			return 0;
 
-		insn = next_insn;
-		if (!insn) {
+		if (!next_insn) {
+			if (state.cfa.base == CFI_UNDEFINED)
+				return 0;
 			WARN("%s: unexpected end of section", sec->name);
 			return 1;
 		}
+
+		insn = next_insn;
 	}
 
 	return 0;
-- 
2.13.5

[toc] | [standalone]


Back to top | Article view | linux.kernel


csiph-web