Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1734559 > unrolled thread

[PATCH 0/3] Add and enable DSP device on OMAPL138 LCDK board

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/3] Add and enable DSP device on OMAPL138 LCDK board Suman Anna <s-anna@ti.com> - 2017-09-19 02:30 +0200
    [PATCH 3/3] ARM: davinci: da8xx-dt: Add OF_DEV_AUXDATA entry for DSP clock matching Suman Anna <s-anna@ti.com> - 2017-09-19 02:30 +0200
    [PATCH 2/3] ARM: dts: da850-lcdk: Add and enable CMA reserved pool for DSP Suman Anna <s-anna@ti.com> - 2017-09-19 02:30 +0200
    Re: [PATCH 0/3] Add and enable DSP device on OMAPL138 LCDK board Sekhar Nori <nsekhar@ti.com> - 2017-09-20 17:20 +0200
      Re: [PATCH 0/3] Add and enable DSP device on OMAPL138 LCDK board Suman Anna <s-anna@ti.com> - 2017-09-20 19:00 +0200

#1734559 — [PATCH 0/3] Add and enable DSP device on OMAPL138 LCDK board

Hi Sekhar,

The following series adds the DT node for the DSP device present on
on DA850/OMAPL138 SoCs. The node is disabled in the base dts file, and
enabled in the corresponding LCDK board file alongside the reserved
CMA pool required by the DSP device. The DT bindings and driver
adaptation were added to mainline in 4.14-rc1, and this series adds
the remaining dt portions. Nodes are added as per bindings in
Documentation/devicetree/bindings/remoteproc/ti,davinci-rproc.txt

Patches are based on 4.14-rc1. The first 2 patches adds the base DTS
node and enables the device on OMAPL138 LCDK board. The last patch
allows the non-DT clock to be bound to the DT DSP device by using
of_auxdata which renames the device to the same as the non-DT device
name. This is required by the davinci remoteproc driver to properly
acquire and enable the clock for this device.

Validation done on OMAPL138 LCDK board. Supported features include
basic load/boot (tested with rpmsg_client_sample) using external
memory from the CMA pool.

regards
Suman

Suman Anna (3):
  ARM: dts: da850: Add DSP node
  ARM: dts: da850-lcdk: Add and enable CMA reserved pool for DSP
  ARM: davinci: da8xx-dt: Add OF_DEV_AUXDATA entry for DSP clock
    matching

 arch/arm/boot/dts/da850-lcdk.dts | 18 ++++++++++++++++++
 arch/arm/boot/dts/da850.dtsi     | 12 ++++++++++++
 arch/arm/mach-davinci/da8xx-dt.c |  1 +
 3 files changed, 31 insertions(+)

-- 
2.13.1

[toc] | [next] | [standalone]

#1734560 — [PATCH 3/3] ARM: davinci: da8xx-dt: Add OF_DEV_AUXDATA entry for DSP clock matching

Add the OF_DEV_AUXDATA entry needed to match the device-tree DSP node
to its non-device-tree clock, so that the da8xx-remoteproc driver can
properly enable the clocks. The device name has also been assigned
"davinci-rproc.0" to match the device id used in the da850_clks
clk_lookup array.

Signed-off-by: Suman Anna <s-anna@ti.com>
---
 arch/arm/mach-davinci/da8xx-dt.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-davinci/da8xx-dt.c b/arch/arm/mach-davinci/da8xx-dt.c
index 5699ce39e64f..f06db6700ab2 100644
--- a/arch/arm/mach-davinci/da8xx-dt.c
+++ b/arch/arm/mach-davinci/da8xx-dt.c
@@ -54,6 +54,7 @@ static struct of_dev_auxdata da850_auxdata_lookup[] __initdata = {
 	OF_DEV_AUXDATA("ti,da830-usb-phy", 0x01c1417c, "da8xx-usb-phy", NULL),
 	OF_DEV_AUXDATA("ti,da850-ahci", 0x01e18000, "ahci_da850", NULL),
 	OF_DEV_AUXDATA("ti,da850-vpif", 0x01e17000, "vpif", NULL),
+	OF_DEV_AUXDATA("ti,da850-dsp", 0x11800000, "davinci-rproc.0", NULL),
 	{}
 };
 
-- 
2.13.1

[toc] | [prev] | [next] | [standalone]

#1734561 — [PATCH 2/3] ARM: dts: da850-lcdk: Add and enable CMA reserved pool for DSP

A CMA reserved memory node of 16 MB has been added and assigned to
the DSP remoteproc device on the OMAP-L138 LCDK board. The CMA starting
address matches the values used within the TI IPC 3.x software. Both
the CMA node and the corresponding rproc node are also marked okay
to enable the DSP on the OMAP-L138 LCDK board.

Signed-off-by: Suman Anna <s-anna@ti.com>
---
 arch/arm/boot/dts/da850-lcdk.dts | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/arch/arm/boot/dts/da850-lcdk.dts b/arch/arm/boot/dts/da850-lcdk.dts
index a0f0916156e6..eed89e659143 100644
--- a/arch/arm/boot/dts/da850-lcdk.dts
+++ b/arch/arm/boot/dts/da850-lcdk.dts
@@ -26,6 +26,19 @@
 		reg = <0xc0000000 0x08000000>;
 	};
 
+	reserved-memory {
+		#address-cells = <1>;
+		#size-cells = <1>;
+		ranges;
+
+		dsp_memory_region: dsp-memory@c3000000 {
+			compatible = "shared-dma-pool";
+			reg = <0xc3000000 0x1000000>;
+			reusable;
+			status = "okay";
+		};
+	};
+
 	sound {
 		compatible = "simple-audio-card";
 		simple-audio-card,name = "DA850/OMAP-L138 LCDK";
@@ -319,3 +332,8 @@
 	pinctrl-0 = <&vpif_capture_pins>;
 	status = "okay";
 };
+
+&dsp {
+	memory-region = <&dsp_memory_region>;
+	status = "okay";
+};
-- 
2.13.1

[toc] | [prev] | [next] | [standalone]

#1735827

Hi Suman,

On Tuesday 19 September 2017 05:58 AM, Suman Anna wrote:
> Hi Sekhar,
> 
> The following series adds the DT node for the DSP device present on
> on DA850/OMAPL138 SoCs. The node is disabled in the base dts file, and
> enabled in the corresponding LCDK board file alongside the reserved
> CMA pool required by the DSP device. The DT bindings and driver
> adaptation were added to mainline in 4.14-rc1, and this series adds
> the remaining dt portions. Nodes are added as per bindings in
> Documentation/devicetree/bindings/remoteproc/ti,davinci-rproc.txt
> 
> Patches are based on 4.14-rc1. The first 2 patches adds the base DTS
> node and enables the device on OMAPL138 LCDK board. The last patch
> allows the non-DT clock to be bound to the DT DSP device by using
> of_auxdata which renames the device to the same as the non-DT device
> name. This is required by the davinci remoteproc driver to properly
> acquire and enable the clock for this device.
> 
> Validation done on OMAPL138 LCDK board. Supported features include
> basic load/boot (tested with rpmsg_client_sample) using external
> memory from the CMA pool.

Applied for v4.15. The patches are on my master branch. They will be in
linux-next when I send my pull request to ARM-SoC, which typically will
take a couple of weeks more.

davinci_all_defconfig seems to be missing the CMA options needed. Could
you send a patch enabling them?

Thanks,
Sekhar

[toc] | [prev] | [next] | [standalone]

#1735910

On 09/20/2017 10:14 AM, Sekhar Nori wrote:
> Hi Suman,
> 
> On Tuesday 19 September 2017 05:58 AM, Suman Anna wrote:
>> Hi Sekhar,
>>
>> The following series adds the DT node for the DSP device present on
>> on DA850/OMAPL138 SoCs. The node is disabled in the base dts file, and
>> enabled in the corresponding LCDK board file alongside the reserved
>> CMA pool required by the DSP device. The DT bindings and driver
>> adaptation were added to mainline in 4.14-rc1, and this series adds
>> the remaining dt portions. Nodes are added as per bindings in
>> Documentation/devicetree/bindings/remoteproc/ti,davinci-rproc.txt
>>
>> Patches are based on 4.14-rc1. The first 2 patches adds the base DTS
>> node and enables the device on OMAPL138 LCDK board. The last patch
>> allows the non-DT clock to be bound to the DT DSP device by using
>> of_auxdata which renames the device to the same as the non-DT device
>> name. This is required by the davinci remoteproc driver to properly
>> acquire and enable the clock for this device.
>>
>> Validation done on OMAPL138 LCDK board. Supported features include
>> basic load/boot (tested with rpmsg_client_sample) using external
>> memory from the CMA pool.
> 
> Applied for v4.15. The patches are on my master branch. They will be in
> linux-next when I send my pull request to ARM-SoC, which typically will
> take a couple of weeks more.

Thanks Sekhar.

> 
> davinci_all_defconfig seems to be missing the CMA options needed. Could
> you send a patch enabling them?

These are tracked as dependencies on the remoteproc Kconfig, so you
won't be able to enable the driver without turning them on. I left them
as there were before my DT adaptation, but I can enable the CMA options
by default going forward.

regards
Suman

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web