Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1735841 > unrolled thread
| Started by | Masahiro Yamada <yamada.masahiro@socionext.com> |
|---|---|
| First post | 2017-09-20 17:30 +0200 |
| Last post | 2017-09-20 23:00 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] init/version: include <linux/export.h> instead of <linux/module.h> Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-09-20 17:30 +0200
Re: [PATCH] init/version: include <linux/export.h> instead of <linux/module.h> Paul Gortmaker <paul.gortmaker@windriver.com> - 2017-09-20 23:00 +0200
| From | Masahiro Yamada <yamada.masahiro@socionext.com> |
|---|---|
| Date | 2017-09-20 17:30 +0200 |
| Subject | [PATCH] init/version: include <linux/export.h> instead of <linux/module.h> |
| Message-ID | <urP6P-4Qg-25@gated-at.bofh.it> |
init/version.c has nothing to do with module, so remove the <linux/modude.h>. Instead, include <linux/export.h> for EXPORT_SYMBOL_GPL. This cuts off a lot of unnecessary header parsing. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- init/version.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/init/version.c b/init/version.c index 5606341..bfb4e3f 100644 --- a/init/version.c +++ b/init/version.c @@ -7,7 +7,7 @@ */ #include <generated/compile.h> -#include <linux/module.h> +#include <linux/export.h> #include <linux/uts.h> #include <linux/utsname.h> #include <generated/utsrelease.h> -- 2.7.4
[toc] | [next] | [standalone]
| From | Paul Gortmaker <paul.gortmaker@windriver.com> |
|---|---|
| Date | 2017-09-20 23:00 +0200 |
| Subject | Re: [PATCH] init/version: include <linux/export.h> instead of <linux/module.h> |
| Message-ID | <urUg9-855-9@gated-at.bofh.it> |
| In reply to | #1735841 |
[[PATCH] init/version: include <linux/export.h> instead of <linux/module.h>] On 21/09/2017 (Thu 00:23) Masahiro Yamada wrote: > init/version.c has nothing to do with module, so remove > the <linux/modude.h>. > > Instead, include <linux/export.h> for EXPORT_SYMBOL_GPL. I checked and there weren't any __init lurking in that file which is the usual other required replacement (<linux/init.h>) so this should be fine. Paul. -- > > This cuts off a lot of unnecessary header parsing. > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > --- > > init/version.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/init/version.c b/init/version.c > index 5606341..bfb4e3f 100644 > --- a/init/version.c > +++ b/init/version.c > @@ -7,7 +7,7 @@ > */ > > #include <generated/compile.h> > -#include <linux/module.h> > +#include <linux/export.h> > #include <linux/uts.h> > #include <linux/utsname.h> > #include <generated/utsrelease.h> > -- > 2.7.4 >
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web