Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1734963 > unrolled thread
| Started by | gfree.wind@vip.163.com |
|---|---|
| First post | 2017-09-19 16:40 +0200 |
| Last post | 2017-09-21 06:50 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH net-next] net: Remove useless function skb_header_release gfree.wind@vip.163.com - 2017-09-19 16:40 +0200
Re: [PATCH net-next] net: Remove useless function skb_header_release David Miller <davem@davemloft.net> - 2017-09-20 23:40 +0200
Re:Re: [PATCH net-next] net: Remove useless function skb_header_release "Gao Feng" <gfree.wind@vip.163.com> - 2017-09-21 06:50 +0200
| From | gfree.wind@vip.163.com |
|---|---|
| Date | 2017-09-19 16:40 +0200 |
| Subject | [PATCH net-next] net: Remove useless function skb_header_release |
| Message-ID | <urrQS-6Dj-19@gated-at.bofh.it> |
From: Gao Feng <gfree.wind@vip.163.com>
There is no one which would invokes the function skb_header_release.
So just remove it now.
Signed-off-by: Gao Feng <gfree.wind@vip.163.com>
---
include/linux/skbuff.h | 16 ----------------
1 file changed, 16 deletions(-)
diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index 72299ef..ce632cd 100644
--- a/include/linux/skbuff.h
+++ b/include/linux/skbuff.h
@@ -1457,22 +1457,6 @@ static inline int skb_header_unclone(struct sk_buff *skb, gfp_t pri)
}
/**
- * skb_header_release - release reference to header
- * @skb: buffer to operate on
- *
- * Drop a reference to the header part of the buffer. This is done
- * by acquiring a payload reference. You must not read from the header
- * part of skb->data after this.
- * Note : Check if you can use __skb_header_release() instead.
- */
-static inline void skb_header_release(struct sk_buff *skb)
-{
- BUG_ON(skb->nohdr);
- skb->nohdr = 1;
- atomic_add(1 << SKB_DATAREF_SHIFT, &skb_shinfo(skb)->dataref);
-}
-
-/**
* __skb_header_release - release reference to header
* @skb: buffer to operate on
*
--
1.9.1
[toc] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2017-09-20 23:40 +0200 |
| Subject | Re: [PATCH net-next] net: Remove useless function skb_header_release |
| Message-ID | <urUSS-84-5@gated-at.bofh.it> |
| In reply to | #1734963 |
From: gfree.wind@vip.163.com Date: Tue, 19 Sep 2017 22:32:48 +0800 > From: Gao Feng <gfree.wind@vip.163.com> > > There is no one which would invokes the function skb_header_release. > So just remove it now. > > Signed-off-by: Gao Feng <gfree.wind@vip.163.com> Networking patches must be at least CC:'d to netdev@vger.kernel.org, thank you.
[toc] | [prev] | [next] | [standalone]
| From | "Gao Feng" <gfree.wind@vip.163.com> |
|---|---|
| Date | 2017-09-21 06:50 +0200 |
| Subject | Re:Re: [PATCH net-next] net: Remove useless function skb_header_release |
| Message-ID | <us1B0-4uf-1@gated-at.bofh.it> |
| In reply to | #1736177 |
At 2017-09-21 05:30:46, "David Miller" <davem@davemloft.net> wrote: >From: gfree.wind@vip.163.com >Date: Tue, 19 Sep 2017 22:32:48 +0800 > >> From: Gao Feng <gfree.wind@vip.163.com> >> >> There is no one which would invokes the function skb_header_release. >> So just remove it now. >> >> Signed-off-by: Gao Feng <gfree.wind@vip.163.com> > >Networking patches must be at least CC:'d to netdev@vger.kernel.org, >thank you. Thanks your reminder. I just used the result of get_maintainer.pl, and didn't noticed this point you mentioned. I would send it again. Regards Feng
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web