Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1735858 > unrolled thread
| Started by | Masahiro Yamada <yamada.masahiro@socionext.com> |
|---|---|
| First post | 2017-09-20 17:50 +0200 |
| Last post | 2017-09-21 11:50 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] bitfield.h: remove 32bit from FIELD_GET comment block Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-09-20 17:50 +0200
Re: [PATCH] bitfield.h: remove 32bit from FIELD_GET comment block Jakub Kicinski <kubakici@wp.pl> - 2017-09-21 11:50 +0200
| From | Masahiro Yamada <yamada.masahiro@socionext.com> |
|---|---|
| Date | 2017-09-20 17:50 +0200 |
| Subject | [PATCH] bitfield.h: remove 32bit from FIELD_GET comment block |
| Message-ID | <urPqa-4XF-7@gated-at.bofh.it> |
I do not see anything that restricts this macro to 32 bit width. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- include/linux/bitfield.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/bitfield.h b/include/linux/bitfield.h index 9e16b33..1030651 100644 --- a/include/linux/bitfield.h +++ b/include/linux/bitfield.h @@ -92,7 +92,7 @@ /** * FIELD_GET() - extract a bitfield element * @_mask: shifted mask defining the field's length and position - * @_reg: 32bit value of entire bitfield + * @_reg: value of entire bitfield * * FIELD_GET() extracts the field specified by @_mask from the * bitfield passed in as @_reg by masking and shifting it down. -- 2.7.4
[toc] | [next] | [standalone]
| From | Jakub Kicinski <kubakici@wp.pl> |
|---|---|
| Date | 2017-09-21 11:50 +0200 |
| Message-ID | <us6hk-7zm-5@gated-at.bofh.it> |
| In reply to | #1735858 |
On Thu, 21 Sep 2017 00:39:35 +0900, Masahiro Yamada wrote: > I do not see anything that restricts this macro to 32 bit width. > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> Acked-by: Jakub Kicinski <jakub.kicinski@netronome.com> Looks like a leftover from v1 of the code, thanks for cleaning it up!
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web