Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1734847 > unrolled thread

[PATCH 0/2] ARM64: Add Vega S96 board support

Started byNeil Armstrong <narmstrong@baylibre.com>
First post2017-09-19 14:10 +0200
Last post2017-09-19 17:10 +0200
Articles 9 — 4 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/2] ARM64: Add Vega S96 board support Neil Armstrong <narmstrong@baylibre.com> - 2017-09-19 14:10 +0200
    [PATCH 1/2] ARM64: dts: meson-gxm: Add Vega S96 board Neil Armstrong <narmstrong@baylibre.com> - 2017-09-19 14:10 +0200
      Re: [PATCH 1/2] ARM64: dts: meson-gxm: Add Vega S96 board Jerome Brunet <jbrunet@baylibre.com> - 2017-09-19 17:10 +0200
        Re: [PATCH 1/2] ARM64: dts: meson-gxm: Add Vega S96 board Oleg <balbes-150@yandex.ru> - 2017-09-19 20:20 +0200
          Re: [PATCH 1/2] ARM64: dts: meson-gxm: Add Vega S96 board Neil Armstrong <narmstrong@baylibre.com> - 2017-09-20 10:30 +0200
            Re: [PATCH 1/2] ARM64: dts: meson-gxm: Add Vega S96 board Oleg <balbes-150@yandex.ru> - 2017-09-20 13:00 +0200
      Re: [PATCH 1/2] ARM64: dts: meson-gxm: Add Vega S96 board Martin Blumenstingl <martin.blumenstingl@googlemail.com> - 2017-09-19 20:00 +0200
        Re: [PATCH 1/2] ARM64: dts: meson-gxm: Add Vega S96 board Neil Armstrong <narmstrong@baylibre.com> - 2017-09-20 10:40 +0200
    Re: [PATCH 0/2] ARM64: Add Vega S96 board support Jerome Brunet <jbrunet@baylibre.com> - 2017-09-19 17:10 +0200

#1734847 — [PATCH 0/2] ARM64: Add Vega S96 board support

FromNeil Armstrong <narmstrong@baylibre.com>
Date2017-09-19 14:10 +0200
Subject[PATCH 0/2] ARM64: Add Vega S96 board support
Message-ID<urpvI-5if-3@gated-at.bofh.it>
This patchset adds support for the Tronsmart Vega S96 TV Box based
on the Q200 Amlogic Reference design.

Neil Armstrong (2):
  ARM64: dts: meson-gxm: Add Vega S96 board
  dt-bindings: arm: amlogic: Add Tronsmart Vega S96 binding

 Documentation/devicetree/bindings/arm/amlogic.txt  |  1 +
 arch/arm64/boot/dts/amlogic/Makefile               |  1 +
 arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dts | 39 ++++++++++++++++++++++
 3 files changed, 41 insertions(+)
 create mode 100644 arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dts

-- 
1.9.1

[toc] | [next] | [standalone]

#1734848 — [PATCH 1/2] ARM64: dts: meson-gxm: Add Vega S96 board

FromNeil Armstrong <narmstrong@baylibre.com>
Date2017-09-19 14:10 +0200
Subject[PATCH 1/2] ARM64: dts: meson-gxm: Add Vega S96 board
Message-ID<urpvI-5if-13@gated-at.bofh.it>
In reply to#1734847
The Tronsmart Vega S96 is a TV box derived from Amlogic q200 reference design.

Cc: support@tronsmart.com
Signed-off-by: Oleg <balbes-150@yandex.ru>
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
 arch/arm64/boot/dts/amlogic/Makefile               |  1 +
 arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dts | 39 ++++++++++++++++++++++
 2 files changed, 40 insertions(+)
 create mode 100644 arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dts

diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile
index 7a9f48c..a6c4a06 100644
--- a/arch/arm64/boot/dts/amlogic/Makefile
+++ b/arch/arm64/boot/dts/amlogic/Makefile
@@ -19,6 +19,7 @@ dtb-$(CONFIG_ARCH_MESON) += meson-gxm-nexbox-a1.dtb
 dtb-$(CONFIG_ARCH_MESON) += meson-gxm-q200.dtb
 dtb-$(CONFIG_ARCH_MESON) += meson-gxm-q201.dtb
 dtb-$(CONFIG_ARCH_MESON) += meson-gxm-rbox-pro.dtb
+dtb-$(CONFIG_ARCH_MESON) += meson-gxm-vega-s96.dtb
 
 always		:= $(dtb-y)
 subdir-y	:= $(dts-dirs)
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dts b/arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dts
new file mode 100644
index 0000000..ba74240
--- /dev/null
+++ b/arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dts
@@ -0,0 +1,39 @@
+/*
+ * Copyright (c) 2017 BayLibre, SAS.
+ * Author: Neil Armstrong <narmstrong@baylibre.com>
+ * Copyright (c) 2017 Oleg <balbes-150@yandex.ru>
+ *
+ * SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+ */
+
+/dts-v1/;
+
+#include "meson-gxm.dtsi"
+#include "meson-gx-p23x-q20x.dtsi"
+
+/ {
+	compatible = "tronsmart,vega-s96", "amlogic,s912", "amlogic,meson-gxm";
+	model = "Tronsmart Vega S96";
+
+};
+
+&ethmac {
+	pinctrl-0 = <&eth_pins>;
+	pinctrl-names = "default";
+
+	/* Select external PHY by default */
+	phy-handle = <&external_phy>;
+
+	amlogic,tx-delay-ns = <2>;
+
+	/* External PHY is in RGMII */
+	phy-mode = "rgmii";
+};
+
+&external_mdio {
+	external_phy: ethernet-phy@0 {
+		compatible = "ethernet-phy-id001c.c916", "ethernet-phy-ieee802.3-c22";
+		reg = <0>;
+		max-speed = <1000>;
+	};
+};
-- 
1.9.1

[toc] | [prev] | [next] | [standalone]

#1734987 — Re: [PATCH 1/2] ARM64: dts: meson-gxm: Add Vega S96 board

FromJerome Brunet <jbrunet@baylibre.com>
Date2017-09-19 17:10 +0200
SubjectRe: [PATCH 1/2] ARM64: dts: meson-gxm: Add Vega S96 board
Message-ID<ursjT-74b-5@gated-at.bofh.it>
In reply to#1734848
On Tue, 2017-09-19 at 14:05 +0200, Neil Armstrong wrote:
> The Tronsmart Vega S96 is a TV box derived from Amlogic q200 reference design.
> 
> Cc: support@tronsmart.com
> Signed-off-by: Oleg <balbes-150@yandex.ru>

Does Oleg have a surname ? :)

> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
>  arch/arm64/boot/dts/amlogic/Makefile               |  1 +
>  arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dts | 39
> ++++++++++++++++++++++
>  2 files changed, 40 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dts
> 
> diff --git a/arch/arm64/boot/dts/amlogic/Makefile
> b/arch/arm64/boot/dts/amlogic/Makefile
> index 7a9f48c..a6c4a06 100644
> --- a/arch/arm64/boot/dts/amlogic/Makefile
> +++ b/arch/arm64/boot/dts/amlogic/Makefile
> @@ -19,6 +19,7 @@ dtb-$(CONFIG_ARCH_MESON) += meson-gxm-nexbox-a1.dtb
>  dtb-$(CONFIG_ARCH_MESON) += meson-gxm-q200.dtb
>  dtb-$(CONFIG_ARCH_MESON) += meson-gxm-q201.dtb
>  dtb-$(CONFIG_ARCH_MESON) += meson-gxm-rbox-pro.dtb
> +dtb-$(CONFIG_ARCH_MESON) += meson-gxm-vega-s96.dtb
>  
>  always		:= $(dtb-y)
>  subdir-y	:= $(dts-dirs)
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dts
> b/arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dts
> new file mode 100644
> index 0000000..ba74240
> --- /dev/null
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dts
> @@ -0,0 +1,39 @@
> +/*
> + * Copyright (c) 2017 BayLibre, SAS.
> + * Author: Neil Armstrong <narmstrong@baylibre.com>
> + * Copyright (c) 2017 Oleg <balbes-150@yandex.ru>
> + *
> + * SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> + */
> +
> +/dts-v1/;
> +
> +#include "meson-gxm.dtsi"
> +#include "meson-gx-p23x-q20x.dtsi"
> +
> +/ {
> +	compatible = "tronsmart,vega-s96", "amlogic,s912", "amlogic,meson-
> gxm";
> +	model = "Tronsmart Vega S96";
> +
> +};
> +
> +&ethmac {
> +	pinctrl-0 = <&eth_pins>;
> +	pinctrl-names = "default";
> +
> +	/* Select external PHY by default */
> +	phy-handle = <&external_phy>;
> +
> +	amlogic,tx-delay-ns = <2>;
> +
> +	/* External PHY is in RGMII */
> +	phy-mode = "rgmii";
> +};
> +
> +&external_mdio {
> +	external_phy: ethernet-phy@0 {
> +		compatible = "ethernet-phy-id001c.c916", "ethernet-phy-
> ieee802.3-c22";
> +		reg = <0>;
> +		max-speed = <1000>;
I don't think this max-speed property is necessary

> +	};
> +};

[toc] | [prev] | [next] | [standalone]

#1735144 — Re: [PATCH 1/2] ARM64: dts: meson-gxm: Add Vega S96 board

FromOleg <balbes-150@yandex.ru>
Date2017-09-19 20:20 +0200
SubjectRe: [PATCH 1/2] ARM64: dts: meson-gxm: Add Vega S96 board
Message-ID<urvhL-nD-11@gated-at.bofh.it>
In reply to#1734987

> Does Oleg have a surname ? :)
Yes, there is Ivanov  :)



>> +		reg = <0>;
>> +		max-speed = <1000>;
> I don't think this max-speed property is necessary
>
>> +	};
>> +};

I will try to test and write the result.

[toc] | [prev] | [next] | [standalone]

#1735627 — Re: [PATCH 1/2] ARM64: dts: meson-gxm: Add Vega S96 board

FromNeil Armstrong <narmstrong@baylibre.com>
Date2017-09-20 10:30 +0200
SubjectRe: [PATCH 1/2] ARM64: dts: meson-gxm: Add Vega S96 board
Message-ID<urIym-u2-23@gated-at.bofh.it>
In reply to#1735144
On 09/19/2017 08:12 PM, Oleg wrote:
> 
> 
>> Does Oleg have a surname ? :)
> Yes, there is Ivanov  :)

Ok, then can I replace the Signed-off-bys with "Signed-off-by: Oleg Ivanov <balbes-150@yandex.ru>" ?

> 
> 
> 
>>> +        reg = <0>;
>>> +        max-speed = <1000>;
>> I don't think this max-speed property is necessary
>>
>>> +    };
>>> +};
> 
> I will try to test and write the result.

Great, thanks !

Neil

[toc] | [prev] | [next] | [standalone]

#1735715 — Re: [PATCH 1/2] ARM64: dts: meson-gxm: Add Vega S96 board

FromOleg <balbes-150@yandex.ru>
Date2017-09-20 13:00 +0200
SubjectRe: [PATCH 1/2] ARM64: dts: meson-gxm: Add Vega S96 board
Message-ID<urKTw-1Wj-27@gated-at.bofh.it>
In reply to#1735627
> Ok, then can I replace the Signed-off-bys with "Signed-off-by: Oleg Ivanov <balbes-150@yandex.ru>" ?
>

Yes, that's right. Thanks for the patch.

[toc] | [prev] | [next] | [standalone]

#1735137 — Re: [PATCH 1/2] ARM64: dts: meson-gxm: Add Vega S96 board

FromMartin Blumenstingl <martin.blumenstingl@googlemail.com>
Date2017-09-19 20:00 +0200
SubjectRe: [PATCH 1/2] ARM64: dts: meson-gxm: Add Vega S96 board
Message-ID<uruYr-8tS-23@gated-at.bofh.it>
In reply to#1734848
Hi Neil,

On Tue, Sep 19, 2017 at 2:05 PM, Neil Armstrong <narmstrong@baylibre.com> wrote:
> The Tronsmart Vega S96 is a TV box derived from Amlogic q200 reference design.
>
> Cc: support@tronsmart.com
> Signed-off-by: Oleg <balbes-150@yandex.ru>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
>  arch/arm64/boot/dts/amlogic/Makefile               |  1 +
>  arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dts | 39 ++++++++++++++++++++++
>  2 files changed, 40 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dts
>
> diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile
> index 7a9f48c..a6c4a06 100644
> --- a/arch/arm64/boot/dts/amlogic/Makefile
> +++ b/arch/arm64/boot/dts/amlogic/Makefile
> @@ -19,6 +19,7 @@ dtb-$(CONFIG_ARCH_MESON) += meson-gxm-nexbox-a1.dtb
>  dtb-$(CONFIG_ARCH_MESON) += meson-gxm-q200.dtb
>  dtb-$(CONFIG_ARCH_MESON) += meson-gxm-q201.dtb
>  dtb-$(CONFIG_ARCH_MESON) += meson-gxm-rbox-pro.dtb
> +dtb-$(CONFIG_ARCH_MESON) += meson-gxm-vega-s96.dtb
>
>  always         := $(dtb-y)
>  subdir-y       := $(dts-dirs)
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dts b/arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dts
> new file mode 100644
> index 0000000..ba74240
> --- /dev/null
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dts
> @@ -0,0 +1,39 @@
> +/*
> + * Copyright (c) 2017 BayLibre, SAS.
> + * Author: Neil Armstrong <narmstrong@baylibre.com>
> + * Copyright (c) 2017 Oleg <balbes-150@yandex.ru>
> + *
> + * SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> + */
> +
> +/dts-v1/;
> +
> +#include "meson-gxm.dtsi"
> +#include "meson-gx-p23x-q20x.dtsi"
> +
> +/ {
> +       compatible = "tronsmart,vega-s96", "amlogic,s912", "amlogic,meson-gxm";
> +       model = "Tronsmart Vega S96";
> +
> +};
> +
> +&ethmac {
> +       pinctrl-0 = <&eth_pins>;
> +       pinctrl-names = "default";
> +
> +       /* Select external PHY by default */
> +       phy-handle = <&external_phy>;
> +
> +       amlogic,tx-delay-ns = <2>;
> +
> +       /* External PHY is in RGMII */
> +       phy-mode = "rgmii";
> +};
> +
> +&external_mdio {
> +       external_phy: ethernet-phy@0 {
> +               compatible = "ethernet-phy-id001c.c916", "ethernet-phy-ieee802.3-c22";
some time ago I thought it was smart to add a compatible string with the PHY ID.
this was until I figured out that it should only be done if the PHY
reports an invalid ID: [0]
that's why most .dts files that I've touched skip the "compatible"
property and use a comment like "/* Realtek RTL8211F (0x001cc916) */"
instead

> +               reg = <0>;
> +               max-speed = <1000>;
> +       };
> +};
> --
> 1.9.1
>
>
> _______________________________________________
> linux-amlogic mailing list
> linux-amlogic@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-amlogic


Regards,
Martin


[0] https://github.com/torvalds/linux/commit/7630ea4bda18df2ee1c64dfdca1724a9cc32f920

[toc] | [prev] | [next] | [standalone]

#1735632 — Re: [PATCH 1/2] ARM64: dts: meson-gxm: Add Vega S96 board

FromNeil Armstrong <narmstrong@baylibre.com>
Date2017-09-20 10:40 +0200
SubjectRe: [PATCH 1/2] ARM64: dts: meson-gxm: Add Vega S96 board
Message-ID<urII2-xz-23@gated-at.bofh.it>
In reply to#1735137
On 09/19/2017 07:51 PM, Martin Blumenstingl wrote:
> Hi Neil,
> 
> On Tue, Sep 19, 2017 at 2:05 PM, Neil Armstrong <narmstrong@baylibre.com> wrote:
>> The Tronsmart Vega S96 is a TV box derived from Amlogic q200 reference design.
>>
>> Cc: support@tronsmart.com
>> Signed-off-by: Oleg <balbes-150@yandex.ru>
>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>> ---
>>  arch/arm64/boot/dts/amlogic/Makefile               |  1 +
>>  arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dts | 39 ++++++++++++++++++++++
>>  2 files changed, 40 insertions(+)
>>  create mode 100644 arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dts
>>
>> diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile
>> index 7a9f48c..a6c4a06 100644
>> --- a/arch/arm64/boot/dts/amlogic/Makefile
>> +++ b/arch/arm64/boot/dts/amlogic/Makefile
>> @@ -19,6 +19,7 @@ dtb-$(CONFIG_ARCH_MESON) += meson-gxm-nexbox-a1.dtb
>>  dtb-$(CONFIG_ARCH_MESON) += meson-gxm-q200.dtb
>>  dtb-$(CONFIG_ARCH_MESON) += meson-gxm-q201.dtb
>>  dtb-$(CONFIG_ARCH_MESON) += meson-gxm-rbox-pro.dtb
>> +dtb-$(CONFIG_ARCH_MESON) += meson-gxm-vega-s96.dtb
>>
>>  always         := $(dtb-y)
>>  subdir-y       := $(dts-dirs)
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dts b/arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dts
>> new file mode 100644
>> index 0000000..ba74240
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dts
>> @@ -0,0 +1,39 @@
>> +/*
>> + * Copyright (c) 2017 BayLibre, SAS.
>> + * Author: Neil Armstrong <narmstrong@baylibre.com>
>> + * Copyright (c) 2017 Oleg <balbes-150@yandex.ru>
>> + *
>> + * SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>> + */
>> +
>> +/dts-v1/;
>> +
>> +#include "meson-gxm.dtsi"
>> +#include "meson-gx-p23x-q20x.dtsi"
>> +
>> +/ {
>> +       compatible = "tronsmart,vega-s96", "amlogic,s912", "amlogic,meson-gxm";
>> +       model = "Tronsmart Vega S96";
>> +
>> +};
>> +
>> +&ethmac {
>> +       pinctrl-0 = <&eth_pins>;
>> +       pinctrl-names = "default";
>> +
>> +       /* Select external PHY by default */
>> +       phy-handle = <&external_phy>;
>> +
>> +       amlogic,tx-delay-ns = <2>;
>> +
>> +       /* External PHY is in RGMII */
>> +       phy-mode = "rgmii";
>> +};
>> +
>> +&external_mdio {
>> +       external_phy: ethernet-phy@0 {
>> +               compatible = "ethernet-phy-id001c.c916", "ethernet-phy-ieee802.3-c22";
> some time ago I thought it was smart to add a compatible string with the PHY ID.
> this was until I figured out that it should only be done if the PHY
> reports an invalid ID: [0]
> that's why most .dts files that I've touched skip the "compatible"
> property and use a comment like "/* Realtek RTL8211F (0x001cc916) */"
> instead

Done, thanks !

Neil

> 
>> +               reg = <0>;
>> +               max-speed = <1000>;
>> +       };
>> +};
>> --
>> 1.9.1
>>
>>
>> _______________________________________________
>> linux-amlogic mailing list
>> linux-amlogic@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-amlogic
> 
> 
> Regards,
> Martin
> 
> 
> [0] https://github.com/torvalds/linux/commit/7630ea4bda18df2ee1c64dfdca1724a9cc32f920
>

[toc] | [prev] | [next] | [standalone]

#1734993

FromJerome Brunet <jbrunet@baylibre.com>
Date2017-09-19 17:10 +0200
Message-ID<ursjT-74b-15@gated-at.bofh.it>
In reply to#1734847
On Tue, 2017-09-19 at 14:05 +0200, Neil Armstrong wrote:
> This patchset adds support for the Tronsmart Vega S96 TV Box based
> on the Q200 Amlogic Reference design.
> 
> Neil Armstrong (2):
>   ARM64: dts: meson-gxm: Add Vega S96 board
>   dt-bindings: arm: amlogic: Add Tronsmart Vega S96 binding
> 
>  Documentation/devicetree/bindings/arm/amlogic.txt  |  1 +
>  arch/arm64/boot/dts/amlogic/Makefile               |  1 +
>  arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dts | 39
> ++++++++++++++++++++++
>  3 files changed, 41 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dts
> 

Apart from the 2 comments on patch 1, Series looks good to me
With this fixed, feel free to add

Acked-by: Jerome Brunet <jbrunet@baylibre.com>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web