Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1735390 > unrolled thread
| Started by | Dmitry Torokhov <dmitry.torokhov@gmail.com> |
|---|---|
| First post | 2017-09-20 03:40 +0200 |
| Last post | 2017-09-20 08:40 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] HID: hidraw: fix power sequence when closing device Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-09-20 03:40 +0200
Re: [PATCH] HID: hidraw: fix power sequence when closing device Guenter Roeck <groeck@google.com> - 2017-09-20 03:50 +0200
Re: [PATCH] HID: hidraw: fix power sequence when closing device Benson Leung <bleung@google.com> - 2017-09-20 08:40 +0200
| From | Dmitry Torokhov <dmitry.torokhov@gmail.com> |
|---|---|
| Date | 2017-09-20 03:40 +0200 |
| Subject | [PATCH] HID: hidraw: fix power sequence when closing device |
| Message-ID | <urC9A-4zJ-11@gated-at.bofh.it> |
We should not try to bring HID device out of full power state before
calling hid_hw_close(), so that transport driver operates on powered up
device (making this inverse of the opening sequence).
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
drivers/hid/hidraw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/hidraw.c b/drivers/hid/hidraw.c
index ec530454e6f6..5fbe0f81ab2e 100644
--- a/drivers/hid/hidraw.c
+++ b/drivers/hid/hidraw.c
@@ -337,8 +337,8 @@ static void drop_ref(struct hidraw *hidraw, int exists_bit)
kfree(hidraw);
} else {
/* close device for last reader */
- hid_hw_power(hidraw->hid, PM_HINT_NORMAL);
hid_hw_close(hidraw->hid);
+ hid_hw_power(hidraw->hid, PM_HINT_NORMAL);
}
}
}
--
2.14.1.821.g8fa685d3b7-goog
--
Dmitry
[toc] | [next] | [standalone]
| From | Guenter Roeck <groeck@google.com> |
|---|---|
| Date | 2017-09-20 03:50 +0200 |
| Message-ID | <urCjf-4CT-7@gated-at.bofh.it> |
| In reply to | #1735390 |
On Tue, Sep 19, 2017 at 6:37 PM, Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
> We should not try to bring HID device out of full power state before
> calling hid_hw_close(), so that transport driver operates on powered up
> device (making this inverse of the opening sequence).
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
> ---
> drivers/hid/hidraw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/hidraw.c b/drivers/hid/hidraw.c
> index ec530454e6f6..5fbe0f81ab2e 100644
> --- a/drivers/hid/hidraw.c
> +++ b/drivers/hid/hidraw.c
> @@ -337,8 +337,8 @@ static void drop_ref(struct hidraw *hidraw, int exists_bit)
> kfree(hidraw);
> } else {
> /* close device for last reader */
> - hid_hw_power(hidraw->hid, PM_HINT_NORMAL);
> hid_hw_close(hidraw->hid);
> + hid_hw_power(hidraw->hid, PM_HINT_NORMAL);
> }
> }
> }
> --
> 2.14.1.821.g8fa685d3b7-goog
>
>
> --
> Dmitry
[toc] | [prev] | [next] | [standalone]
| From | Benson Leung <bleung@google.com> |
|---|---|
| Date | 2017-09-20 08:40 +0200 |
| Message-ID | <urGPV-7L3-31@gated-at.bofh.it> |
| In reply to | #1735390 |
[Multipart message — attachments visible in raw view] — view raw
Hi Dmitry, On Tue, Sep 19, 2017 at 06:37:46PM -0700, Dmitry Torokhov wrote: > We should not try to bring HID device out of full power state before > calling hid_hw_close(), so that transport driver operates on powered up > device (making this inverse of the opening sequence). > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Reviewed-by: Benson Leung <bleung@chromium.org> -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. bleung@google.com Chromium OS Project bleung@chromium.org
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web