Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1733057 > unrolled thread
| Started by | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| First post | 2017-09-15 21:50 +0200 |
| Last post | 2017-09-18 19:00 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] omap: hwmod: fix section mismatch warnings Arnd Bergmann <arnd@arndb.de> - 2017-09-15 21:50 +0200
Re: [PATCH] omap: hwmod: fix section mismatch warnings Tony Lindgren <tony@atomide.com> - 2017-09-18 19:00 +0200
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2017-09-15 21:50 +0200 |
| Subject | [PATCH] omap: hwmod: fix section mismatch warnings |
| Message-ID | <uq4MF-7rc-7@gated-at.bofh.it> |
Older compilers choose not to inline _setup_clkctrl_provider(),
leading to a harmless warning:
WARNING: vmlinux.o(.text+0x27b34): Section mismatch in reference from the function _setup_clkctrl_provider() to the function .init.text:memblock_virt_alloc_try_nid()
The function _setup_clkctrl_provider() references
the function __init memblock_virt_alloc_try_nid().
This is often because _setup_clkctrl_provider lacks a __init
annotation or the annotation of memblock_virt_alloc_try_nid is wrong.
This annotates it as __init as well, which lets the linker
see that it is actually correct.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
arch/arm/mach-omap2/omap_hwmod.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-omap2/omap_hwmod.c b/arch/arm/mach-omap2/omap_hwmod.c
index 2dbd63239c54..91ec0ca4822b 100644
--- a/arch/arm/mach-omap2/omap_hwmod.c
+++ b/arch/arm/mach-omap2/omap_hwmod.c
@@ -732,7 +732,7 @@ static int _match_clkdm(struct clockdomain *clkdm, void *user)
return 0;
}
-static int _setup_clkctrl_provider(struct device_node *np)
+static int __init _setup_clkctrl_provider(struct device_node *np)
{
const __be32 *addrp;
struct clkctrl_provider *provider;
@@ -761,7 +761,7 @@ static int _setup_clkctrl_provider(struct device_node *np)
return 0;
}
-static int _init_clkctrl_providers(void)
+static int __init _init_clkctrl_providers(void)
{
struct device_node *np;
int ret = 0;
--
2.9.0
[toc] | [next] | [standalone]
| From | Tony Lindgren <tony@atomide.com> |
|---|---|
| Date | 2017-09-18 19:00 +0200 |
| Message-ID | <ur7yO-mI-7@gated-at.bofh.it> |
| In reply to | #1733057 |
* Arnd Bergmann <arnd@arndb.de> [170915 12:46]: > Older compilers choose not to inline _setup_clkctrl_provider(), > leading to a harmless warning: > > WARNING: vmlinux.o(.text+0x27b34): Section mismatch in reference from the function _setup_clkctrl_provider() to the function .init.text:memblock_virt_alloc_try_nid() > The function _setup_clkctrl_provider() references > the function __init memblock_virt_alloc_try_nid(). > This is often because _setup_clkctrl_provider lacks a __init > annotation or the annotation of memblock_virt_alloc_try_nid is wrong. > > This annotates it as __init as well, which lets the linker > see that it is actually correct. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Acked-by: Tony Lindgren <tony@atomide.com>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web