Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1732333 > unrolled thread

Re: [PATCH 1/3] selftests/ftrace: multiple_kprobes: Also check for support

Started byShuah Khan <shuah@kernel.org>
First post2017-09-14 17:00 +0200
Last post2017-09-19 16:50 +0200
Articles 6 — 4 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 1/3] selftests/ftrace: multiple_kprobes: Also check for  support Shuah Khan <shuah@kernel.org> - 2017-09-14 17:00 +0200
    Re: [PATCH 1/3] selftests/ftrace: multiple_kprobes: Also check for  support Masami Hiramatsu <mhiramat@kernel.org> - 2017-09-14 17:20 +0200
      Re: [PATCH 1/3] selftests/ftrace: multiple_kprobes: Also check for  support Steven Rostedt <rostedt@goodmis.org> - 2017-09-15 21:20 +0200
      Re: [PATCH 1/3] selftests/ftrace: multiple_kprobes: Also check for  support Steven Rostedt <rostedt@goodmis.org> - 2017-09-18 17:20 +0200
        Re: [PATCH 1/3] selftests/ftrace: multiple_kprobes: Also check for  support Shuah Khan <shuahkh@osg.samsung.com> - 2017-09-18 17:30 +0200
          Re: [PATCH 1/3] selftests/ftrace: multiple_kprobes: Also check for  support Shuah Khan <shuah@kernel.org> - 2017-09-19 16:50 +0200

#1732333 — Re: [PATCH 1/3] selftests/ftrace: multiple_kprobes: Also check for support

FromShuah Khan <shuah@kernel.org>
Date2017-09-14 17:00 +0200
SubjectRe: [PATCH 1/3] selftests/ftrace: multiple_kprobes: Also check for support
Message-ID<upDMu-6ln-21@gated-at.bofh.it>
On 09/08/2017 06:01 AM, Thomas Meyer wrote:
> The multiple_kprobes test case fails to check for KPROBE_EVENT support.
> Add the check to prevent a false test result.
> 
> Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
> ---
>  tools/testing/selftests/ftrace/test.d/kprobe/multiple_kprobes.tc | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/multiple_kprobes.tc b/tools/testing/selftests/ftrace/test.d/kprobe/multiple_kprobes.tc
> index 2a1cb9908746..a4fd4c851a5b 100644
> --- a/tools/testing/selftests/ftrace/test.d/kprobe/multiple_kprobes.tc
> +++ b/tools/testing/selftests/ftrace/test.d/kprobe/multiple_kprobes.tc
> @@ -1,6 +1,8 @@
>  #!/bin/sh
>  # description: Register/unregister many kprobe events
>  
> +[ -f kprobe_events ] || exit_unsupported # this is configurable
> +
>  # ftrace fentry skip size depends on the machine architecture.
>  # Currently HAVE_KPROBES_ON_FTRACE defined on x86 and powerpc64le
>  case `uname -m` in
> 

Hi Steve/Masami,

This patch looks good to me. Adds a check similar to the one one in
tools/testing/selftests/ftrace/test.d/kprobe/functions

If you don't have objections, I will get this into 4.14-rc2 or rc3

thanks,
-- Shuah

[toc] | [next] | [standalone]

#1732349

FromMasami Hiramatsu <mhiramat@kernel.org>
Date2017-09-14 17:20 +0200
Message-ID<upE5Q-6HF-17@gated-at.bofh.it>
In reply to#1732333
On Thu, 14 Sep 2017 08:58:20 -0600
Shuah Khan <shuah@kernel.org> wrote:

> On 09/08/2017 06:01 AM, Thomas Meyer wrote:
> > The multiple_kprobes test case fails to check for KPROBE_EVENT support.
> > Add the check to prevent a false test result.
> > 
> > Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
> > ---
> >  tools/testing/selftests/ftrace/test.d/kprobe/multiple_kprobes.tc | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/multiple_kprobes.tc b/tools/testing/selftests/ftrace/test.d/kprobe/multiple_kprobes.tc
> > index 2a1cb9908746..a4fd4c851a5b 100644
> > --- a/tools/testing/selftests/ftrace/test.d/kprobe/multiple_kprobes.tc
> > +++ b/tools/testing/selftests/ftrace/test.d/kprobe/multiple_kprobes.tc
> > @@ -1,6 +1,8 @@
> >  #!/bin/sh
> >  # description: Register/unregister many kprobe events
> >  
> > +[ -f kprobe_events ] || exit_unsupported # this is configurable
> > +
> >  # ftrace fentry skip size depends on the machine architecture.
> >  # Currently HAVE_KPROBES_ON_FTRACE defined on x86 and powerpc64le
> >  case `uname -m` in
> > 
> 
> Hi Steve/Masami,
> 
> This patch looks good to me. Adds a check similar to the one one in
> tools/testing/selftests/ftrace/test.d/kprobe/functions

Yes, this looks good to me too :)

Acked-by: Masami Hiramatsu <mhiramat@kernel.org>

Thanks!

> 
> If you don't have objections, I will get this into 4.14-rc2 or rc3
> 
> thanks,
> -- Shuah
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


-- 
Masami Hiramatsu <mhiramat@kernel.org>

[toc] | [prev] | [next] | [standalone]

#1733037

FromSteven Rostedt <rostedt@goodmis.org>
Date2017-09-15 21:20 +0200
Message-ID<uq4jE-7gb-11@gated-at.bofh.it>
In reply to#1732349
On Thu, 14 Sep 2017 08:15:19 -0700
Masami Hiramatsu <mhiramat@kernel.org> wrote:

> Yes, this looks good to me too :)

Agreed.

> 
> Acked-by: Masami Hiramatsu <mhiramat@kernel.org>

Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

-- Steve

[toc] | [prev] | [next] | [standalone]

#1734222

FromSteven Rostedt <rostedt@goodmis.org>
Date2017-09-18 17:20 +0200
Message-ID<ur603-7Z6-47@gated-at.bofh.it>
In reply to#1732349
On Thu, 14 Sep 2017 08:15:19 -0700
Masami Hiramatsu <mhiramat@kernel.org> wrote:


> > Hi Steve/Masami,
> > 
> > This patch looks good to me. Adds a check similar to the one one in
> > tools/testing/selftests/ftrace/test.d/kprobe/functions  
> 
> Yes, this looks good to me too :)
> 
> Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
> 

Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

-- Steve

[toc] | [prev] | [next] | [standalone]

#1734226

FromShuah Khan <shuahkh@osg.samsung.com>
Date2017-09-18 17:30 +0200
Message-ID<ur69I-82d-15@gated-at.bofh.it>
In reply to#1734222
On 09/18/2017 09:18 AM, Steven Rostedt wrote:
> On Thu, 14 Sep 2017 08:15:19 -0700
> Masami Hiramatsu <mhiramat@kernel.org> wrote:
> 
> 
>>> Hi Steve/Masami,
>>>
>>> This patch looks good to me. Adds a check similar to the one one in
>>> tools/testing/selftests/ftrace/test.d/kprobe/functions  
>>
>> Yes, this looks good to me too :)
>>
>> Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
>>
> 
> Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> 
> -- Steve
> 

Thanks Steve and Masami,

I will get this into rc2

thanks,
-- Shuah

[toc] | [prev] | [next] | [standalone]

#1734971

FromShuah Khan <shuah@kernel.org>
Date2017-09-19 16:50 +0200
Message-ID<urs0y-6GG-15@gated-at.bofh.it>
In reply to#1734226
On 09/18/2017 09:19 AM, Shuah Khan wrote:
> On 09/18/2017 09:18 AM, Steven Rostedt wrote:
>> On Thu, 14 Sep 2017 08:15:19 -0700
>> Masami Hiramatsu <mhiramat@kernel.org> wrote:
>>
>>
>>>> Hi Steve/Masami,
>>>>
>>>> This patch looks good to me. Adds a check similar to the one one in
>>>> tools/testing/selftests/ftrace/test.d/kprobe/functions  
>>>
>>> Yes, this looks good to me too :)
>>>
>>> Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
>>>
>>
>> Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
>>
>> -- Steve
>>
> 
> Thanks Steve and Masami,
> 
> I will get this into rc2
> 

Applied to linux-kselftest fixes 4.14-rc2

thanks,
-- Shuah

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web