Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1734069 > unrolled thread

[PATCH] cpupowerutils: bench - Fix cpu online check

Started byAbhishek Goel <huntbag@linux.vnet.ibm.com>
First post2017-09-18 13:50 +0200
Last post2017-09-18 13:50 +0200
Articles 1 — 1 participant

Back to article view | Back to linux.kernel


Contents

  [PATCH] cpupowerutils: bench - Fix cpu online check Abhishek Goel <huntbag@linux.vnet.ibm.com> - 2017-09-18 13:50 +0200

#1734069 — [PATCH] cpupowerutils: bench - Fix cpu online check

FromAbhishek Goel <huntbag@linux.vnet.ibm.com>
Date2017-09-18 13:50 +0200
Subject[PATCH] cpupowerutils: bench - Fix cpu online check
Message-ID<ur2IO-5LK-7@gated-at.bofh.it>
cpupower_is_cpu_online returns 1 when cpu is online. But in function
set_cpufreq_governor, it was incorrectly checking for 0 in case cpu is
online.

Signed-off-by: Abhishek Goel <huntbag@linux.vnet.ibm.com>
---
 tools/power/cpupower/bench/system.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/power/cpupower/bench/system.c b/tools/power/cpupower/bench/system.c
index c25a74a..2bb3eef 100644
--- a/tools/power/cpupower/bench/system.c
+++ b/tools/power/cpupower/bench/system.c
@@ -61,7 +61,7 @@ int set_cpufreq_governor(char *governor, unsigned int cpu)
 
 	dprintf("set %s as cpufreq governor\n", governor);
 
-	if (cpupower_is_cpu_online(cpu) != 0) {
+	if (cpupower_is_cpu_online(cpu) != 1) {
 		perror("cpufreq_cpu_exists");
 		fprintf(stderr, "error: cpu %u does not exist\n", cpu);
 		return -1;
-- 
2.9.3

[toc] | [standalone]


Back to top | Article view | linux.kernel


csiph-web