Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1733475 > unrolled thread
| Started by | Masahiro Yamada <yamada.masahiro@socionext.com> |
|---|---|
| First post | 2017-09-17 17:10 +0200 |
| Last post | 2017-09-18 04:10 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] checkpatch: do not check missing blank line before builtin_*_driver Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-09-17 17:10 +0200
Re: [PATCH] checkpatch: do not check missing blank line before builtin_*_driver Joe Perches <joe@perches.com> - 2017-09-17 22:50 +0200
Re: [PATCH] checkpatch: do not check missing blank line before builtin_*_driver Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-09-18 04:10 +0200
| From | Masahiro Yamada <yamada.masahiro@socionext.com> |
|---|---|
| Date | 2017-09-17 17:10 +0200 |
| Subject | [PATCH] checkpatch: do not check missing blank line before builtin_*_driver |
| Message-ID | <uqJmO-19W-21@gated-at.bofh.it> |
checkpatch.pl does not check missing blank line before module_*_driver.
I want it to behave likewise for builtin_*_driver.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
scripts/checkpatch.pl | 1 +
1 file changed, 1 insertion(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index dd2c262aebbf..cec896306619 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -3103,6 +3103,7 @@ sub process {
$line =~ /^\+[a-z_]*init/ ||
$line =~ /^\+\s*(?:static\s+)?[A-Z_]*ATTR/ ||
$line =~ /^\+\s*DECLARE/ ||
+ $line =~ /^\+\s*builtin_/ ||
$line =~ /^\+\s*__setup/)) {
if (CHK("LINE_SPACING",
"Please use a blank line after function/struct/union/enum declarations\n" . $hereprev) &&
--
2.7.4
[toc] | [next] | [standalone]
| From | Joe Perches <joe@perches.com> |
|---|---|
| Date | 2017-09-17 22:50 +0200 |
| Subject | Re: [PATCH] checkpatch: do not check missing blank line before builtin_*_driver |
| Message-ID | <uqOFP-4FV-1@gated-at.bofh.it> |
| In reply to | #1733475 |
On Sun, 2017-09-17 at 23:59 +0900, Masahiro Yamada wrote:
> checkpatch.pl does not check missing blank line before module_*_driver.
> I want it to behave likewise for builtin_*_driver.
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index dd2c262aebbf..cec896306619 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -3103,6 +3103,7 @@ sub process {
> $line =~ /^\+[a-z_]*init/ ||
> $line =~ /^\+\s*(?:static\s+)?[A-Z_]*ATTR/ ||
> $line =~ /^\+\s*DECLARE/ ||
> + $line =~ /^\+\s*builtin_/ ||
I believe
$line =~ /^\+\s*builtin_[\w_]*driver/ ||
would be better
[toc] | [prev] | [next] | [standalone]
| From | Masahiro Yamada <yamada.masahiro@socionext.com> |
|---|---|
| Date | 2017-09-18 04:10 +0200 |
| Message-ID | <uqTFw-7Yr-5@gated-at.bofh.it> |
| In reply to | #1733535 |
Hi Joe,
2017-09-18 5:44 GMT+09:00 Joe Perches <joe@perches.com>:
> On Sun, 2017-09-17 at 23:59 +0900, Masahiro Yamada wrote:
>> checkpatch.pl does not check missing blank line before module_*_driver.
>> I want it to behave likewise for builtin_*_driver.
> []
>> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
>> index dd2c262aebbf..cec896306619 100755
>> --- a/scripts/checkpatch.pl
>> +++ b/scripts/checkpatch.pl
>> @@ -3103,6 +3103,7 @@ sub process {
>> $line =~ /^\+[a-z_]*init/ ||
>> $line =~ /^\+\s*(?:static\s+)?[A-Z_]*ATTR/ ||
>> $line =~ /^\+\s*DECLARE/ ||
>> + $line =~ /^\+\s*builtin_/ ||
>
> I believe
>
> $line =~ /^\+\s*builtin_[\w_]*driver/ ||
>
> would be better
Thanks for your advice.
I've sent v2.
--
Best Regards
Masahiro Yamada
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web