Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1732153 > unrolled thread
| Started by | Srishti Sharma <srishtishar@gmail.com> |
|---|---|
| First post | 2017-09-14 12:20 +0200 |
| Last post | 2017-09-14 12:20 +0200 |
| Articles | 1 — 1 participant |
Back to article view | Back to linux.kernel
[PATCH] Staging: media: atomisp: Use kcalloc instead of kzalloc Srishti Sharma <srishtishar@gmail.com> - 2017-09-14 12:20 +0200
| From | Srishti Sharma <srishtishar@gmail.com> |
|---|---|
| Date | 2017-09-14 12:20 +0200 |
| Subject | [PATCH] Staging: media: atomisp: Use kcalloc instead of kzalloc |
| Message-ID | <upzpw-3Hw-3@gated-at.bofh.it> |
Use kcalloc instead of kzalloc to check for an overflow before multiplication. Done using the following semantic patch by coccinelle. http://coccinelle.lip6.fr/rules/kzalloc.cocci Signed-off-by: Srishti Sharma <srishtishar@gmail.com> --- drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_firmware.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_firmware.c b/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_firmware.c index 6358216..2f4b71a 100644 --- a/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_firmware.c +++ b/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_firmware.c @@ -235,7 +235,9 @@ sh_css_load_firmware(const char *fw_data, sh_css_blob_info = NULL; } - fw_minibuffer = kzalloc(sh_css_num_binaries * sizeof(struct fw_param), GFP_KERNEL); + fw_minibuffer = kcalloc(sh_css_num_binaries, sizeof(struct fw_param), + GFP_KERNEL); + if (fw_minibuffer == NULL) return IA_CSS_ERR_CANNOT_ALLOCATE_MEMORY; -- 2.7.4
Back to top | Article view | linux.kernel
csiph-web