Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1731739 > unrolled thread
| Started by | Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> |
|---|---|
| First post | 2017-09-13 19:30 +0200 |
| Last post | 2017-09-14 01:10 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 1/3] tpm: fix type of a local variable in tpm2_get_cc_attrs_tbl() Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-09-13 19:30 +0200
Re: [PATCH 1/3] tpm: fix type of a local variable in tpm2_get_cc_attrs_tbl() Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2017-09-13 20:20 +0200
Re: [PATCH 1/3] tpm: fix type of a local variable in tpm2_get_cc_attrs_tbl() Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-09-14 01:10 +0200
| From | Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> |
|---|---|
| Date | 2017-09-13 19:30 +0200 |
| Subject | [PATCH 1/3] tpm: fix type of a local variable in tpm2_get_cc_attrs_tbl() |
| Message-ID | <upjE5-1RR-15@gated-at.bofh.it> |
The local variable 'attrs' should have the type __be32 instead of u32.
Fixes: 58472f5cd4f6 ("tpm: validate TPM 2.0 commands")
Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
---
drivers/char/tpm/tpm2-cmd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/char/tpm/tpm2-cmd.c b/drivers/char/tpm/tpm2-cmd.c
index 70ee32816c48..f40d20671a78 100644
--- a/drivers/char/tpm/tpm2-cmd.c
+++ b/drivers/char/tpm/tpm2-cmd.c
@@ -980,7 +980,7 @@ static int tpm2_get_cc_attrs_tbl(struct tpm_chip *chip)
{
struct tpm_buf buf;
u32 nr_commands;
- u32 *attrs;
+ __be32 *attrs;
u32 cc;
int i;
int rc;
@@ -1020,7 +1020,7 @@ static int tpm2_get_cc_attrs_tbl(struct tpm_chip *chip)
chip->nr_commands = nr_commands;
- attrs = (u32 *)&buf.data[TPM_HEADER_SIZE + 9];
+ attrs = (__be32 *)&buf.data[TPM_HEADER_SIZE + 9];
for (i = 0; i < nr_commands; i++, attrs++) {
chip->cc_attrs_tbl[i] = be32_to_cpup(attrs);
cc = chip->cc_attrs_tbl[i] & 0xFFFF;
--
2.14.1
[toc] | [next] | [standalone]
| From | Jason Gunthorpe <jgunthorpe@obsidianresearch.com> |
|---|---|
| Date | 2017-09-13 20:20 +0200 |
| Subject | Re: [PATCH 1/3] tpm: fix type of a local variable in tpm2_get_cc_attrs_tbl() |
| Message-ID | <upkqu-2qd-11@gated-at.bofh.it> |
| In reply to | #1731739 |
On Wed, Sep 13, 2017 at 10:26:20AM -0700, Jarkko Sakkinen wrote:
> The local variable 'attrs' should have the type __be32 instead of u32.
>
> Fixes: 58472f5cd4f6 ("tpm: validate TPM 2.0 commands")
> Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
All 3 look good to me:
Reviewed-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Jason
[toc] | [prev] | [next] | [standalone]
| From | Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> |
|---|---|
| Date | 2017-09-14 01:10 +0200 |
| Subject | Re: [PATCH 1/3] tpm: fix type of a local variable in tpm2_get_cc_attrs_tbl() |
| Message-ID | <upoX7-5ky-11@gated-at.bofh.it> |
| In reply to | #1731767 |
On Wed, Sep 13, 2017 at 12:14:21PM -0600, Jason Gunthorpe wrote:
> On Wed, Sep 13, 2017 at 10:26:20AM -0700, Jarkko Sakkinen wrote:
> > The local variable 'attrs' should have the type __be32 instead of u32.
> >
> > Fixes: 58472f5cd4f6 ("tpm: validate TPM 2.0 commands")
> > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
>
> All 3 look good to me:
>
> Reviewed-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
>
> Jason
Thanks!
/Jarkko
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web