Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1731531 > unrolled thread

[PATCH] crypto: talitos - fix sha224

Started byChristophe Leroy <christophe.leroy@c-s.fr>
First post2017-09-13 12:50 +0200
Last post2017-09-21 10:10 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] crypto: talitos - fix sha224 Christophe Leroy <christophe.leroy@c-s.fr> - 2017-09-13 12:50 +0200
    Re: [PATCH] crypto: talitos - fix sha224 Herbert Xu <herbert@gondor.apana.org.au> - 2017-09-21 10:10 +0200

#1731531 — [PATCH] crypto: talitos - fix sha224

FromChristophe Leroy <christophe.leroy@c-s.fr>
Date2017-09-13 12:50 +0200
Subject[PATCH] crypto: talitos - fix sha224
Message-ID<updp0-6fY-11@gated-at.bofh.it>
Kernel crypto tests report the following error at startup

[    2.752626] alg: hash: Test 4 failed for sha224-talitos
[    2.757907] 00000000: 30 e2 86 e2 e7 8a dd 0d d7 eb 9f d5 83 fe f1 b0
00000010: 2d 5a 6c a5 f9 55 ea fd 0e 72 05 22

This patch fixes it

Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
---
 drivers/crypto/talitos.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/crypto/talitos.c b/drivers/crypto/talitos.c
index d47b3eb1f0..e2d323fa24 100644
--- a/drivers/crypto/talitos.c
+++ b/drivers/crypto/talitos.c
@@ -1756,9 +1756,9 @@ static int common_nonsnoop_hash(struct talitos_edesc *edesc,
 		req_ctx->swinit = 0;
 	} else {
 		desc->ptr[1] = zero_entry;
-		/* Indicate next op is not the first. */
-		req_ctx->first = 0;
 	}
+	/* Indicate next op is not the first. */
+	req_ctx->first = 0;
 
 	/* HMAC key */
 	if (ctx->keylen)
-- 
2.13.3

[toc] | [next] | [standalone]


#1736445

FromHerbert Xu <herbert@gondor.apana.org.au>
Date2017-09-21 10:10 +0200
Message-ID<us4Iy-6IJ-17@gated-at.bofh.it>
In reply to#1731531
On Wed, Sep 13, 2017 at 12:44:51PM +0200, Christophe Leroy wrote:
> Kernel crypto tests report the following error at startup
> 
> [    2.752626] alg: hash: Test 4 failed for sha224-talitos
> [    2.757907] 00000000: 30 e2 86 e2 e7 8a dd 0d d7 eb 9f d5 83 fe f1 b0
> 00000010: 2d 5a 6c a5 f9 55 ea fd 0e 72 05 22
> 
> This patch fixes it
> 
> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web