Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1732892 > unrolled thread
| Started by | Vitaly Kuznetsov <vkuznets@redhat.com> |
|---|---|
| First post | 2017-09-15 15:50 +0200 |
| Last post | 2017-09-15 15:50 +0200 |
| Articles | 1 — 1 participant |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH 1/1] Drivers: hv: vmbus: Fix rescind handling issues Vitaly Kuznetsov <vkuznets@redhat.com> - 2017-09-15 15:50 +0200
| From | Vitaly Kuznetsov <vkuznets@redhat.com> |
|---|---|
| Date | 2017-09-15 15:50 +0200 |
| Subject | Re: [PATCH 1/1] Drivers: hv: vmbus: Fix rescind handling issues |
| Message-ID | <upZai-3xt-7@gated-at.bofh.it> |
Stephen Hemminger <stephen@networkplumber.org> writes:
> On Fri, 11 Aug 2017 10:03:59 -0700
> kys@exchange.microsoft.com wrote:
>
>> From: K. Y. Srinivasan <kys@microsoft.com>
>>
>> This patch handles the following issues that were observed when we are
>> handling racing channel offer message and rescind message for the same
>> offer:
>>
>> 1. Since the host does not respond to messages on a rescinded channel,
>> in the current code, we could be indefinitely blocked on the vmbus_open() call.
>>
>> 2. When a rescinded channel is being closed, if there is a pending interrupt on the
>> channel, we could end up freeing the channel that the interrupt handler would run on.
>>
>> Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
>> Reviewed-by: Dexuan Cui <decui@microsoft.com>
>> Tested-by: Dexuan Cui <decui@microsoft.com>
>
> This patch breaks re-initialization of the network device on MTU changes.
>
> Doing:
> # ip li set dev eth1 mtu 9000
>
> will hang in rndis_filter_add waiting for subchannel notification.
> This is likely because when the vmbus device is reopened the sub channels
> are not correctly created. Not sure what is wrong with the patch, but my
> suspicion is that the close/rescind events are no longer being sent to the
> host.
I'm seeing the same issue, reverting the offending
commit 6f3d791f300618caf82a2be0c27456edd76d5164
Author: K. Y. Srinivasan <kys@microsoft.com>
Date: Fri Aug 11 10:03:59 2017 -0700
Drivers: hv: vmbus: Fix rescind handling issues
which made it upstream helps. Did you guys do some investigation here?
In case not I can take a look next week.
--
Vitaly
Back to top | Article view | linux.kernel
csiph-web