Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1732738 > unrolled thread

Re: [PATCH] iio: dac: ds4422/ds4424 dac driver

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] iio: dac: ds4422/ds4424 dac driver Linus Walleij <linus.walleij@linaro.org> - 2017-09-15 09:20 +0200

#1732738 — Re: [PATCH] iio: dac: ds4422/ds4424 dac driver

On Thu, Sep 14, 2017 at 10:24 PM, Ismail Kose
<Ismail.Kose@maximintegrated.com> wrote:

> +struct ds4424_pdata {
> +       const char *vcc_supply_name;

Should not be needed at all, get the supply directly from the device tree.

> +       uint32_t rfs_res[DS4424_MAX_DAC_CHANNELS];
> +       struct iio_map *dac_iio_map;
> +};

Drop this entire platform data file and move all these fields
you still need into struct ds4424_data.

If you have legacy kernels still using platform data, that's too
bad, we will not maintain them upstream and not merge new
board files using platform data normally, use device tree or ACPI
DSTD only please.

Yours,
Linus Walleij

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web