Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1732049 > unrolled thread
| Started by | Nicolin Chen <nicoleotsuka@gmail.com> |
|---|---|
| First post | 2017-09-14 07:40 +0200 |
| Last post | 2017-09-14 20:50 +0200 |
| Articles | 2 — 1 participant |
Back to article view | Back to linux.kernel
[PATCH] dmaengine: imx-sdma: Correct addr widths Nicolin Chen <nicoleotsuka@gmail.com> - 2017-09-14 07:40 +0200
Re: [PATCH] dmaengine: imx-sdma: Correct addr widths Nicolin Chen <nicoleotsuka@gmail.com> - 2017-09-14 20:50 +0200
| From | Nicolin Chen <nicoleotsuka@gmail.com> |
|---|---|
| Date | 2017-09-14 07:40 +0200 |
| Subject | [PATCH] dmaengine: imx-sdma: Correct addr widths |
| Message-ID | <upv2y-UJ-7@gated-at.bofh.it> |
The driver also supports 2_BYTES and 1_BYTE in sdma_prep_slave_sg(). So this patch just adds them to the lists. Signed-off-by: Nicolin Chen <nicoleotsuka@gmail.com> --- drivers/dma/imx-sdma.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index a67ec1b..2be8d0d 100644 --- a/drivers/dma/imx-sdma.c +++ b/drivers/dma/imx-sdma.c @@ -178,6 +178,10 @@ #define SDMA_WATERMARK_LEVEL_HWE BIT(29) #define SDMA_WATERMARK_LEVEL_CONT BIT(31) +#define SDMA_DMA_BUSWIDTHS (BIT(DMA_SLAVE_BUSWIDTH_1_BYTE) | \ + BIT(DMA_SLAVE_BUSWIDTH_2_BYTES) | \ + BIT(DMA_SLAVE_BUSWIDTH_4_BYTES)) + /* * Mode/Count of data node descriptors - IPCv2 */ @@ -1851,8 +1855,8 @@ static int sdma_probe(struct platform_device *pdev) sdma->dma_device.device_prep_dma_cyclic = sdma_prep_dma_cyclic; sdma->dma_device.device_config = sdma_config; sdma->dma_device.device_terminate_all = sdma_disable_channel_with_delay; - sdma->dma_device.src_addr_widths = BIT(DMA_SLAVE_BUSWIDTH_4_BYTES); - sdma->dma_device.dst_addr_widths = BIT(DMA_SLAVE_BUSWIDTH_4_BYTES); + sdma->dma_device.src_addr_widths = SDMA_DMA_BUSWIDTHS; + sdma->dma_device.dst_addr_widths = SDMA_DMA_BUSWIDTHS; sdma->dma_device.directions = BIT(DMA_DEV_TO_MEM) | BIT(DMA_MEM_TO_DEV); sdma->dma_device.residue_granularity = DMA_RESIDUE_GRANULARITY_SEGMENT; sdma->dma_device.device_issue_pending = sdma_issue_pending; -- 2.1.4
[toc] | [next] | [standalone]
| From | Nicolin Chen <nicoleotsuka@gmail.com> |
|---|---|
| Date | 2017-09-14 20:50 +0200 |
| Message-ID | <upHn3-e8-3@gated-at.bofh.it> |
| In reply to | #1732049 |
On Wed, Sep 13, 2017 at 10:39:20PM -0700, Nicolin Chen wrote: > The driver also supports 2_BYTES and 1_BYTE in sdma_prep_slave_sg(). > So this patch just adds them to the lists. > > Signed-off-by: Nicolin Chen <nicoleotsuka@gmail.com> Please ignore this one as I just found the "directions" is also wrong. Sending a v2.... Thanks Nicolin
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web