Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1732242 > unrolled thread
| Started by | Alexander Syring <alex@asyring.de> |
|---|---|
| First post | 2017-09-14 14:20 +0200 |
| Last post | 2017-09-15 11:50 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] clk: sunxi-ng: Fix missing CLK_SET_RATE_PARENT in ccu-sun4i-a10.c Alexander Syring <alex@asyring.de> - 2017-09-14 14:20 +0200
Re: [PATCH] clk: sunxi-ng: Fix missing CLK_SET_RATE_PARENT in ccu-sun4i-a10.c Chen-Yu Tsai <wens@csie.org> - 2017-09-14 14:20 +0200
Re: [PATCH] clk: sunxi-ng: Fix missing CLK_SET_RATE_PARENT in ccu-sun4i-a10.c Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-09-15 11:50 +0200
| From | Alexander Syring <alex@asyring.de> |
|---|---|
| Date | 2017-09-14 14:20 +0200 |
| Subject | [PATCH] clk: sunxi-ng: Fix missing CLK_SET_RATE_PARENT in ccu-sun4i-a10.c |
| Message-ID | <upBhE-4VV-5@gated-at.bofh.it> |
When using cpufreq-dt with default govenor other than "performance"
system freezes while booting.
Adding CLK_SET_RATE_PARENT | CLK_IS_CRITICAL to clk_cpu fixes the
problem.
Tested on Cubietruck (A20).
Fixes: c84f5683f6E ("clk: sunxi-ng: Add sun4i/sun7i CCU driver")
Reported-by: Alexander Syring <alex@asyring.de>
Signed-off-by: Alexander Syring <alex@asyring.de>
---
drivers/clk/sunxi-ng/ccu-sun4i-a10.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/sunxi-ng/ccu-sun4i-a10.c b/drivers/clk/sunxi-ng/ccu-sun4i-a10.c
index 286b0049b7b6..a48fde191c0a 100644
--- a/drivers/clk/sunxi-ng/ccu-sun4i-a10.c
+++ b/drivers/clk/sunxi-ng/ccu-sun4i-a10.c
@@ -223,7 +223,7 @@ static struct ccu_mux cpu_clk = {
.hw.init = CLK_HW_INIT_PARENTS("cpu",
cpu_parents,
&ccu_mux_ops,
- CLK_IS_CRITICAL),
+ CLK_SET_RATE_PARENT | CLK_IS_CRITICAL),
}
};
--
2.11.0
[toc] | [next] | [standalone]
| From | Chen-Yu Tsai <wens@csie.org> |
|---|---|
| Date | 2017-09-14 14:20 +0200 |
| Message-ID | <upBhE-4VV-21@gated-at.bofh.it> |
| In reply to | #1732242 |
On Thu, Sep 14, 2017 at 8:05 PM, Alexander Syring <alex@asyring.de> wrote:
> When using cpufreq-dt with default govenor other than "performance"
> system freezes while booting.
> Adding CLK_SET_RATE_PARENT | CLK_IS_CRITICAL to clk_cpu fixes the
> problem.
>
> Tested on Cubietruck (A20).
>
> Fixes: c84f5683f6E ("clk: sunxi-ng: Add sun4i/sun7i CCU driver")
>
> Reported-by: Alexander Syring <alex@asyring.de>
You typically don't need this if you yourself are the reporter.
> Signed-off-by: Alexander Syring <alex@asyring.de>
Acked-by: Chen-Yu Tsai <wens@csie.org>
> ---
> drivers/clk/sunxi-ng/ccu-sun4i-a10.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/sunxi-ng/ccu-sun4i-a10.c b/drivers/clk/sunxi-ng/ccu-sun4i-a10.c
> index 286b0049b7b6..a48fde191c0a 100644
> --- a/drivers/clk/sunxi-ng/ccu-sun4i-a10.c
> +++ b/drivers/clk/sunxi-ng/ccu-sun4i-a10.c
> @@ -223,7 +223,7 @@ static struct ccu_mux cpu_clk = {
> .hw.init = CLK_HW_INIT_PARENTS("cpu",
> cpu_parents,
> &ccu_mux_ops,
> - CLK_IS_CRITICAL),
> + CLK_SET_RATE_PARENT | CLK_IS_CRITICAL),
> }
> };
>
> --
> 2.11.0
>
[toc] | [prev] | [next] | [standalone]
| From | Maxime Ripard <maxime.ripard@free-electrons.com> |
|---|---|
| Date | 2017-09-15 11:50 +0200 |
| Subject | Re: [PATCH] clk: sunxi-ng: Fix missing CLK_SET_RATE_PARENT in ccu-sun4i-a10.c |
| Message-ID | <upVq1-ZU-7@gated-at.bofh.it> |
| In reply to | #1732244 |
[Multipart message — attachments visible in raw view] — view raw
On Thu, Sep 14, 2017 at 08:14:10PM +0800, Chen-Yu Tsai wrote:
> On Thu, Sep 14, 2017 at 8:05 PM, Alexander Syring <alex@asyring.de> wrote:
> > When using cpufreq-dt with default govenor other than "performance"
> > system freezes while booting.
> > Adding CLK_SET_RATE_PARENT | CLK_IS_CRITICAL to clk_cpu fixes the
> > problem.
> >
> > Tested on Cubietruck (A20).
> >
> > Fixes: c84f5683f6E ("clk: sunxi-ng: Add sun4i/sun7i CCU driver")
> >
> > Reported-by: Alexander Syring <alex@asyring.de>
>
> You typically don't need this if you yourself are the reporter.
Queued for 4.15.
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web