Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1732237 > unrolled thread
| Started by | Miles Chen <miles.chen@mediatek.com> |
|---|---|
| First post | 2017-09-14 14:00 +0200 |
| Last post | 2017-09-15 08:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH v2] checkpatch: support function pointers for unnamed function definition arguments Miles Chen <miles.chen@mediatek.com> - 2017-09-14 14:00 +0200
Re: [PATCH v2] checkpatch: support function pointers for unnamed function definition arguments Joe Perches <joe@perches.com> - 2017-09-15 08:10 +0200
| From | Miles Chen <miles.chen@mediatek.com> |
|---|---|
| Date | 2017-09-14 14:00 +0200 |
| Subject | [PATCH v2] checkpatch: support function pointers for unnamed function definition arguments |
| Message-ID | <upAYi-4y5-9@gated-at.bofh.it> |
Current unnamed function definition argument does not include function
pointer cases and it reports something like:
WARNING: function definition argument 'void' should also have an identifier name
+unsigned int (*dummy)(void);
Support function pointers for unnamed function arguments
Signed-off-by: Miles Chen <miles.chen@mediatek.com>
---
scripts/checkpatch.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index dd2c262..03eb255 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -5957,7 +5957,7 @@ sub process {
# check for function declarations that have arguments without identifier names
if (defined $stat &&
- $stat =~ /^.\s*(?:extern\s+)?$Type\s*$Ident\s*\(\s*([^{]+)\s*\)\s*;/s &&
+ $stat =~ /^.\s*(?:extern\s+)?$Type\s*(?:$Ident|\(\s*\*\s*$Ident\s*\))\s*\(\s*([^{]+)\s*\)\s*;/s &&
$1 ne "void") {
my $args = trim($1);
while ($args =~ m/\s*($Type\s*(?:$Ident|\(\s*\*\s*$Ident?\s*\)\s*$balanced_parens)?)/g) {
--
1.9.1
[toc] | [next] | [standalone]
| From | Joe Perches <joe@perches.com> |
|---|---|
| Date | 2017-09-15 08:10 +0200 |
| Subject | Re: [PATCH v2] checkpatch: support function pointers for unnamed function definition arguments |
| Message-ID | <upRZ7-7j0-7@gated-at.bofh.it> |
| In reply to | #1732237 |
On Thu, 2017-09-14 at 19:52 +0800, Miles Chen wrote:
> Current unnamed function definition argument does not include function
> pointer cases and it reports something like:
>
> WARNING: function definition argument 'void' should also have an identifier name
> +unsigned int (*dummy)(void);
>
> Support function pointers for unnamed function arguments
>
> Signed-off-by: Miles Chen <miles.chen@mediatek.com>
Acked-by: Joe Perches <joe@perches.com>
> ---
> scripts/checkpatch.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index dd2c262..03eb255 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -5957,7 +5957,7 @@ sub process {
>
> # check for function declarations that have arguments without identifier names
> if (defined $stat &&
> - $stat =~ /^.\s*(?:extern\s+)?$Type\s*$Ident\s*\(\s*([^{]+)\s*\)\s*;/s &&
> + $stat =~ /^.\s*(?:extern\s+)?$Type\s*(?:$Ident|\(\s*\*\s*$Ident\s*\))\s*\(\s*([^{]+)\s*\)\s*;/s &&
> $1 ne "void") {
> my $args = trim($1);
> while ($args =~ m/\s*($Type\s*(?:$Ident|\(\s*\*\s*$Ident?\s*\)\s*$balanced_parens)?)/g) {
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web