Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1730573 > unrolled thread

Re: [PATCH 10/13] openrisc: add simple_smp dts and defconfig for simulators

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 10/13] openrisc: add simple_smp dts and defconfig for  simulators Pavel Machek <pavel@ucw.cz> - 2017-09-12 00:40 +0200
    Re: [PATCH 10/13] openrisc: add simple_smp dts and defconfig for simulators Stafford Horne <shorne@gmail.com> - 2017-09-12 01:00 +0200
      Re: [PATCH 10/13] openrisc: add simple_smp dts and defconfig for  simulators Pavel Machek <pavel@ucw.cz> - 2017-09-12 09:50 +0200
        Re: [PATCH 10/13] openrisc: add simple_smp dts and defconfig for  simulators Stafford Horne <shorne@gmail.com> - 2017-09-13 00:20 +0200

#1730573 — Re: [PATCH 10/13] openrisc: add simple_smp dts and defconfig for simulators

[Multipart message — attachments visible in raw view] — view raw

On Thu 2017-08-31 07:03:11, Stafford Horne wrote:
> From: Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>
> 
> Simple enough to be compatible with simulation environments,
> such as verilated systems, QEMU and other targets supporting OpenRISC
> SMP.  This also supports our base FPGA SoC's if the cpu frequency is
> upped to 50Mhz.
> 
> Signed-off-by: Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>
> [shorne@gmail.com: Added defconfig]
> Signed-off-by: Stafford Horne <shorne@gmail.com>
> ---
>  arch/openrisc/boot/dts/simple_smp.dts      | 58 ++++++++++++++++++++++++++
>  arch/openrisc/configs/simple_smp_defconfig | 66 ++++++++++++++++++++++++++++++
>  2 files changed, 124 insertions(+)
>  create mode 100644 arch/openrisc/boot/dts/simple_smp.dts
>  create mode 100644 arch/openrisc/configs/simple_smp_defconfig
> 
> diff --git a/arch/openrisc/boot/dts/simple_smp.dts b/arch/openrisc/boot/dts/simple_smp.dts
> new file mode 100644
> index 000000000000..47c54101baae
> --- /dev/null
> +++ b/arch/openrisc/boot/dts/simple_smp.dts
> @@ -0,0 +1,58 @@
> +/dts-v1/;
> +/ {
> +	compatible = "opencores,or1ksim";

You may want to add some comment on top, explaining what this
is... and perhaps link to some page documenting how to set up
qemu/FPGAs?

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[toc] | [next] | [standalone]

#1730575 — Re: [PATCH 10/13] openrisc: add simple_smp dts and defconfig for simulators

On Tue, Sep 12, 2017 at 7:37 AM, Pavel Machek <pavel@ucw.cz> wrote:
> On Thu 2017-08-31 07:03:11, Stafford Horne wrote:
>> From: Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>
>>
[...]
>> +++ b/arch/openrisc/boot/dts/simple_smp.dts
>> @@ -0,0 +1,58 @@
>> +/dts-v1/;
>> +/ {
>> +     compatible = "opencores,or1ksim";
>
> You may want to add some comment on top, explaining what this
> is... and perhaps link to some page documenting how to set up
> qemu/FPGAs?

Sure, I can create an entry in Documentation/devicetree/binding
documenting this since its been there for a while but was never properly
documented.

But, just to be clear, what do you mean by page?  Are you suggesting
linking to a web page?  Or do you mean something in Documentation/...?

-Stafford

[toc] | [prev] | [next] | [standalone]

#1730717

[Multipart message — attachments visible in raw view] — view raw

On Tue 2017-09-12 07:55:18, Stafford Horne wrote:
> On Tue, Sep 12, 2017 at 7:37 AM, Pavel Machek <pavel@ucw.cz> wrote:
> > On Thu 2017-08-31 07:03:11, Stafford Horne wrote:
> >> From: Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>
> >>
> [...]
> >> +++ b/arch/openrisc/boot/dts/simple_smp.dts
> >> @@ -0,0 +1,58 @@
> >> +/dts-v1/;
> >> +/ {
> >> +     compatible = "opencores,or1ksim";
> >
> > You may want to add some comment on top, explaining what this
> > is... and perhaps link to some page documenting how to set up
> > qemu/FPGAs?
> 
> Sure, I can create an entry in Documentation/devicetree/binding
> documenting this since its been there for a while but was never properly
> documented.

Yep, Documentation/devicetree should be mandatory.

> But, just to be clear, what do you mean by page?  Are you suggesting
> linking to a web page?  Or do you mean something in Documentation/...?

Whatever works for you. Maybe Documentation/ would be better...
									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[toc] | [prev] | [next] | [standalone]

#1731263

On Tue, Sep 12, 2017 at 09:47:02AM +0200, Pavel Machek wrote:
> On Tue 2017-09-12 07:55:18, Stafford Horne wrote:
> > On Tue, Sep 12, 2017 at 7:37 AM, Pavel Machek <pavel@ucw.cz> wrote:
> > > On Thu 2017-08-31 07:03:11, Stafford Horne wrote:
> > >> From: Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>
> > >>
> > [...]
> > >> +++ b/arch/openrisc/boot/dts/simple_smp.dts
> > >> @@ -0,0 +1,58 @@
> > >> +/dts-v1/;
> > >> +/ {
> > >> +     compatible = "opencores,or1ksim";
> > >
> > > You may want to add some comment on top, explaining what this
> > > is... and perhaps link to some page documenting how to set up
> > > qemu/FPGAs?
> > 
> > Sure, I can create an entry in Documentation/devicetree/binding
> > documenting this since its been there for a while but was never properly
> > documented.
> 
> Yep, Documentation/devicetree should be mandatory.
> 
> > But, just to be clear, what do you mean by page?  Are you suggesting
> > linking to a web page?  Or do you mean something in Documentation/...?
> 
> Whatever works for you. Maybe Documentation/ would be better...

Actually, I forgot, we have something but its here:

  arch/openrisc/README.openrisc

I'll work on some patches to move that to Documentation/ and clean it up.

 -Stafford

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web