Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1728227 > unrolled thread
| Started by | Colin King <colin.king@canonical.com> |
|---|---|
| First post | 2017-09-07 16:00 +0200 |
| Last post | 2017-09-16 03:50 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] csi: libcxgbi: remove redundant check and close on csk Colin King <colin.king@canonical.com> - 2017-09-07 16:00 +0200
Re: [PATCH] csi: libcxgbi: remove redundant check and close on csk Varun Prakash <varun@chelsio.com> - 2017-09-11 11:30 +0200
Re: [PATCH] csi: libcxgbi: remove redundant check and close on csk "Martin K. Petersen" <martin.petersen@oracle.com> - 2017-09-16 03:50 +0200
| From | Colin King <colin.king@canonical.com> |
|---|---|
| Date | 2017-09-07 16:00 +0200 |
| Subject | [PATCH] csi: libcxgbi: remove redundant check and close on csk |
| Message-ID | <un5vz-A2-3@gated-at.bofh.it> |
From: Colin Ian King <colin.king@canonical.com>
csk is always null on the error return path and so the non-null
check and call to cxgbi_sock_closed on csk is redundant and
can be removed.
Detected by: CoverityScan CID#114329 ("Logically dead code")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/scsi/cxgbi/libcxgbi.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/scsi/cxgbi/libcxgbi.c b/drivers/scsi/cxgbi/libcxgbi.c
index 512c8f1ea5b0..da36c2de069e 100644
--- a/drivers/scsi/cxgbi/libcxgbi.c
+++ b/drivers/scsi/cxgbi/libcxgbi.c
@@ -688,8 +688,6 @@ cxgbi_check_route(struct sockaddr *dst_addr, int ifindex)
rel_rt:
ip_rt_put(rt);
- if (csk)
- cxgbi_sock_closed(csk);
err_out:
return ERR_PTR(err);
}
--
2.14.1
[toc] | [next] | [standalone]
| From | Varun Prakash <varun@chelsio.com> |
|---|---|
| Date | 2017-09-11 11:30 +0200 |
| Message-ID | <uotcu-10h-13@gated-at.bofh.it> |
| In reply to | #1728227 |
On Thu, Sep 07, 2017 at 02:51:33PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> csk is always null on the error return path and so the non-null
> check and call to cxgbi_sock_closed on csk is redundant and
> can be removed.
>
> Detected by: CoverityScan CID#114329 ("Logically dead code")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/scsi/cxgbi/libcxgbi.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/scsi/cxgbi/libcxgbi.c b/drivers/scsi/cxgbi/libcxgbi.c
> index 512c8f1ea5b0..da36c2de069e 100644
> --- a/drivers/scsi/cxgbi/libcxgbi.c
> +++ b/drivers/scsi/cxgbi/libcxgbi.c
> @@ -688,8 +688,6 @@ cxgbi_check_route(struct sockaddr *dst_addr, int ifindex)
>
> rel_rt:
> ip_rt_put(rt);
> - if (csk)
> - cxgbi_sock_closed(csk);
> err_out:
> return ERR_PTR(err);
> }
Acked-by: Varun Prakash <varun@chelsio.com>
[toc] | [prev] | [next] | [standalone]
| From | "Martin K. Petersen" <martin.petersen@oracle.com> |
|---|---|
| Date | 2017-09-16 03:50 +0200 |
| Message-ID | <uqap4-2TZ-7@gated-at.bofh.it> |
| In reply to | #1728227 |
Colin, > csk is always null on the error return path and so the non-null check > and call to cxgbi_sock_closed on csk is redundant and can be removed. Applied to 4.15/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web