Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1730697 > unrolled thread

Re: [alsa-devel] [PATCH] ALSA: msnd: Optimize / harden DSP and MIDI loops

Started byTakashi Iwai <tiwai@suse.de>
First post2017-09-12 09:20 +0200
Last post2017-09-12 14:40 +0200
Articles 3 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [alsa-devel] [PATCH] ALSA: msnd: Optimize / harden DSP and MIDI    loops Takashi Iwai <tiwai@suse.de> - 2017-09-12 09:20 +0200
    Re: [alsa-devel] [PATCH] ALSA: msnd: Optimize / harden DSP and MIDI  loops "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org> - 2017-09-12 14:40 +0200
      Re: [alsa-devel] [PATCH] ALSA: msnd: Optimize / harden DSP and MIDI loops Takashi Iwai <tiwai@suse.de> - 2017-09-12 14:40 +0200

#1730697 — Re: [alsa-devel] [PATCH] ALSA: msnd: Optimize / harden DSP and MIDI loops

FromTakashi Iwai <tiwai@suse.de>
Date2017-09-12 09:20 +0200
SubjectRe: [alsa-devel] [PATCH] ALSA: msnd: Optimize / harden DSP and MIDI loops
Message-ID<uoNEd-6FT-5@gated-at.bofh.it>
On Fri, 08 Sep 2017 19:47:32 +0200,
Grygorii Tertychnyi (gtertych) wrote:
> 
> 
> >> Hi Greg,
> >>
> >> Could you please apply it for 4.4-stable.
> >> This fixes https://nvd.nist.gov/vuln/detail/CVE-2017-9985
> >
> > This vulnerability is just non-issue.  You can't get it working
> > practically; it requires a modified hardware of the decade old ISA
> > sound card, and yet the system has to load / set up the module
> > beforehand.  We should withdraw it from CVE, IMO.
> 
> I think it is worth having it in 4.4, 4.9 and 4.12 also.

... even though the code has never been tested on the real hardware?
That doesn't sound good for stable kernels at all.  That's why I
didn't put Cc to stable in the patch.


Takashi

[toc] | [next] | [standalone]


#1730839 — Re: [alsa-devel] [PATCH] ALSA: msnd: Optimize / harden DSP and MIDI loops

From"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Date2017-09-12 14:40 +0200
SubjectRe: [alsa-devel] [PATCH] ALSA: msnd: Optimize / harden DSP and MIDI loops
Message-ID<uoSDU-1dW-7@gated-at.bofh.it>
In reply to#1730697
On Tue, Sep 12, 2017 at 09:17:38AM +0200, Takashi Iwai wrote:
> On Fri, 08 Sep 2017 19:47:32 +0200,
> Grygorii Tertychnyi (gtertych) wrote:
> > 
> > 
> > >> Hi Greg,
> > >>
> > >> Could you please apply it for 4.4-stable.
> > >> This fixes https://nvd.nist.gov/vuln/detail/CVE-2017-9985
> > >
> > > This vulnerability is just non-issue.  You can't get it working
> > > practically; it requires a modified hardware of the decade old ISA
> > > sound card, and yet the system has to load / set up the module
> > > beforehand.  We should withdraw it from CVE, IMO.
> > 
> > I think it is worth having it in 4.4, 4.9 and 4.12 also.
> 
> ... even though the code has never been tested on the real hardware?
> That doesn't sound good for stable kernels at all.  That's why I
> didn't put Cc to stable in the patch.

Oh, I didn't know that, want me to drop the patch from the stable queues
now?

thanks,

greg k-h

[toc] | [prev] | [next] | [standalone]


#1730840 — Re: [alsa-devel] [PATCH] ALSA: msnd: Optimize / harden DSP and MIDI loops

FromTakashi Iwai <tiwai@suse.de>
Date2017-09-12 14:40 +0200
SubjectRe: [alsa-devel] [PATCH] ALSA: msnd: Optimize / harden DSP and MIDI loops
Message-ID<uoSDU-1dW-13@gated-at.bofh.it>
In reply to#1730839
On Tue, 12 Sep 2017 14:34:18 +0200,
gregkh@linuxfoundation.org wrote:
> 
> On Tue, Sep 12, 2017 at 09:17:38AM +0200, Takashi Iwai wrote:
> > On Fri, 08 Sep 2017 19:47:32 +0200,
> > Grygorii Tertychnyi (gtertych) wrote:
> > > 
> > > 
> > > >> Hi Greg,
> > > >>
> > > >> Could you please apply it for 4.4-stable.
> > > >> This fixes https://nvd.nist.gov/vuln/detail/CVE-2017-9985
> > > >
> > > > This vulnerability is just non-issue.  You can't get it working
> > > > practically; it requires a modified hardware of the decade old ISA
> > > > sound card, and yet the system has to load / set up the module
> > > > beforehand.  We should withdraw it from CVE, IMO.
> > > 
> > > I think it is worth having it in 4.4, 4.9 and 4.12 also.
> > 
> > ... even though the code has never been tested on the real hardware?
> > That doesn't sound good for stable kernels at all.  That's why I
> > didn't put Cc to stable in the patch.
> 
> Oh, I didn't know that, want me to drop the patch from the stable queues
> now?

Honestly, I don't mind.  The patch should work, and even if it
doesn't, it would be harmless as no one can see the breakage in
practice :)

It's just ridiculous that people urge such commit for stable kernels
even though they never tested / care the real cases but only look at
the CVE entry.


thanks,

Takashi

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web