Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1730524 > unrolled thread

[PATCH] procfs: remove unused variable

Back to article view | Back to linux.kernel

Contents

  [PATCH] procfs: remove unused variable Arnd Bergmann <arnd@arndb.de> - 2017-09-11 22:10 +0200
    Re: [PATCH] procfs: remove unused variable Michal Hocko <mhocko@kernel.org> - 2017-09-12 09:50 +0200

#1730524 — [PATCH] procfs: remove unused variable

in NOMMU configurations, we get a warning about a variable
that has become unused:

fs/proc/task_nommu.c: In function 'nommu_vma_show':
fs/proc/task_nommu.c:148:28: error: unused variable 'priv' [-Werror=unused-variable]

Fixes: 01a949ccf3b9 ("fs, proc: remove priv argument from is_stack")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 fs/proc/task_nommu.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/proc/task_nommu.c b/fs/proc/task_nommu.c
index dea90b566a6e..b00b766098fa 100644
--- a/fs/proc/task_nommu.c
+++ b/fs/proc/task_nommu.c
@@ -145,7 +145,6 @@ static int nommu_vma_show(struct seq_file *m, struct vm_area_struct *vma,
 			  int is_pid)
 {
 	struct mm_struct *mm = vma->vm_mm;
-	struct proc_maps_private *priv = m->private;
 	unsigned long ino = 0;
 	struct file *file;
 	dev_t dev = 0;
-- 
2.9.0

[toc] | [next] | [standalone]

#1730719

On Mon 11-09-17 22:02:16, Arnd Bergmann wrote:
> in NOMMU configurations, we get a warning about a variable
> that has become unused:
> 
> fs/proc/task_nommu.c: In function 'nommu_vma_show':
> fs/proc/task_nommu.c:148:28: error: unused variable 'priv' [-Werror=unused-variable]
> 
> Fixes: 01a949ccf3b9 ("fs, proc: remove priv argument from is_stack")

this sha doesn't exist in Linus tree. I guess it comes from linux-next.
The merged commit is 1240ea0dc3bb ("fs, proc: remove priv argument from
is_stack")

Other than that
Acked-by: Michal Hocko <mhocko@suse.com>

Thanks for catching this and the fix!

> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  fs/proc/task_nommu.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/proc/task_nommu.c b/fs/proc/task_nommu.c
> index dea90b566a6e..b00b766098fa 100644
> --- a/fs/proc/task_nommu.c
> +++ b/fs/proc/task_nommu.c
> @@ -145,7 +145,6 @@ static int nommu_vma_show(struct seq_file *m, struct vm_area_struct *vma,
>  			  int is_pid)
>  {
>  	struct mm_struct *mm = vma->vm_mm;
> -	struct proc_maps_private *priv = m->private;
>  	unsigned long ino = 0;
>  	struct file *file;
>  	dev_t dev = 0;
> -- 
> 2.9.0
> 

-- 
Michal Hocko
SUSE Labs

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web