Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1729286 > unrolled thread
| Started by | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| First post | 2017-09-08 23:00 +0200 |
| Last post | 2017-09-11 21:40 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 1/3] [media] s5p-mfc: Delete an error message for a failed memory allocation in s5p_mfc_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-08 23:00 +0200
Re: [PATCH 1/3] [media] s5p-mfc: Delete an error message for a failed memory allocation in s5p_mfc_probe() Sylwester Nawrocki <s.nawrocki@samsung.com> - 2017-09-11 11:20 +0200
Re: [media] s5p-mfc: Delete an error message for a failed memory allocation in s5p_mfc_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-11 21:40 +0200
| From | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| Date | 2017-09-08 23:00 +0200 |
| Subject | [PATCH 1/3] [media] s5p-mfc: Delete an error message for a failed memory allocation in s5p_mfc_probe() |
| Message-ID | <unyxA-3Kx-19@gated-at.bofh.it> |
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 8 Sep 2017 22:25:17 +0200
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/media/platform/s5p-mfc/s5p_mfc.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc.c b/drivers/media/platform/s5p-mfc/s5p_mfc.c
index 1afde5021ca6..8af45d53846f 100644
--- a/drivers/media/platform/s5p-mfc/s5p_mfc.c
+++ b/drivers/media/platform/s5p-mfc/s5p_mfc.c
@@ -1270,10 +1270,8 @@ static int s5p_mfc_probe(struct platform_device *pdev)
pr_debug("%s++\n", __func__);
dev = devm_kzalloc(&pdev->dev, sizeof(*dev), GFP_KERNEL);
- if (!dev) {
- dev_err(&pdev->dev, "Not enough memory for MFC device\n");
+ if (!dev)
return -ENOMEM;
- }
spin_lock_init(&dev->irqlock);
spin_lock_init(&dev->condlock);
--
2.14.1
[toc] | [next] | [standalone]
| From | Sylwester Nawrocki <s.nawrocki@samsung.com> |
|---|---|
| Date | 2017-09-11 11:20 +0200 |
| Subject | Re: [PATCH 1/3] [media] s5p-mfc: Delete an error message for a failed memory allocation in s5p_mfc_probe() |
| Message-ID | <uot2P-Wk-35@gated-at.bofh.it> |
| In reply to | #1729286 |
On 09/08/2017 10:51 PM, SF Markus Elfring wrote: > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring<elfring@users.sourceforge.net> Could you make the commit summary shorter, to keep it below 70 characters [1]? With that changed feel free to add Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com> -- Regards, Sylwester [1] Documentation/process/submitting-patches.rst
[toc] | [prev] | [next] | [standalone]
| From | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| Date | 2017-09-11 21:40 +0200 |
| Subject | Re: [media] s5p-mfc: Delete an error message for a failed memory allocation in s5p_mfc_probe() |
| Message-ID | <uoCIO-7F7-35@gated-at.bofh.it> |
| In reply to | #1730227 |
> Could you make the commit summary shorter, to keep it > below 70 characters [1]? With that changed feel free to add > > Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com> … > [1] Documentation/process/submitting-patches.rst Will it be sufficient that a patch committer will adjust the summary phrase a bit? Regards, Markus
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web