Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1729045 > unrolled thread

[PATCH] signal: remove unused variable mask

Started byColin King <colin.king@canonical.com>
First post2017-09-08 18:00 +0200
Last post2017-09-08 19:20 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] signal: remove unused variable mask Colin King <colin.king@canonical.com> - 2017-09-08 18:00 +0200
    Re: [PATCH] signal: remove unused variable mask Al Viro <viro@ZenIV.linux.org.uk> - 2017-09-08 19:20 +0200

#1729045 — [PATCH] signal: remove unused variable mask

FromColin King <colin.king@canonical.com>
Date2017-09-08 18:00 +0200
Subject[PATCH] signal: remove unused variable mask
Message-ID<untRf-Aj-11@gated-at.bofh.it>
From: Colin Ian King <colin.king@canonical.com>

The variable mask was introduced by an earlier commit and does not seem
to be used, so remove it.

Fixes gcc warning:
kernel/signal.c:3443:19: warning: unused variable ‘mask’ [-Wunused-variable]

Fixes: fc271087ebcb ("signal: replace sigset_to_compat() with put_compat_sigset()")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 kernel/signal.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/kernel/signal.c b/kernel/signal.c
index 3198a7d2e5ff..36a523640894 100644
--- a/kernel/signal.c
+++ b/kernel/signal.c
@@ -3440,7 +3440,6 @@ COMPAT_SYSCALL_DEFINE4(rt_sigaction, int, sig,
 
 	if (act) {
 		compat_uptr_t handler;
-		compat_sigset_t mask;
 		ret = get_user(handler, &act->sa_handler);
 		new_ka.sa.sa_handler = compat_ptr(handler);
 #ifdef __ARCH_HAS_SA_RESTORER
-- 
2.14.1

[toc] | [next] | [standalone]


#1729103

FromAl Viro <viro@ZenIV.linux.org.uk>
Date2017-09-08 19:20 +0200
Message-ID<unv6G-1yj-23@gated-at.bofh.it>
In reply to#1729045
On Fri, Sep 08, 2017 at 04:56:39PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The variable mask was introduced by an earlier commit and does not seem
> to be used, so remove it.

Equivalent is already folded into the original commit in my tree; will
push out tonight

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web