Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1729258 > unrolled thread

[PATCH] [media] pxa_camera: Delete an error message for a failed memory allocation in pxa_camera_probe()

Back to article view | Back to linux.kernel

Contents

  [PATCH] [media] pxa_camera: Delete an error message for a failed  memory allocation in pxa_camera_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-08 22:20 +0200
    Re: [PATCH] [media] pxa_camera: Delete an error message for a failed memory allocation in pxa_camera_probe() Robert Jarzmik <robert.jarzmik@free.fr> - 2017-09-09 14:50 +0200

#1729258 — [PATCH] [media] pxa_camera: Delete an error message for a failed memory allocation in pxa_camera_probe()

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 8 Sep 2017 22:05:14 +0200

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/media/platform/pxa_camera.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/media/platform/pxa_camera.c b/drivers/media/platform/pxa_camera.c
index edca993c2b1f..d2a4432a98ea 100644
--- a/drivers/media/platform/pxa_camera.c
+++ b/drivers/media/platform/pxa_camera.c
@@ -2362,10 +2362,8 @@ static int pxa_camera_probe(struct platform_device *pdev)
 		return -ENODEV;
 
 	pcdev = devm_kzalloc(&pdev->dev, sizeof(*pcdev), GFP_KERNEL);
-	if (!pcdev) {
-		dev_err(&pdev->dev, "Could not allocate pcdev\n");
+	if (!pcdev)
 		return -ENOMEM;
-	}
 
 	pcdev->clk = devm_clk_get(&pdev->dev, NULL);
 	if (IS_ERR(pcdev->clk))
-- 
2.14.1

[toc] | [next] | [standalone]

#1729441 — Re: [PATCH] [media] pxa_camera: Delete an error message for a failed memory allocation in pxa_camera_probe()

SF Markus Elfring <elfring@users.sourceforge.net> writes:

> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Fri, 8 Sep 2017 22:05:14 +0200
>
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>

Cheers.

--
Robert

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web