Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1728273 > unrolled thread
| Started by | Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> |
|---|---|
| First post | 2017-09-07 17:40 +0200 |
| Last post | 2017-09-09 06:00 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] net: ethernet: ti: netcp_core: no need in netif_napi_del Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> - 2017-09-07 17:40 +0200
Re: [PATCH] net: ethernet: ti: netcp_core: no need in netif_napi_del David Miller <davem@davemloft.net> - 2017-09-09 06:00 +0200
| From | Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> |
|---|---|
| Date | 2017-09-07 17:40 +0200 |
| Subject | [PATCH] net: ethernet: ti: netcp_core: no need in netif_napi_del |
| Message-ID | <un74l-1Wq-5@gated-at.bofh.it> |
Don't remove rx_napi specifically just before free_netdev(), it's supposed to be done in it and is confusing w/o tx_napi deletion. Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> --- Based on net-next/master drivers/net/ethernet/ti/netcp_core.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/ti/netcp_core.c b/drivers/net/ethernet/ti/netcp_core.c index eb96a69..437d362 100644 --- a/drivers/net/ethernet/ti/netcp_core.c +++ b/drivers/net/ethernet/ti/netcp_core.c @@ -2145,7 +2145,6 @@ static void netcp_delete_interface(struct netcp_device *netcp_device, of_node_put(netcp->node_interface); unregister_netdev(ndev); - netif_napi_del(&netcp->rx_napi); free_netdev(ndev); } -- 2.7.4
[toc] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2017-09-09 06:00 +0200 |
| Subject | Re: [PATCH] net: ethernet: ti: netcp_core: no need in netif_napi_del |
| Message-ID | <unF62-8hg-5@gated-at.bofh.it> |
| In reply to | #1728273 |
From: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> Date: Thu, 7 Sep 2017 18:32:30 +0300 > Don't remove rx_napi specifically just before free_netdev(), > it's supposed to be done in it and is confusing w/o tx_napi deletion. > > Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> Applied.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web