Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1728078 > unrolled thread
| Started by | Hoegeun Kwon <hoegeun.kwon@samsung.com> |
|---|---|
| First post | 2017-09-07 11:40 +0200 |
| Last post | 2017-09-09 22:00 +0200 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH v2 2/3] ARM: dts: exynos: Add clean name of compatible. Hoegeun Kwon <hoegeun.kwon@samsung.com> - 2017-09-07 11:40 +0200
Re: [PATCH v2 2/3] ARM: dts: exynos: Add clean name of compatible. Marek Szyprowski <m.szyprowski@samsung.com> - 2017-09-07 13:30 +0200
Re: [PATCH v2 2/3] ARM: dts: exynos: Add clean name of compatible. Hoegeun Kwon <hoegeun.kwon@samsung.com> - 2017-09-08 04:50 +0200
Re: [PATCH v2 2/3] ARM: dts: exynos: Add clean name of compatible. kbuild test robot <lkp@intel.com> - 2017-09-09 22:00 +0200
| From | Hoegeun Kwon <hoegeun.kwon@samsung.com> |
|---|---|
| Date | 2017-09-07 11:40 +0200 |
| Subject | [PATCH v2 2/3] ARM: dts: exynos: Add clean name of compatible. |
| Message-ID | <un1rX-6w7-1@gated-at.bofh.it> |
Exynos 5250 and 5420 have different hardware rotation limits. However,
currently it uses only one compatible - "exynos5-gsc". Since we have
to distinguish between these two, we add different compatible.
Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com>
---
arch/arm/boot/dts/exynos5250.dtsi | 8 ++++----
arch/arm/boot/dts/exynos5420.dtsi | 4 ++--
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index 8dbeb87..f795c76 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -637,7 +637,7 @@
};
gsc_0: gsc@13e00000 {
- compatible = "samsung,exynos5-gsc";
+ compatible = "samsung,exynos5-gsc", samsung,exynos5250-gsc";
reg = <0x13e00000 0x1000>;
interrupts = <GIC_SPI 85 IRQ_TYPE_LEVEL_HIGH>;
power-domains = <&pd_gsc>;
@@ -647,7 +647,7 @@
};
gsc_1: gsc@13e10000 {
- compatible = "samsung,exynos5-gsc";
+ compatible = "samsung,exynos5-gsc", samsung,exynos5250-gsc";
reg = <0x13e10000 0x1000>;
interrupts = <GIC_SPI 86 IRQ_TYPE_LEVEL_HIGH>;
power-domains = <&pd_gsc>;
@@ -657,7 +657,7 @@
};
gsc_2: gsc@13e20000 {
- compatible = "samsung,exynos5-gsc";
+ compatible = "samsung,exynos5-gsc", samsung,exynos5250-gsc";
reg = <0x13e20000 0x1000>;
interrupts = <GIC_SPI 87 IRQ_TYPE_LEVEL_HIGH>;
power-domains = <&pd_gsc>;
@@ -667,7 +667,7 @@
};
gsc_3: gsc@13e30000 {
- compatible = "samsung,exynos5-gsc";
+ compatible = "samsung,exynos5-gsc", samsung,exynos5250-gsc";
reg = <0x13e30000 0x1000>;
interrupts = <GIC_SPI 88 IRQ_TYPE_LEVEL_HIGH>;
power-domains = <&pd_gsc>;
diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
index 02d2f89..86afe77 100644
--- a/arch/arm/boot/dts/exynos5420.dtsi
+++ b/arch/arm/boot/dts/exynos5420.dtsi
@@ -658,7 +658,7 @@
};
gsc_0: video-scaler@13e00000 {
- compatible = "samsung,exynos5-gsc";
+ compatible = "samsung,exynos5-gsc", "samsung,exynos5420-gsc";
reg = <0x13e00000 0x1000>;
interrupts = <GIC_SPI 85 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clock CLK_GSCL0>;
@@ -668,7 +668,7 @@
};
gsc_1: video-scaler@13e10000 {
- compatible = "samsung,exynos5-gsc";
+ compatible = "samsung,exynos5-gsc", "samsung,exynos5420-gsc";
reg = <0x13e10000 0x1000>;
interrupts = <GIC_SPI 86 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clock CLK_GSCL1>;
--
1.9.1
[toc] | [next] | [standalone]
| From | Marek Szyprowski <m.szyprowski@samsung.com> |
|---|---|
| Date | 2017-09-07 13:30 +0200 |
| Message-ID | <un3aq-7Hu-9@gated-at.bofh.it> |
| In reply to | #1728078 |
Hi Hoegeun,
On 2017-09-07 11:39, Hoegeun Kwon wrote:
> Exynos 5250 and 5420 have different hardware rotation limits. However,
> currently it uses only one compatible - "exynos5-gsc". Since we have
> to distinguish between these two, we add different compatible.
>
> Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com>
The new values (5250/5420 specific) should replace old exynos5-gsc,
there is no
point providing both in dts.
> ---
> arch/arm/boot/dts/exynos5250.dtsi | 8 ++++----
> arch/arm/boot/dts/exynos5420.dtsi | 4 ++--
> 2 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
> index 8dbeb87..f795c76 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -637,7 +637,7 @@
> };
>
> gsc_0: gsc@13e00000 {
> - compatible = "samsung,exynos5-gsc";
> + compatible = "samsung,exynos5-gsc", samsung,exynos5250-gsc";
> reg = <0x13e00000 0x1000>;
> interrupts = <GIC_SPI 85 IRQ_TYPE_LEVEL_HIGH>;
> power-domains = <&pd_gsc>;
> @@ -647,7 +647,7 @@
> };
>
> gsc_1: gsc@13e10000 {
> - compatible = "samsung,exynos5-gsc";
> + compatible = "samsung,exynos5-gsc", samsung,exynos5250-gsc";
> reg = <0x13e10000 0x1000>;
> interrupts = <GIC_SPI 86 IRQ_TYPE_LEVEL_HIGH>;
> power-domains = <&pd_gsc>;
> @@ -657,7 +657,7 @@
> };
>
> gsc_2: gsc@13e20000 {
> - compatible = "samsung,exynos5-gsc";
> + compatible = "samsung,exynos5-gsc", samsung,exynos5250-gsc";
> reg = <0x13e20000 0x1000>;
> interrupts = <GIC_SPI 87 IRQ_TYPE_LEVEL_HIGH>;
> power-domains = <&pd_gsc>;
> @@ -667,7 +667,7 @@
> };
>
> gsc_3: gsc@13e30000 {
> - compatible = "samsung,exynos5-gsc";
> + compatible = "samsung,exynos5-gsc", samsung,exynos5250-gsc";
> reg = <0x13e30000 0x1000>;
> interrupts = <GIC_SPI 88 IRQ_TYPE_LEVEL_HIGH>;
> power-domains = <&pd_gsc>;
> diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
> index 02d2f89..86afe77 100644
> --- a/arch/arm/boot/dts/exynos5420.dtsi
> +++ b/arch/arm/boot/dts/exynos5420.dtsi
> @@ -658,7 +658,7 @@
> };
>
> gsc_0: video-scaler@13e00000 {
> - compatible = "samsung,exynos5-gsc";
> + compatible = "samsung,exynos5-gsc", "samsung,exynos5420-gsc";
> reg = <0x13e00000 0x1000>;
> interrupts = <GIC_SPI 85 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&clock CLK_GSCL0>;
> @@ -668,7 +668,7 @@
> };
>
> gsc_1: video-scaler@13e10000 {
> - compatible = "samsung,exynos5-gsc";
> + compatible = "samsung,exynos5-gsc", "samsung,exynos5420-gsc";
> reg = <0x13e10000 0x1000>;
> interrupts = <GIC_SPI 86 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&clock CLK_GSCL1>;
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
[toc] | [prev] | [next] | [standalone]
| From | Hoegeun Kwon <hoegeun.kwon@samsung.com> |
|---|---|
| Date | 2017-09-08 04:50 +0200 |
| Message-ID | <unhwJ-Gp-7@gated-at.bofh.it> |
| In reply to | #1728158 |
On 09/07/2017 08:27 PM, Marek Szyprowski wrote:
> Hi Hoegeun,
>
> On 2017-09-07 11:39, Hoegeun Kwon wrote:
>> Exynos 5250 and 5420 have different hardware rotation limits. However,
>> currently it uses only one compatible - "exynos5-gsc". Since we have
>> to distinguish between these two, we add different compatible.
>>
>> Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com>
>
> The new values (5250/5420 specific) should replace old exynos5-gsc,
> there is no
> point providing both in dts.
>
Hi Marek,
Thanks for your review.
I used both compatibles to not modify v4l2.
But v4l2 will also be fixed, so 'exynos5-gsc' will be removed.
And also, Thanks for your comment for of_device_get_match_data() of
patch(3/3).
Best regards,
Hoegeun
>> ---
>> arch/arm/boot/dts/exynos5250.dtsi | 8 ++++----
>> arch/arm/boot/dts/exynos5420.dtsi | 4 ++--
>> 2 files changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos5250.dtsi
>> b/arch/arm/boot/dts/exynos5250.dtsi
>> index 8dbeb87..f795c76 100644
>> --- a/arch/arm/boot/dts/exynos5250.dtsi
>> +++ b/arch/arm/boot/dts/exynos5250.dtsi
>> @@ -637,7 +637,7 @@
>> };
>> gsc_0: gsc@13e00000 {
>> - compatible = "samsung,exynos5-gsc";
>> + compatible = "samsung,exynos5-gsc",
>> samsung,exynos5250-gsc";
>> reg = <0x13e00000 0x1000>;
>> interrupts = <GIC_SPI 85 IRQ_TYPE_LEVEL_HIGH>;
>> power-domains = <&pd_gsc>;
>> @@ -647,7 +647,7 @@
>> };
>> gsc_1: gsc@13e10000 {
>> - compatible = "samsung,exynos5-gsc";
>> + compatible = "samsung,exynos5-gsc",
>> samsung,exynos5250-gsc";
>> reg = <0x13e10000 0x1000>;
>> interrupts = <GIC_SPI 86 IRQ_TYPE_LEVEL_HIGH>;
>> power-domains = <&pd_gsc>;
>> @@ -657,7 +657,7 @@
>> };
>> gsc_2: gsc@13e20000 {
>> - compatible = "samsung,exynos5-gsc";
>> + compatible = "samsung,exynos5-gsc",
>> samsung,exynos5250-gsc";
>> reg = <0x13e20000 0x1000>;
>> interrupts = <GIC_SPI 87 IRQ_TYPE_LEVEL_HIGH>;
>> power-domains = <&pd_gsc>;
>> @@ -667,7 +667,7 @@
>> };
>> gsc_3: gsc@13e30000 {
>> - compatible = "samsung,exynos5-gsc";
>> + compatible = "samsung,exynos5-gsc",
>> samsung,exynos5250-gsc";
>> reg = <0x13e30000 0x1000>;
>> interrupts = <GIC_SPI 88 IRQ_TYPE_LEVEL_HIGH>;
>> power-domains = <&pd_gsc>;
>> diff --git a/arch/arm/boot/dts/exynos5420.dtsi
>> b/arch/arm/boot/dts/exynos5420.dtsi
>> index 02d2f89..86afe77 100644
>> --- a/arch/arm/boot/dts/exynos5420.dtsi
>> +++ b/arch/arm/boot/dts/exynos5420.dtsi
>> @@ -658,7 +658,7 @@
>> };
>> gsc_0: video-scaler@13e00000 {
>> - compatible = "samsung,exynos5-gsc";
>> + compatible = "samsung,exynos5-gsc",
>> "samsung,exynos5420-gsc";
>> reg = <0x13e00000 0x1000>;
>> interrupts = <GIC_SPI 85 IRQ_TYPE_LEVEL_HIGH>;
>> clocks = <&clock CLK_GSCL0>;
>> @@ -668,7 +668,7 @@
>> };
>> gsc_1: video-scaler@13e10000 {
>> - compatible = "samsung,exynos5-gsc";
>> + compatible = "samsung,exynos5-gsc",
>> "samsung,exynos5420-gsc";
>> reg = <0x13e10000 0x1000>;
>> interrupts = <GIC_SPI 86 IRQ_TYPE_LEVEL_HIGH>;
>> clocks = <&clock CLK_GSCL1>;
>
> Best regards
[toc] | [prev] | [next] | [standalone]
| From | kbuild test robot <lkp@intel.com> |
|---|---|
| Date | 2017-09-09 22:00 +0200 |
| Message-ID | <unU54-1wg-17@gated-at.bofh.it> |
| In reply to | #1728078 |
[Multipart message — attachments visible in raw view] — view raw
Hi Hoegeun,
[auto build test ERROR on robh/for-next]
[also build test ERROR on v4.13 next-20170908]
[cannot apply to drm-exynos/exynos-drm/for-next]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Hoegeun-Kwon/drm-exynos-gsc-Support-the-hardware-rotation-limits/20170910-015155
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: arm-at91_dt_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=arm
All errors (new ones prefixed by >>):
>> Error: arch/arm/boot/dts/exynos5250.dtsi:640.40-41 syntax error
FATAL ERROR: Unable to parse input tree
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web