Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1725585 > unrolled thread
| Started by | Ben Hutchings <ben@decadent.org.uk> |
|---|---|
| First post | 2017-09-03 02:20 +0200 |
| Last post | 2017-09-05 15:40 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] workqueue: Fix flag collision Ben Hutchings <ben@decadent.org.uk> - 2017-09-03 02:20 +0200
Re: [PATCH] workqueue: Fix flag collision Tejun Heo <tj@kernel.org> - 2017-09-05 15:40 +0200
| From | Ben Hutchings <ben@decadent.org.uk> |
|---|---|
| Date | 2017-09-03 02:20 +0200 |
| Subject | [PATCH] workqueue: Fix flag collision |
| Message-ID | <ulqNP-1ev-3@gated-at.bofh.it> |
[Multipart message — attachments visible in raw view] — view raw
Commit 0a94efb5acbb ("workqueue: implicit ordered attribute should be
overridable") introduced a __WQ_ORDERED_EXPLICIT flag but gave it the
same value as __WQ_LEGACY. I don't believe these were intended to
mean the same thing, so renumber __WQ_ORDERED_EXPLICIT.
Fixes: 0a94efb5acbb ("workqueue: implicit ordered attribute should be ...")
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Cc: stable@vger.kernel.org
---
include/linux/workqueue.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/workqueue.h b/include/linux/workqueue.h
index db6dc9dc0482..1c49431f3121 100644
--- a/include/linux/workqueue.h
+++ b/include/linux/workqueue.h
@@ -323,8 +323,8 @@ enum {
__WQ_DRAINING = 1 << 16, /* internal: workqueue is draining */
__WQ_ORDERED = 1 << 17, /* internal: workqueue is ordered */
- __WQ_ORDERED_EXPLICIT = 1 << 18, /* internal: alloc_ordered_workqueue() */
__WQ_LEGACY = 1 << 18, /* internal: create*_workqueue() */
+ __WQ_ORDERED_EXPLICIT = 1 << 19, /* internal: alloc_ordered_workqueue() */
WQ_MAX_ACTIVE = 512, /* I like 512, better ideas? */
WQ_MAX_UNBOUND_PER_CPU = 4, /* 4 * #cpus for unbound wq */
[toc] | [next] | [standalone]
| From | Tejun Heo <tj@kernel.org> |
|---|---|
| Date | 2017-09-05 15:40 +0200 |
| Message-ID | <ummf9-3dY-41@gated-at.bofh.it> |
| In reply to | #1725585 |
On Sun, Sep 03, 2017 at 01:18:41AM +0100, Ben Hutchings wrote:
> Commit 0a94efb5acbb ("workqueue: implicit ordered attribute should be
> overridable") introduced a __WQ_ORDERED_EXPLICIT flag but gave it the
> same value as __WQ_LEGACY. I don't believe these were intended to
> mean the same thing, so renumber __WQ_ORDERED_EXPLICIT.
>
> Fixes: 0a94efb5acbb ("workqueue: implicit ordered attribute should be ...")
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> Cc: stable@vger.kernel.org
Oops, applied to wq/for-4.14.
Thanks.
--
tejun
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web