Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1726634 > unrolled thread

[PATCH] [media] cx25840: make array stds static const, reduces object code size

Started byColin King <colin.king@canonical.com>
First post2017-09-05 13:10 +0200
Last post2017-09-05 13:10 +0200
Articles 1 — 1 participant

Back to article view | Back to linux.kernel


Contents

  [PATCH] [media] cx25840: make array stds static const, reduces object code size Colin King <colin.king@canonical.com> - 2017-09-05 13:10 +0200

#1726634 — [PATCH] [media] cx25840: make array stds static const, reduces object code size

FromColin King <colin.king@canonical.com>
Date2017-09-05 13:10 +0200
Subject[PATCH] [media] cx25840: make array stds static const, reduces object code size
Message-ID<umjTZ-1V1-47@gated-at.bofh.it>
From: Colin Ian King <colin.king@canonical.com>

Don't populate the array syds on the stack, instead make it static const.
Makes the object code smaller by over 280 bytes:

Before:
   text	   data	    bss	    dec	    hex	filename
  81451	  12784	    704	  94939	  172db	cx25840-core.o

   text	   data	    bss	    dec	    hex	filename
  81070	  12880	    704	  94654	  171be	cx25840-core.o

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/media/i2c/cx25840/cx25840-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/i2c/cx25840/cx25840-core.c b/drivers/media/i2c/cx25840/cx25840-core.c
index 39f51daa7558..f38bf819d805 100644
--- a/drivers/media/i2c/cx25840/cx25840-core.c
+++ b/drivers/media/i2c/cx25840/cx25840-core.c
@@ -1745,7 +1745,7 @@ static int cx25840_g_std(struct v4l2_subdev *sd, v4l2_std_id *std)
 {
 	struct i2c_client *client = v4l2_get_subdevdata(sd);
 
-	v4l2_std_id stds[] = {
+	static const v4l2_std_id stds[] = {
 		/* 0000 */ V4L2_STD_UNKNOWN,
 
 		/* 0001 */ V4L2_STD_NTSC_M,
-- 
2.14.1

[toc] | [standalone]


Back to top | Article view | linux.kernel


csiph-web