Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1726312 > unrolled thread

[PATCH] arm64: Convert pr_warning to standard pr_warn

Started bychengjian c00427203 <cj.chengjian@huawei.com>
First post2017-09-05 04:30 +0200
Last post2017-09-06 16:20 +0200
Articles 6 — 5 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] arm64: Convert pr_warning to standard pr_warn chengjian c00427203 <cj.chengjian@huawei.com> - 2017-09-05 04:30 +0200
    Re: [PATCH] arm64: Convert pr_warning to standard pr_warn Mark Rutland <mark.rutland@arm.com> - 2017-09-05 11:20 +0200
      Re: [PATCH] arm64: Convert pr_warning to standard pr_warn "chengjian (D)" <cj.chengjian@huawei.com> - 2017-09-05 11:30 +0200
      Re: [PATCH] arm64: Convert pr_warning to standard pr_warn Joe Perches <joe@perches.com> - 2017-09-05 20:40 +0200
        Re: [PATCH] arm64: Convert pr_warning to standard pr_warn Mark Rutland <mark.rutland@arm.com> - 2017-09-06 11:30 +0200
          Re: [PATCH] arm64: Convert pr_warning to standard pr_warn Catalin Marinas <catalin.marinas@arm.com> - 2017-09-06 16:20 +0200

#1726312 — [PATCH] arm64: Convert pr_warning to standard pr_warn

Fromchengjian c00427203 <cj.chengjian@huawei.com>
Date2017-09-05 04:30 +0200
Subject[PATCH] arm64: Convert pr_warning to standard pr_warn
Message-ID<umbMJ-5d5-1@gated-at.bofh.it>
Convert pr_warning to standard pr_warn in arch/arm64/kernel/smp.c

Signed-off-by: Cheng Jian <cj.chengjian@huawei.com>
---
 arch/arm64/kernel/smp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c
index 9f7195a..efcaa05 100644
--- a/arch/arm64/kernel/smp.c
+++ b/arch/arm64/kernel/smp.c
@@ -972,7 +972,7 @@ void smp_send_stop(void)
 		udelay(1);
 
 	if (num_online_cpus() > 1)
-		pr_warning("SMP: failed to stop secondary CPUs %*pbl\n",
+		pr_warn("SMP: failed to stop secondary CPUs %*pbl\n",
 			   cpumask_pr_args(cpu_online_mask));
 }
 
@@ -1009,7 +1009,7 @@ void crash_smp_send_stop(void)
 		udelay(1);
 
 	if (atomic_read(&waiting_for_crash_ipi) > 0)
-		pr_warning("SMP: failed to stop secondary CPUs %*pbl\n",
+		pr_warn("SMP: failed to stop secondary CPUs %*pbl\n",
 			   cpumask_pr_args(&mask));
 }
 
-- 
1.8.3.1

[toc] | [next] | [standalone]

#1726579

FromMark Rutland <mark.rutland@arm.com>
Date2017-09-05 11:20 +0200
Message-ID<umibw-OE-9@gated-at.bofh.it>
In reply to#1726312
On Tue, Sep 05, 2017 at 10:28:38AM +0800, chengjian c00427203 wrote:
> Convert pr_warning to standard pr_warn in arch/arm64/kernel/smp.c
> 
> Signed-off-by: Cheng Jian <cj.chengjian@huawei.com>
> ---
>  arch/arm64/kernel/smp.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Is this a step towards removing pr_warning entirely?

If so, can you please fix up all occurences in arm64? i.e.

[mark@leverpostej:~/src/linux]% git grep pr_warning linux-next/master:arch/arm64
linux-next/master:arch/arm64:include/asm/syscall.h:             pr_warning("%s called with max args %d, handling only %d\n",
linux-next/master:arch/arm64:include/asm/syscall.h:             pr_warning("%s called with max args %d, handling only %d\n",
linux-next/master:arch/arm64:kernel/hw_breakpoint.c:            pr_warning("unknown slot type: %d\n", type);
linux-next/master:arch/arm64:kernel/hw_breakpoint.c:            pr_warning("attempt to read from unknown breakpoint register %d\n", n);
linux-next/master:arch/arm64:kernel/hw_breakpoint.c:            pr_warning("attempt to write to unknown breakpoint register %d\n", n);
linux-next/master:arch/arm64:kernel/hw_breakpoint.c:            pr_warning("invalid breakpoint privilege level %d\n", privilege);
linux-next/master:arch/arm64:kernel/smp.c:              pr_warning("SMP: failed to stop secondary CPUs %*pbl\n",
linux-next/master:arch/arm64:kernel/smp.c:              pr_warning("SMP: failed to stop secondary CPUs %*pbl\n",

Otherwise, I don't think it make sense to only fix some occurences.

Thanks,
Mark.

> 
> diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c
> index 9f7195a..efcaa05 100644
> --- a/arch/arm64/kernel/smp.c
> +++ b/arch/arm64/kernel/smp.c
> @@ -972,7 +972,7 @@ void smp_send_stop(void)
>  		udelay(1);
>  
>  	if (num_online_cpus() > 1)
> -		pr_warning("SMP: failed to stop secondary CPUs %*pbl\n",
> +		pr_warn("SMP: failed to stop secondary CPUs %*pbl\n",
>  			   cpumask_pr_args(cpu_online_mask));
>  }
>  
> @@ -1009,7 +1009,7 @@ void crash_smp_send_stop(void)
>  		udelay(1);
>  
>  	if (atomic_read(&waiting_for_crash_ipi) > 0)
> -		pr_warning("SMP: failed to stop secondary CPUs %*pbl\n",
> +		pr_warn("SMP: failed to stop secondary CPUs %*pbl\n",
>  			   cpumask_pr_args(&mask));
>  }
>  
> -- 
> 1.8.3.1
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[toc] | [prev] | [next] | [standalone]

#1726582

From"chengjian (D)" <cj.chengjian@huawei.com>
Date2017-09-05 11:30 +0200
Message-ID<umilb-S9-7@gated-at.bofh.it>
In reply to#1726579
Hi Mark,

OK, I will do it now



> On Tue, Sep 05, 2017 at 10:28:38AM +0800, chengjian c00427203 wrote:
>> Convert pr_warning to standard pr_warn in arch/arm64/kernel/smp.c
>>
>> Signed-off-by: Cheng Jian <cj.chengjian@huawei.com>
>> ---
>>   arch/arm64/kernel/smp.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
> Is this a step towards removing pr_warning entirely?
>
> If so, can you please fix up all occurences in arm64? i.e.
>
> [mark@leverpostej:~/src/linux]% git grep pr_warning linux-next/master:arch/arm64
> linux-next/master:arch/arm64:include/asm/syscall.h:             pr_warning("%s called with max args %d, handling only %d\n",
> linux-next/master:arch/arm64:include/asm/syscall.h:             pr_warning("%s called with max args %d, handling only %d\n",
> linux-next/master:arch/arm64:kernel/hw_breakpoint.c:            pr_warning("unknown slot type: %d\n", type);
> linux-next/master:arch/arm64:kernel/hw_breakpoint.c:            pr_warning("attempt to read from unknown breakpoint register %d\n", n);
> linux-next/master:arch/arm64:kernel/hw_breakpoint.c:            pr_warning("attempt to write to unknown breakpoint register %d\n", n);
> linux-next/master:arch/arm64:kernel/hw_breakpoint.c:            pr_warning("invalid breakpoint privilege level %d\n", privilege);
> linux-next/master:arch/arm64:kernel/smp.c:              pr_warning("SMP: failed to stop secondary CPUs %*pbl\n",
> linux-next/master:arch/arm64:kernel/smp.c:              pr_warning("SMP: failed to stop secondary CPUs %*pbl\n",
>
> Otherwise, I don't think it make sense to only fix some occurences.
>
> Thanks,
> Mark.
>
>> diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c
>> index 9f7195a..efcaa05 100644
>> --- a/arch/arm64/kernel/smp.c
>> +++ b/arch/arm64/kernel/smp.c
>> @@ -972,7 +972,7 @@ void smp_send_stop(void)
>>   		udelay(1);
>>   
>>   	if (num_online_cpus() > 1)
>> -		pr_warning("SMP: failed to stop secondary CPUs %*pbl\n",
>> +		pr_warn("SMP: failed to stop secondary CPUs %*pbl\n",
>>   			   cpumask_pr_args(cpu_online_mask));
>>   }
>>   
>> @@ -1009,7 +1009,7 @@ void crash_smp_send_stop(void)
>>   		udelay(1);
>>   
>>   	if (atomic_read(&waiting_for_crash_ipi) > 0)
>> -		pr_warning("SMP: failed to stop secondary CPUs %*pbl\n",
>> +		pr_warn("SMP: failed to stop secondary CPUs %*pbl\n",
>>   			   cpumask_pr_args(&mask));
>>   }
>>   
>> -- 
>> 1.8.3.1
>>
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> .
>

[toc] | [prev] | [next] | [standalone]

#1726923

FromJoe Perches <joe@perches.com>
Date2017-09-05 20:40 +0200
Message-ID<umqVs-6sg-19@gated-at.bofh.it>
In reply to#1726579
On Tue, 2017-09-05 at 10:10 +0100, Mark Rutland wrote:
> On Tue, Sep 05, 2017 at 10:28:38AM +0800, chengjian c00427203 wrote:
> > Convert pr_warning to standard pr_warn in arch/arm64/kernel/smp.c
> > 
> > Signed-off-by: Cheng Jian <cj.chengjian@huawei.com>
> > ---
> >  arch/arm64/kernel/smp.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> Is this a step towards removing pr_warning entirely?
> 
> If so, can you please fix up all occurences in arm64? i.e.

https://patchwork.kernel.org/patch/9578907/

[toc] | [prev] | [next] | [standalone]

#1727289

FromMark Rutland <mark.rutland@arm.com>
Date2017-09-06 11:30 +0200
Message-ID<umEOK-85j-11@gated-at.bofh.it>
In reply to#1726923
On Tue, Sep 05, 2017 at 11:38:23AM -0700, Joe Perches wrote:
> On Tue, 2017-09-05 at 10:10 +0100, Mark Rutland wrote:
> > On Tue, Sep 05, 2017 at 10:28:38AM +0800, chengjian c00427203 wrote:
> > > Convert pr_warning to standard pr_warn in arch/arm64/kernel/smp.c
> > > 
> > > Signed-off-by: Cheng Jian <cj.chengjian@huawei.com>
> > > ---
> > >  arch/arm64/kernel/smp.c | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > Is this a step towards removing pr_warning entirely?
> > 
> > If so, can you please fix up all occurences in arm64? i.e.
> 
> https://patchwork.kernel.org/patch/9578907/
> 

Ah, I thought I'd seen this before. :)

Catalin, Will, are you happy with Joe's patch?

Thanks,
Mark.

[toc] | [prev] | [next] | [standalone]

#1727533

FromCatalin Marinas <catalin.marinas@arm.com>
Date2017-09-06 16:20 +0200
Message-ID<umJlo-2UP-13@gated-at.bofh.it>
In reply to#1727289
On Wed, Sep 06, 2017 at 10:21:26AM +0100, Mark Rutland wrote:
> On Tue, Sep 05, 2017 at 11:38:23AM -0700, Joe Perches wrote:
> > On Tue, 2017-09-05 at 10:10 +0100, Mark Rutland wrote:
> > > On Tue, Sep 05, 2017 at 10:28:38AM +0800, chengjian c00427203 wrote:
> > > > Convert pr_warning to standard pr_warn in arch/arm64/kernel/smp.c
> > > > 
> > > > Signed-off-by: Cheng Jian <cj.chengjian@huawei.com>
> > > > ---
> > > >  arch/arm64/kernel/smp.c | 4 ++--
> > > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > 
> > > Is this a step towards removing pr_warning entirely?
> > > 
> > > If so, can you please fix up all occurences in arm64? i.e.
> > 
> > https://patchwork.kernel.org/patch/9578907/
> 
> Ah, I thought I'd seen this before. :)
> 
> Catalin, Will, are you happy with Joe's patch?

Yes, though I thought they'd go in via other tree (e.g.
kernel-janitors).

-- 
Catalin

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web