Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1727785 > unrolled thread
| Started by | Srishti Sharma <srishtishar@gmail.com> |
|---|---|
| First post | 2017-09-07 00:10 +0200 |
| Last post | 2017-09-07 09:20 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH v4] Staging: ccree: ssi_cipher.c: Remove unused variable. Srishti Sharma <srishtishar@gmail.com> - 2017-09-07 00:10 +0200
Re: [Outreachy kernel] [PATCH v4] Staging: ccree: ssi_cipher.c: Remove unused variable. Julia Lawall <julia.lawall@lip6.fr> - 2017-09-07 09:00 +0200
Re: [Outreachy kernel] [PATCH v4] Staging: ccree: ssi_cipher.c: Remove unused variable. Srishti Sharma <srishtishar@gmail.com> - 2017-09-07 09:20 +0200
| From | Srishti Sharma <srishtishar@gmail.com> |
|---|---|
| Date | 2017-09-07 00:10 +0200 |
| Subject | [PATCH v4] Staging: ccree: ssi_cipher.c: Remove unused variable. |
| Message-ID | <umQGd-7S3-3@gated-at.bofh.it> |
Remove local variable inflight_counter, as it is never used.
Signed-off-by: Srishti Sharma <srishtishar@gmail.com>
---
Change in v4:
-There is no longer a need to make the comment more comprehensible, as I
have deleted the variable associated with it. The v3 of this patch was
not based on the original patch, hence v4.
drivers/staging/ccree/ssi_cipher.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/ccree/ssi_cipher.c b/drivers/staging/ccree/ssi_cipher.c
index 8d31a93..1ff3c8a 100644
--- a/drivers/staging/ccree/ssi_cipher.c
+++ b/drivers/staging/ccree/ssi_cipher.c
@@ -697,13 +697,10 @@ static int ssi_blkcipher_complete(struct device *dev,
void __iomem *cc_base)
{
int completion_error = 0;
- u32 inflight_counter;
struct ablkcipher_request *req = (struct ablkcipher_request *)areq;
ssi_buffer_mgr_unmap_blkcipher_request(dev, req_ctx, ivsize, src, dst);
- /*Set the inflight couter value to local variable*/
- inflight_counter = ctx_p->drvdata->inflight_counter;
/*Decrease the inflight counter*/
if (ctx_p->flow_mode == BYPASS && ctx_p->drvdata->inflight_counter > 0)
ctx_p->drvdata->inflight_counter--;
--
2.7.4
[toc] | [next] | [standalone]
| From | Julia Lawall <julia.lawall@lip6.fr> |
|---|---|
| Date | 2017-09-07 09:00 +0200 |
| Subject | Re: [Outreachy kernel] [PATCH v4] Staging: ccree: ssi_cipher.c: Remove unused variable. |
| Message-ID | <umYX7-4NP-1@gated-at.bofh.it> |
| In reply to | #1727785 |
One last detail. The subject line above is not in the same format as that
of all of the other subject lines one commits affecting this file. You
can use git log --oneline to see what others have done. It is not really
possible to guess correctly. However, one does not generally include the
extension on a filename.
julia
On Thu, 7 Sep 2017, Srishti Sharma wrote:
> Remove local variable inflight_counter, as it is never used.
>
> Signed-off-by: Srishti Sharma <srishtishar@gmail.com>
> ---
> Change in v4:
> -There is no longer a need to make the comment more comprehensible, as I
> have deleted the variable associated with it. The v3 of this patch was
> not based on the original patch, hence v4.
> drivers/staging/ccree/ssi_cipher.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/staging/ccree/ssi_cipher.c b/drivers/staging/ccree/ssi_cipher.c
> index 8d31a93..1ff3c8a 100644
> --- a/drivers/staging/ccree/ssi_cipher.c
> +++ b/drivers/staging/ccree/ssi_cipher.c
> @@ -697,13 +697,10 @@ static int ssi_blkcipher_complete(struct device *dev,
> void __iomem *cc_base)
> {
> int completion_error = 0;
> - u32 inflight_counter;
> struct ablkcipher_request *req = (struct ablkcipher_request *)areq;
>
> ssi_buffer_mgr_unmap_blkcipher_request(dev, req_ctx, ivsize, src, dst);
>
> - /*Set the inflight couter value to local variable*/
> - inflight_counter = ctx_p->drvdata->inflight_counter;
> /*Decrease the inflight counter*/
> if (ctx_p->flow_mode == BYPASS && ctx_p->drvdata->inflight_counter > 0)
> ctx_p->drvdata->inflight_counter--;
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1504735553-13753-1-git-send-email-srishtishar%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
[toc] | [prev] | [next] | [standalone]
| From | Srishti Sharma <srishtishar@gmail.com> |
|---|---|
| Date | 2017-09-07 09:20 +0200 |
| Subject | Re: [Outreachy kernel] [PATCH v4] Staging: ccree: ssi_cipher.c: Remove unused variable. |
| Message-ID | <umZgv-5bg-21@gated-at.bofh.it> |
| In reply to | #1727950 |
On Thu, Sep 7, 2017 at 12:24 PM, Julia Lawall <julia.lawall@lip6.fr> wrote:
> One last detail. The subject line above is not in the same format as that
> of all of the other subject lines one commits affecting this file. You
> can use git log --oneline to see what others have done. It is not really
> possible to guess correctly. However, one does not generally include the
> extension on a filename.
>
Yes, they have not used the filename in the subject line . So I'll change it to
the required format .
Thanks ,
Srishti
> julia
>
> On Thu, 7 Sep 2017, Srishti Sharma wrote:
>
>> Remove local variable inflight_counter, as it is never used.
>>
>> Signed-off-by: Srishti Sharma <srishtishar@gmail.com>
>> ---
>> Change in v4:
>> -There is no longer a need to make the comment more comprehensible, as I
>> have deleted the variable associated with it. The v3 of this patch was
>> not based on the original patch, hence v4.
>> drivers/staging/ccree/ssi_cipher.c | 3 ---
>> 1 file changed, 3 deletions(-)
>>
>> diff --git a/drivers/staging/ccree/ssi_cipher.c b/drivers/staging/ccree/ssi_cipher.c
>> index 8d31a93..1ff3c8a 100644
>> --- a/drivers/staging/ccree/ssi_cipher.c
>> +++ b/drivers/staging/ccree/ssi_cipher.c
>> @@ -697,13 +697,10 @@ static int ssi_blkcipher_complete(struct device *dev,
>> void __iomem *cc_base)
>> {
>> int completion_error = 0;
>> - u32 inflight_counter;
>> struct ablkcipher_request *req = (struct ablkcipher_request *)areq;
>>
>> ssi_buffer_mgr_unmap_blkcipher_request(dev, req_ctx, ivsize, src, dst);
>>
>> - /*Set the inflight couter value to local variable*/
>> - inflight_counter = ctx_p->drvdata->inflight_counter;
>> /*Decrease the inflight counter*/
>> if (ctx_p->flow_mode == BYPASS && ctx_p->drvdata->inflight_counter > 0)
>> ctx_p->drvdata->inflight_counter--;
>> --
>> 2.7.4
>>
>> --
>> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
>> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
>> To post to this group, send email to outreachy-kernel@googlegroups.com.
>> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1504735553-13753-1-git-send-email-srishtishar%40gmail.com.
>> For more options, visit https://groups.google.com/d/optout.
>>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web