Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1727677 > unrolled thread
| Started by | Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com> |
|---|---|
| First post | 2017-09-06 20:30 +0200 |
| Last post | 2017-09-08 19:40 +0200 |
| Articles | 4 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] ARC: AXS10x: Add temporary quirk to reset ethernet IP Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com> - 2017-09-06 20:30 +0200
Re: [PATCH] ARC: AXS10x: Add temporary quirk to reset ethernet IP Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2017-09-06 22:00 +0200
Re: [PATCH] ARC: AXS10x: Add temporary quirk to reset ethernet IP Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com> - 2017-09-08 19:20 +0200
Re: [PATCH] ARC: AXS10x: Add temporary quirk to reset ethernet IP Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2017-09-08 19:40 +0200
| From | Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com> |
|---|---|
| Date | 2017-09-06 20:30 +0200 |
| Subject | [PATCH] ARC: AXS10x: Add temporary quirk to reset ethernet IP |
| Message-ID | <umNfk-5xO-15@gated-at.bofh.it> |
DW ethernet controller on AXS10x hangs sometimes after SW reset, so add temporary quirk to reset DW ethernet controller IP core. This quirk can be removed after axs10x reset driver (see http://patchwork.ozlabs.org/patch/800273/) or simple reset driver (see https://patchwork.kernel.org/patch/9903375/) will be available in upstream. Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com> --- arch/arc/plat-axs10x/axs10x.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/arch/arc/plat-axs10x/axs10x.c b/arch/arc/plat-axs10x/axs10x.c index f1ac679..cf14ebc 100644 --- a/arch/arc/plat-axs10x/axs10x.c +++ b/arch/arc/plat-axs10x/axs10x.c @@ -111,6 +111,13 @@ static void __init axs10x_early_init(void) axs10x_enable_gpio_intc_wire(); + /* + * Reset ethernet IP core. + * TODO: get rid of this quirk after axs10x reset driver (or simple + * reset driver) will be available in upstream. + */ + iowrite32((1 << 5), (void __iomem *) CREG_MB_SW_RESET); + scnprintf(mb, 32, "MainBoard v%d", mb_rev); axs10x_print_board_ver(CREG_MB_VER, mb); } -- 2.9.3
[toc] | [next] | [standalone]
| From | Vineet Gupta <Vineet.Gupta1@synopsys.com> |
|---|---|
| Date | 2017-09-06 22:00 +0200 |
| Message-ID | <umOEq-6jL-7@gated-at.bofh.it> |
| In reply to | #1727677 |
On 09/06/2017 11:21 AM, Eugeniy Paltsev wrote: > DW ethernet controller on AXS10x hangs sometimes after SW reset, so > add temporary quirk to reset DW ethernet controller IP core. > This quirk can be removed after axs10x reset driver > (see http://patchwork.ozlabs.org/patch/800273/) > or simple reset driver > (see https://patchwork.kernel.org/patch/9903375/) > will be available in upstream. > > Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com> Added to for-next ! Thx, > --- > arch/arc/plat-axs10x/axs10x.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arc/plat-axs10x/axs10x.c b/arch/arc/plat-axs10x/axs10x.c > index f1ac679..cf14ebc 100644 > --- a/arch/arc/plat-axs10x/axs10x.c > +++ b/arch/arc/plat-axs10x/axs10x.c > @@ -111,6 +111,13 @@ static void __init axs10x_early_init(void) > > axs10x_enable_gpio_intc_wire(); > > + /* > + * Reset ethernet IP core. > + * TODO: get rid of this quirk after axs10x reset driver (or simple > + * reset driver) will be available in upstream. > + */ > + iowrite32((1 << 5), (void __iomem *) CREG_MB_SW_RESET); > + > scnprintf(mb, 32, "MainBoard v%d", mb_rev); > axs10x_print_board_ver(CREG_MB_VER, mb); > } >
[toc] | [prev] | [next] | [standalone]
| From | Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com> |
|---|---|
| Date | 2017-09-08 19:20 +0200 |
| Message-ID | <unv6G-1yj-11@gated-at.bofh.it> |
| In reply to | #1727693 |
On Wed, 2017-09-06 at 12:54 -0700, Vineet Gupta wrote: > On 09/06/2017 11:21 AM, Eugeniy Paltsev wrote: > > DW ethernet controller on AXS10x hangs sometimes after SW reset, so > > add temporary quirk to reset DW ethernet controller IP core. > > This quirk can be removed after axs10x reset driver > > (see http://patchwork.ozlabs.org/patch/800273/) > > or simple reset driver > > (see https://patchwork.kernel.org/patch/9903375/) > > will be available in upstream. > > > > Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com> > > Added to for-next ! > > Thx, Hi Vineet, Please specify if you have plans to add this patch to 4.14? I'm asking because we mostly need this quirk in 4.14 - I hope generic simple reset driver will be available in 4.15. Thanks. > > > --- > > arch/arc/plat-axs10x/axs10x.c | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/arch/arc/plat-axs10x/axs10x.c b/arch/arc/plat-axs10x/axs10x.c > > index f1ac679..cf14ebc 100644 > > --- a/arch/arc/plat-axs10x/axs10x.c > > +++ b/arch/arc/plat-axs10x/axs10x.c > > @@ -111,6 +111,13 @@ static void __init axs10x_early_init(void) > > > > axs10x_enable_gpio_intc_wire(); > > > > + /* > > + * Reset ethernet IP core. > > + * TODO: get rid of this quirk after axs10x reset driver (or simple > > + * reset driver) will be available in upstream. > > + */ > > + iowrite32((1 << 5), (void __iomem *) CREG_MB_SW_RESET); > > + > > scnprintf(mb, 32, "MainBoard v%d", mb_rev); > > axs10x_print_board_ver(CREG_MB_VER, mb); > > } > > > > -- Eugeniy Paltsev
[toc] | [prev] | [next] | [standalone]
| From | Vineet Gupta <Vineet.Gupta1@synopsys.com> |
|---|---|
| Date | 2017-09-08 19:40 +0200 |
| Message-ID | <unvq1-1Fs-11@gated-at.bofh.it> |
| In reply to | #1729098 |
On 09/08/2017 10:14 AM, Eugeniy Paltsev wrote: > On Wed, 2017-09-06 at 12:54 -0700, Vineet Gupta wrote: >> On 09/06/2017 11:21 AM, Eugeniy Paltsev wrote: >>> DW ethernet controller on AXS10x hangs sometimes after SW reset, so >>> add temporary quirk to reset DW ethernet controller IP core. >>> This quirk can be removed after axs10x reset driver >>> (see http://patchwork.ozlabs.org/patch/800273/) >>> or simple reset driver >>> (see https://patchwork.kernel.org/patch/9903375/) >>> will be available in upstream. >>> >>> Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com> >> Added to for-next ! >> >> Thx, > Hi Vineet, > > Please specify if you have plans to add this patch to 4.14? > > I'm asking because we mostly need this quirk in 4.14 - I hope generic simple > reset driver will be available in 4.15. New code can't be added during the merge window ! I've applied it locally and it will happen after rc1 is out !
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web