Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1727216 > unrolled thread

4.13 on thinkpad x220: oops when writing to SD card

Back to article view | Back to linux.kernel

Contents

  4.13 on thinkpad x220: oops when writing to SD card Seraphime Kirkovski <kirkseraph@gmail.com> - 2017-09-06 10:30 +0200
    Re: 4.13 on thinkpad x220: oops when writing to SD card Pavel Machek <pavel@ucw.cz> - 2017-09-08 11:40 +0200

#1727216 — 4.13 on thinkpad x220: oops when writing to SD card

Hi,

> > Seems 4.13-rc4 was already broken for that but unfortuantely
> > I didn't
> > reproduce that. So maybe Seraphime can do git-bisect as he said "I 
> > get
> > it everytime" for which I assume it could be easy for him to find 
> > out
> > the problematic commit?

I can reliably reproduce it, although sometimes it needs some more work.
For example, I couldn't trigger it while writing less than 1 gigabyte
and sometimes I have to do it more than once. It helps if the machine is
doing something else in meantime, I do kernel builds.

> Another unrelated issue with mmc_init_request() is that
> mmc_exit_request()
> is not called if mmc_init_request() fails, which means 
> mmc_init_request()
> must free anything it allocates when it fails.

I'm running your patch for 45 minutes now, it looks like it's fixing the 
issue on 4.13 81a84ad3cb5711cec79.

P.S. Sorry about the formatting, have to fix my editor

[toc] | [next] | [standalone]

#1728727

[Multipart message — attachments visible in raw view] — view raw

On Wed 2017-09-06 10:20:35, Seraphime Kirkovski wrote:
> Hi,
> 
> > > Seems 4.13-rc4 was already broken for that but unfortuantely
> > > I didn't
> > > reproduce that. So maybe Seraphime can do git-bisect as he said "I 
> > > get
> > > it everytime" for which I assume it could be easy for him to find 
> > > out
> > > the problematic commit?
> 
> I can reliably reproduce it, although sometimes it needs some more work.
> For example, I couldn't trigger it while writing less than 1 gigabyte
> and sometimes I have to do it more than once. It helps if the machine is
> doing something else in meantime, I do kernel builds.
> 
> > Another unrelated issue with mmc_init_request() is that
> > mmc_exit_request()
> > is not called if mmc_init_request() fails, which means 
> > mmc_init_request()
> > must free anything it allocates when it fails.
> 
> I'm running your patch for 45 minutes now, it looks like it's fixing the 
> issue on 4.13 81a84ad3cb5711cec79.
> 
> P.S. Sorry about the formatting, have to fix my editor

Thanks for quick testing :-). And your formatting is still better than
some...


									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web